[Openvpn-devel] [PATCH applied] Re: Implement listing on IPv4/IPv6 dual socket on all platform

2013-11-29 Thread Gert Doering
ACK. Some minor changes (v6only moved into the if() clause where the setsockopt() is called, option.bind_ipv6_only initialization fixed, --ipv6only fixed in manpage), but no actual functional changes. Patch has been applied to the master branch and pushed. commit a2c2faaeae66867055ee411aff924ef

Re: [Openvpn-devel] [Patch v2 6/9] Implement dual stack client support for OpenVPN

2013-11-29 Thread Gert Doering
Hi, On Fri, Nov 29, 2013 at 08:48:24PM +0100, Arne Schwabe wrote: > > So - amended patch below. Arne, could you please verify that these changes > > are all good and formally ACK again? Transparency, and such :-) > > ACK and thanks for doing my work :) Well, without your previous work, we've ne

[Openvpn-devel] [PATCH applied] Re: Move ASSERT so external-key with OpenSSL works again

2013-11-29 Thread Gert Doering
Your patch has been applied to the master branch. commit 68793f40e1d04409264d21dd24453d959828a306 Author: Arne Schwabe List-Post: openvpn-devel@lists.sourceforge.net Date: Fri Nov 29 13:32:40 2013 +0100 Move ASSERT so external-key with OpenSSL works again Acked-by: Steffan Karger

Re: [Openvpn-devel] [PATCH 10/10] Implement dual stack client support for OpenVPN

2013-11-29 Thread Gert Doering
Hi Tore, On Sat, Jun 22, 2013 at 12:48:20PM +0200, Tore Anderson wrote: > >> On Sat, Dec 15, 2012 at 11:23:52AM +0100, Tore Anderson wrote: > >> [..] > >>> ACK, I tested several different fail-over scenarios and all worked fine. > >>> Also all my pre-existing VPNs (maintained by GNOME NetworkManag

Re: [Openvpn-devel] [Patch v2 6/9] Implement dual stack client support for OpenVPN

2013-11-29 Thread Arne Schwabe
Am 29.11.13 20:42, schrieb Gert Doering: > Hi, > > On Mon, Nov 25, 2013 at 01:31:17PM +0100, Arne Schwabe wrote: >> This patch contains a number of changes. I did not further spit this since >> some changes make only sense being changed together. > ACK, but... > > - some parts of the patch did no

Re: [Openvpn-devel] [Patch v2 6/9] Implement dual stack client support for OpenVPN

2013-11-29 Thread Gert Doering
Hi, On Mon, Nov 25, 2013 at 01:31:17PM +0100, Arne Schwabe wrote: > This patch contains a number of changes. I did not further spit this since > some changes make only sense being changed together. ACK, but... - some parts of the patch did not apply cleanly due to whitespace issues (most li

Re: [Openvpn-devel] [PATCH] Move ASSERT so external-key with OpenSSL works again

2013-11-29 Thread Steffan Karger
ACK -Steffan > -Original Message- > From: Arne Schwabe [mailto:a...@rfc2549.org] > Sent: vrijdag 29 november 2013 13:33 > To: openvpn-devel@lists.sourceforge.net > Subject: [Openvpn-devel] [PATCH] Move ASSERT so external-key with > OpenSSL works again > > --- > src/openvpn/ssl_openssl.c

[Openvpn-devel] [PATCH] Move ASSERT so external-key with OpenSSL works again

2013-11-29 Thread Arne Schwabe
--- src/openvpn/ssl_openssl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/openvpn/ssl_openssl.c b/src/openvpn/ssl_openssl.c index 120aa66..f41bb71 100644 --- a/src/openvpn/ssl_openssl.c +++ b/src/openvpn/ssl_openssl.c @@ -682,10 +682,11 @@ tls_ctx_use_external_private