Re: [Openvpn-devel] [PATCH] t_client.sh: Check for fping/fping6 availability

2013-11-15 Thread Gert Doering
Hi, On Fri, Nov 15, 2013 at 07:25:19PM +0100, Matthias Andree wrote: > > +# Check for external dependencies > > +which fping > /dev/null > ... > > NAK. > which is not a POSIX command, > so you may introduce false skips here. Which platform is it missing? My spot check found it on all BSDs, Mac

Re: [Openvpn-devel] [PATCH] t_client.sh: Check for fping/fping6 availability

2013-11-15 Thread Matthias Andree
Am 15.11.2013 18:12, schrieb David Sommerseth: > From: David Sommerseth > > Check if fping and fping6 is available before running the real tests, > to avoid misleading test failures. > > Signed-off-by: David Sommerseth > --- > tests/t_client.sh.in | 12 > 1 file changed, 12 insert

[Openvpn-devel] [PATCH] t_client.sh: Check for fping/fping6 availability

2013-11-15 Thread David Sommerseth
From: David Sommerseth Check if fping and fping6 is available before running the real tests, to avoid misleading test failures. Signed-off-by: David Sommerseth --- tests/t_client.sh.in | 12 1 file changed, 12 insertions(+) diff --git a/tests/t_client.sh.in b/tests/t_client.sh.in

[Openvpn-devel] [PATCH applied] Re: Document authfile for socks server

2013-11-15 Thread Gert Doering
Your patch has been applied to the master and release/2.3 branches. commit e0a7471f250e25a384a23dfb9efd2ffef83be913 (master) commit a478420a1cba6ee96e2cecbcd5e20a7946c557f0 (release/2.3) Author: Davide Brini List-Post: openvpn-devel@lists.sourceforge.net Date: Sun Sep 15 14:31:49 2013 +0200

[Openvpn-devel] [PATCH applied] Re: tls_ctx_load_ca: Improve certificate error messages

2013-11-15 Thread Gert Doering
Your patch has been applied to the master and release/2.3 branches. commit 9927cdbd929bebbba0d15bb9a6b03453891a485b (master) commit 2f3c65f352086b557a5a9dcf2b54eda08a7962f8 (release/2.3) Author: Klee Dienes List-Post: openvpn-devel@lists.sourceforge.net Date: Sat Jul 6 17:00:02 2013 -0400

Re: [Openvpn-devel] [PATCH] Document authfile for socks server

2013-11-15 Thread Heiko Hund
On Sunday 15 September 2013 14:31:49 Davide Brini wrote: > It looks like it's possible to specify an optional authfile as third > argument of the "socks-proxy" directive. This patch updates the man page to > document that. There's this third parameter and it does what you say. ACK. Regards Heiko

Re: [Openvpn-devel] [PATCH] Floating: Add support for floating in TLS mode (upd.)

2013-11-15 Thread Heikki Hannikainen
On Wed, Oct 30, 2013 at 10:12 PM, André Valentin wrote: > Add support for floating in tls mode using the HMAC of a packet. It costs > a roundtrip through the clients. Its security comes from a secret key, both > peers have. This key and the data form the signature used, which is then > checked aga

Re: [Openvpn-devel] [PATCH] Fix argument type warning introduced by http extra proxy header patch.

2013-11-15 Thread Gert Doering
Hi, On Fri, Nov 15, 2013 at 04:00:25PM +0100, Arne Schwabe wrote: > Am 15.11.13 15:41, schrieb Gert Doering: > > d0cb816cf8be68359617b61a55799f6330901f6a introduced add_proxy_headers(), > > passing "port" as "const char *" - but it should be an "int". As port > > is not yet actually used inside a

Re: [Openvpn-devel] [PATCH] Fix argument type warning introduced by http extra proxy header patch.

2013-11-15 Thread Arne Schwabe
Am 15.11.13 15:41, schrieb Gert Doering: > d0cb816cf8be68359617b61a55799f6330901f6a introduced add_proxy_headers(), > passing "port" as "const char *" - but it should be an "int". As port > is not yet actually used inside add_proxy_headers(), it's just a warning. > > Signed-off-by: Gert Doering >

Re: [Openvpn-devel] tls_ctx_load_ca: Improve certificate error messages

2013-11-15 Thread Steffan Karger
A little late, but ACK from me. -Steffan From: Nicholas Hall [mailto:ngh...@gmail.com] Sent: donderdag 22 augustus 2013 21:57 To: openvpn-devel@lists.sourceforge.net Subject: [Openvpn-devel] tls_ctx_load_ca: Improve certificate error messages >From https://github.com/OpenVPN/openvpn/pull/4 (I am

[Openvpn-devel] [PATCH] Fix argument type warning introduced by http extra proxy header patch.

2013-11-15 Thread Gert Doering
d0cb816cf8be68359617b61a55799f6330901f6a introduced add_proxy_headers(), passing "port" as "const char *" - but it should be an "int". As port is not yet actually used inside add_proxy_headers(), it's just a warning. Signed-off-by: Gert Doering --- src/openvpn/proxy.c | 2 +- 1 file changed, 1

[Openvpn-devel] [PATCH applied] Re: Add reporting of UI version to basic push-peer-info set.

2013-11-15 Thread Gert Doering
ACK (by James and me, in one of the IRC Meetings and on the Hackathon). Your patch has been applied to the master and release/2.3 branches. commit f3a2cd255a3bc73a546a5e2d09fa30a16cce0d7d (master) commit ca2c4a9da769ceefd7e79829362ed054f667536b (master) Author: Arne Schwabe List-Post: openvpn-de

[Openvpn-devel] [PATCH applied] Re: Implement custom HTTP header for http-proxy, always send user-agent

2013-11-15 Thread Gert Doering
ACK. Your patch has been applied to the master branch, with some whitespace fixes, and one typo fix in a string in show_http_proxy_options(). commit d0cb816cf8be68359617b61a55799f6330901f6a (master) Author: Arne Schwabe List-Post: openvpn-devel@lists.sourceforge.net Date: Fri Oct 25 10:02:23 2