Re: [Openvpn-devel] [Openvpn-users] pull requests on github

2013-08-20 Thread David Sommerseth
On 20/08/13 11:29, Gert Doering wrote: > Hi, > > On Tue, Aug 20, 2013 at 12:01:33PM +0300, Samuli Seppänen wrote: >>> We've had questions on #openvpn-devel about pull request 7, which was the >>> first time (on request *7*) that anyone was taking note that we offer >>> pull requests at all - so th

Re: [Openvpn-devel] [Openvpn-users] pull requests on github

2013-08-20 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 19/08/13 23:01, Gert Doering wrote: > On Mon, Aug 19, 2013 at 09:21:03PM +0300, Samuli Seppänen wrote: >> I think we should keep the pull requests enabled. Even if we >> don't merge the changes directly, they are a fairly lightweight >> way to contr

Re: [Openvpn-devel] [Openvpn-users] pull requests on github

2013-08-20 Thread Gert Doering
Hi, On Tue, Aug 20, 2013 at 12:01:33PM +0300, Samuli Seppänen wrote: > > We've had questions on #openvpn-devel about pull request 7, which was the > > first time (on request *7*) that anyone was taking note that we offer > > pull requests at all - so there's 7 pull requests out there that are > >

Re: [Openvpn-devel] [Openvpn-users] pull requests on github

2013-08-20 Thread Samuli Seppänen
> Hi, > > (moving this to -devel) > > On Mon, Aug 19, 2013 at 09:21:03PM +0300, Samuli Seppänen wrote: >> I think we should keep the pull requests enabled. Even if we don't merge >> the changes directly, they are a fairly lightweight way to contribute. >> If somebody sends a useful pull request (l

Re: [Openvpn-devel] [Openvpn-users] wrong encoding handling in netsh.exe

2013-08-20 Thread Gert Doering
Hi, On Tue, Aug 20, 2013 at 01:04:34PM +0600, ??? wrote: > ok, I'll try to rewrite it in more elegant way. > what's wrong with pull requests ? if someone doesn't like them, why to > use github so ? There's nothing wrong with pull requests per se, but it's not the way the currently active