Re: [Openvpn-devel] [PATCH] build: update INSTALL to recent changes

2012-06-03 Thread Gert Doering
Hi, On Sun, Jun 03, 2012 at 02:32:34PM +0300, Alon Bar-Lev wrote: > >> Signed-off-by: Alon Bar-Lev > >> --- > >>  INSTALL |  144 > >> +-- [..] > I think that most of this file is obsolete... That might very well be... > maybe someon

Re: [Openvpn-devel] [PATCH 6/8] Allow routes to be set before opening tun, similar to ifconfig before opening tun

2012-06-03 Thread Alon Bar-Lev
Gert, You can see the tun branch[1]. I changed this per platform. Alon. [1] https://github.com/alonbl/openvpn/commits/tun [2] https://github.com/alonbl/openvpn/commit/4d2fc1f21e6c5cba163ec481119370235c736672 On Sun, Jun 3, 2012 at 1:11 PM, Gert Doering wrote: > Hi, > > On Sat, Jun 02, 2012 at 0

Re: [Openvpn-devel] [PATCH] build: update INSTALL to recent changes

2012-06-03 Thread Alon Bar-Lev
On Sun, Jun 3, 2012 at 1:19 PM, Gert Doering wrote: > Hi, > > On Sat, Jun 02, 2012 at 06:30:15PM +0300, Alon Bar-Lev wrote: >> Signed-off-by: Alon Bar-Lev >> --- >>  INSTALL |  144 >> +-- > > Thanks for covering this missing piece. > >

Re: [Openvpn-devel] [PATCH] build: update INSTALL to recent changes

2012-06-03 Thread Gert Doering
Hi, On Sat, Jun 02, 2012 at 06:30:15PM +0300, Alon Bar-Lev wrote: > Signed-off-by: Alon Bar-Lev > --- > INSTALL | 144 > +-- Thanks for covering this missing piece. One thing that caught my eye while reading this: > @@ -75,13 +74,16

Re: [Openvpn-devel] [PATCH 6/8] Allow routes to be set before opening tun, similar to ifconfig before opening tun

2012-06-03 Thread Gert Doering
Hi, On Sat, Jun 02, 2012 at 06:45:47PM +0200, Arne Schwabe wrote: > > returning a macro value, instead of just redefine the > > ROUTE_ORDER_DEFAULT macro for those platforms who need ROUTE_AFTER_TUN > > and use the ROUTE_ORDER_DEFAULT macro directly where needed? > > > > And for type-safety, would

Re: [Openvpn-devel] [PATCH 3/8] Only use tmpdir if tmp_dir is really used.

2012-06-03 Thread Gert Doering
Hi, On Sat, Jun 02, 2012 at 06:28:37PM +0200, David Sommerseth wrote: > As we're trying to kill off syshead.h in v2.4, it might rather make > sense to try to avoid extending syshead.h. I see the benefit from > code clarity point of view. But I'd probably just recommend to check > for P2MP_SERVER

Re: [Openvpn-devel] [PATCH 1/8] Silence Port is now 1194 IANA warning if remote option with port is used

2012-06-03 Thread Gert Doering
HI, On Sat, Jun 02, 2012 at 06:24:03PM +0200, David Sommerseth wrote: > Instead of this change, wouldn't it rather make sense to just remove > the whole "#if 1 /* JYFIXME -- port warning */" block in init.c:2470 > instead? This "new" port number was introduced in November 2004, so > I'd say this