On Thu, Mar 29, 2012 at 7:26 PM, michael-dev wrote:
> Hi,
>
> On Thu, 29 Mar 2012 18:10:24 +0200, Alon Bar-Lev wrote:
>> For example...
>>
>> at your end:
>> ---
>> ./configure
>> make
>> make dist
>> ---
>>
>> at other people end:
>> ---
>> tar -xf
>> cp -a openvpn* openvpn*.org
>> cd openvpn*
>
Hi,
On Thu, 29 Mar 2012 18:10:24 +0200, Alon Bar-Lev wrote:
For example...
at your end:
---
./configure
make
make dist
---
at other people end:
---
tar -xf
cp -a openvpn* openvpn*.org
cd openvpn*
msvc-dev
cd ..
diff -urNp openvp* openvpn*.org
---
will result in a complete change of all mi
Having the text auto detection is a risk, as the detection may detect
text files that are not text and vise versa.
Having global setting will create confusion and differentiate between
users. So this patch also move this to local repository.
Having git to check out files differently in different
On Thu, Mar 29, 2012 at 4:05 PM, David Sommerseth
wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On 29/03/12 15:12, Alon Bar-Lev wrote:
>> On Thu, Mar 29, 2012 at 3:00 PM, David Sommerseth
>> wrote:
>>> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1
>>>
>>> On 29/03/12 14:51, Alon Ba
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 29/03/12 15:12, Alon Bar-Lev wrote:
> On Thu, Mar 29, 2012 at 3:00 PM, David Sommerseth
> wrote:
>> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1
>>
>> On 29/03/12 14:51, Alon Bar-Lev wrote:
>>> This is not good. Another issue of this MIME magic
Having the text auto detection is a risk, as the detection may detect
text files that are not text and vise versa.
Having global setting will create confusion and differentiate between
users. So this patch also move this to local repository.
Having git to check out files differently in different
On Thu, Mar 29, 2012 at 3:00 PM, David Sommerseth
wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On 29/03/12 14:51, Alon Bar-Lev wrote:
>> This is not good. Another issue of this MIME magic that should be
>> avoided. VC files are CRLF, if we do not commit them this way,
>> every time
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 29/03/12 14:51, Alon Bar-Lev wrote:
> This is not good. Another issue of this MIME magic that should be
> avoided. VC files are CRLF, if we do not commit them this way,
> every time they change we see a complete rewrite.
>
> If you do not want to p
This is not good.
Another issue of this MIME magic that should be avoided.
VC files are CRLF, if we do not commit them this way, every time they
change we see a complete rewrite.
If you do not want to pull, please do:
find . -name '*.sln' -or -name '*.vcxproj.*' | xargs unix2dos
And commit.
On
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 28/02/12 17:29, Adriaan de Jong wrote:
> The serial length was one digit too short, resulting in missing
> digits at the end of the certificate's stringified serial number.
>
> Signed-off-by: Adriaan de Jong ---
> ssl_verify_polarssl.c |2 +-
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 28/02/12 12:16, Igor Novgorodov wrote:
>> On 28/02/12 06:54, Igor Novgorodov wrote:
>>> Then maybe we should move these calls to crypto_openssl.c into
>>> crypto_init_lib() function to make crypto.c
>>> library-independent? And why OpenSSL_add_all_
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 24/03/12 08:58, Alon Bar-Lev wrote:
> Signed-off-by: Alon Bar-Lev --- .gitignore
> |2 + build/msvc/msvc-generate/Makefile.am |2 +-
> build/msvc/msvc-generate/msvc-generate.vcproj | 74 ---
> build/msvc/msvc-generate/msvc-gener
Use the following constants:
- METRIC_NOT_USED
- TUN_ADAPTER_INDEX_INVALID
Signed-off-by: Alon Bar-Lev
---
src/openvpn/route.c | 30 +-
src/openvpn/tun.c | 46 +++---
src/openvpn/tun.h |2 ++
3 files changed, 42 inse
Use IPV4_NETMASK_HOST constant.
Signed-off-by: Alon Bar-Lev
---
src/openvpn/basic.h |2 ++
src/openvpn/mroute.c |2 +-
src/openvpn/pf.c |2 +-
src/openvpn/route.c | 12 ++--
src/openvpn/route.h |2 +-
src/openvpn/tun.c|2 +-
6 files changed, 12 insertions
Signed-off-by: Alon Bar-Lev
---
src/openvpn/route.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/openvpn/route.c b/src/openvpn/route.c
index a628e77..dda71c9 100644
--- a/src/openvpn/route.c
+++ b/src/openvpn/route.c
@@ -1530,7 +1530,7 @@ print_in6_addr_netbits_on
Remove the arithmetic magic in favor of constants or alternatives.
Alon Bar-Lev (4):
cleanup: avoid using ~0 - generic
cleanup: avoid using ~0 - ipv6
cleanup: avoid using ~0 - netmask
cleanup: avoid using ~0 - windows
config-msvc.h |1 +
configure.ac |2 +-
src/o
Use limits.h for maximum value.
Signed-off-by: Alon Bar-Lev
---
config-msvc.h |1 +
configure.ac |2 +-
src/openvpn/route.c |2 +-
src/openvpn/syshead.h |4
4 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/config-msvc.h b/config-msvc.h
index
On Thu, Mar 29, 2012 at 9:50 AM, Gert Doering wrote:
> Hi,
>
> On Wed, Mar 28, 2012 at 08:44:18PM +0200, Alon Bar-Lev wrote:
>> To avoid casting use two constants:
>> 1. IPV4_NETMASK_HOST
>
> Fine with that one.
>
>> 2. dwMINUS_ONE
>
> I think this is way over board. It should be possible to spel
Hi,
On Wed, Mar 28, 2012 at 08:44:18PM +0200, Alon Bar-Lev wrote:
> To avoid casting use two constants:
> 1. IPV4_NETMASK_HOST
Fine with that one.
> 2. dwMINUS_ONE
I think this is way over board. It should be possible to spell "-1" as
such - and it doesn't increase readability to introduce a M
2012/3/29 Samuli Seppänen :
> When he's ready to move on, the upgrade license costs around $500[1] -
> provided that he even wants/needs to build with Visual Studio at that point.
You do not need to pay anything, the Visual Studio 2010 express is for
free as much as I know.
Alon.
Hi,
This looks ok, provided we don't need Visual Studio for official
releases anymore (signing the installer, openvpn.exe and tap-driver).
The version I had to use for 2.3-alpha1 and earlier was VS2008. I doubt
James minds either, as he's still using his old Python build system.
When he's ready to
On 03/29/2012 12:00 AM, Samuli Seppänen wrote:
That said, the code itself is hosted externally on SF.net, so we have
the _option_ of using GitHub for that part. I'd first look at the big
picture of how we want to enhance our development processes and then
move on to the tools.
Although I'm not
22 matches
Mail list logo
