[Openvpn-devel] [PATCH] Avoid using ~0

To avoid casting use two constants: 1. IPV4_NETMASK_HOST 2. dwMINUS_ONE Signed-off-by: Alon Bar-Lev --- src/openvpn/basic.h |6 ++ src/openvpn/mroute.c |2 +- src/openvpn/pf.c |2 +- src/openvpn/route.c | 42 +- src/openvpn/route.h

Re: [Openvpn-devel] [PATCH] Avoid using ~0

On Wed, Mar 28, 2012 at 9:17 PM, Fabian Knittel wrote: > Hi Alon, > > I stumbled over a minor mistake: > > 2012/3/28 Alon Bar-Lev : >> diff --git a/src/openvpn/route.c b/src/openvpn/route.c >> index bf7af63..05ea57f 100644 >> --- a/src/openvpn/route.c >> +++ b/src/openvpn/route.c >> @@ -1367,7 +13

Re: [Openvpn-devel] [PATCH] Avoid using ~0

Hi Alon, I stumbled over a minor mistake: 2012/3/28 Alon Bar-Lev : > diff --git a/src/openvpn/route.c b/src/openvpn/route.c > index bf7af63..05ea57f 100644 > --- a/src/openvpn/route.c > +++ b/src/openvpn/route.c > @@ -1367,7 +1367,7 @@ add_route (struct route *r, >     else if ((flags & ROUTE_MET

[Openvpn-devel] [PATCH] Avoid using ~0

To avoid casting use two constants: 1. IPV4_NETMASK_HOST 2. dwMINUS_ONE Signed-off-by: Alon Bar-Lev --- src/openvpn/basic.h |6 ++ src/openvpn/mroute.c |2 +- src/openvpn/pf.c |2 +- src/openvpn/route.c | 44 ++-- src/openvpn/route.

[Openvpn-devel] [PATCH] Enable pedantic in windows compilation

Apparently -ansi undef WIN32 macro. Signed-off-by: Alon Bar-Lev --- configure.ac |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index d217343..ef34697 100644 --- a/configure.ac +++ b/configure.ac @@ -886,7 +886,8 @@ fi if test "${enable_p

Re: [Openvpn-devel] 2.3alpha1 fails on OS X when the --up argument contains more than an execution path

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 28/03/12 15:03, Jonathan K. Bullard wrote: > On Fri, Mar 23, 2012 at 10:18 AM, Gert Doering > wrote: > > Hi, > > > > Thank you, Gert, for your detailed comments on my first attempt at > this patch. > > The patch is

Re: [Openvpn-devel] [PATCH 4/6] build: msvc: upgrade to Visual Studio 2010 + fixups

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 28/03/12 17:07, Alon Bar-Lev wrote: > On Sat, Mar 24, 2012 at 9:58 AM, Alon Bar-Lev > wrote: >> >> Signed-off-by: Alon Bar-Lev --- .gitignore >> |2 + build/msvc/msvc-generate/Makefile.am |2 +- >> build/msvc/msvc-generate/msvc-g

Re: [Openvpn-devel] 2.3alpha1 fails on OS X when the --up argument contains more than an execution path

Hi, On Wed, Mar 28, 2012 at 09:03:44AM -0400, Jonathan K. Bullard wrote: > I've looked into this a bit more, and have found that where the options are > actually used, argv_printf() is called to parse the command line into an > argv structure. argv_printf uses parse_line() to do the actual parsing

Re: [Openvpn-devel] [PATCH 6/6] cleanup: ~0 is too large for 32bit ipv4 address

Hi, On Wed, Mar 28, 2012 at 11:03:43AM +0200, Alon Bar-Lev wrote: > 0x as-is is valid ipv4 address/netmask... > > I found only this warning, if there are more places, I guess these > needs to be fixed as well. So if you agree to the above, I will find > the other places. I'd opt for havi

Re: [Openvpn-devel] 2.3alpha1 fails on OS X when the --up argument contains more than an execution path

On Wed, Mar 28, 2012 at 9:57 AM, Fabian Knittel wrote: gc_arena instances are used by explicitly passing a pointer to it. So, > unless one of the functions takes an instance of gc_arena as a > parameter, you don't need to prepare one. As many functions in OpenVPN > take one, there's some dead code

Re: [Openvpn-devel] [PATCH 4/6] build: msvc: upgrade to Visual Studio 2010 + fixups

On Sat, Mar 24, 2012 at 9:58 AM, Alon Bar-Lev wrote: > > Signed-off-by: Alon Bar-Lev > --- >  .gitignore                                     |    2 + >  build/msvc/msvc-generate/Makefile.am           |    2 +- >  build/msvc/msvc-generate/msvc-generate.vcproj  |   74 --- >  build/msvc/msvc-generat

Re: [Openvpn-devel] 2.3alpha1 fails on OS X when the --up argument contains more than an execution path

Hi Jonathan, 2012/3/28 Jonathan K. Bullard : > There is one part of check_cmd_access() which I took from code in > run_up_down() and I am not sure about -- the three lines: >   gc_arena gc; > and >   gc = gc_new (); > and >   gc_free (&gc); > > Are they needed? I put them in because I assume that

Re: [Openvpn-devel] 2.3alpha1 fails on OS X when the --up argument contains more than an execution path

On Fri, Mar 23, 2012 at 10:18 AM, Gert Doering wrote: > Hi, Thank you, Gert, for your detailed comments on my first attempt at this patch. The patch is meant to fix problems in the new-in-2.3 checking of options before trying to create the connection. Options that accept a command parameter i

Re: [Openvpn-devel] [PATCH] build: automake fixups

On Wed, Mar 28, 2012 at 1:59 PM, Alon Bar-Lev wrote: > 1. Rename resource includes to rch, see[1]. > 2. Use implicit rule for resources. > 3. Fixup resources build using automake conventions. > 4. Misc cleanups > > [1] http://comments.gmane.org/gmane.comp.gnu.binutils/56459 > > Signed-off-by: Alon

Re: [Openvpn-devel] [openvpn-gui 0/8] build rewrite

On Wed, Mar 28, 2012 at 1:13 PM, Heiko Hund wrote: > Hi Alon. Hello, >>   build: rework build > > Removed use of libtool and the implicit automake rule for .rc files. Instead > add a manual rule for the resource object to Makefile.am. Not sure why you guys have issues with libtool. There are pe

Re: [Openvpn-devel] [openvpn-gui 0/8] build rewrite

Hi Alon. Thanks for the contributions. I just pushed the changes, some of them modified. See below for comments. > Alon Bar-Lev (8): > cleanup: resolve unused parameter warnings Changed this to use gcc attributes like in other places. > cleanup: dos2unix res/openvpn-gui-res-fi.rc > clean

Re: [Openvpn-devel] [DISCUSS] OpenVPN public repositories at github.com

2012/3/28 Samuli Seppänen : >> A basic ticketing system is also provided, not sure it is that far >> from trac features... not a must. >> It wiki is better than track as people can subscribe for changes, >> hence cooperate much better than current state. > A few years ago, when I started setting up

Re: [Openvpn-devel] [DISCUSS] OpenVPN public repositories at github.com

> A basic ticketing system is also provided, not sure it is that far > from trac features... not a must. > It wiki is better than track as people can subscribe for changes, > hence cooperate much better than current state. A few years ago, when I started setting up the community services I discusse

Re: [Openvpn-devel] [PATCH] build: rename bool->obool

On Wed, Mar 28, 2012 at 11:45 AM, David Sommerseth wrote: > The reason for that review is that I'm not convinced adding our own > boolean type is the way to go.  I'd much rather see us using stdbool.h > and keep using the bool for pure boolean purposes.  Where flags needs to > be used, it makes mu

Re: [Openvpn-devel] [PATCH] build: rename bool->obool

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 28/03/12 11:32, Alon Bar-Lev wrote: > On Sat, Mar 24, 2012 at 9:21 PM, Alon Bar-Lev > wrote: >> On Sat, Mar 24, 2012 at 9:15 PM, Alon Bar-Lev >> wrote: >>> PPC architectures and conflict with stdbool.h. >>> >>> basic.h defines a type 'bool' that

Re: [Openvpn-devel] [PATCH] build: rename bool->obool

On Sat, Mar 24, 2012 at 9:21 PM, Alon Bar-Lev wrote: > On Sat, Mar 24, 2012 at 9:15 PM, Alon Bar-Lev wrote: >> PPC architectures and conflict with stdbool.h. >> >> basic.h defines a type 'bool' that conflicts with the altivec >> keyword bool which has to be fixed upstream, see bugs[1][2]. >> >> [

Re: [Openvpn-devel] [DISCUSS] much more complicated gcc invocations now

On Wed, Mar 28, 2012 at 11:22 AM, Jan Just Keijser wrote: > ah OK, I normally don't care about dependencies because I build openvpn only > once. why did automake decide to add these rules , whilst it didn't do so in > the past? Yes, it should had. > and no, apart from the above I don't have a sp

Re: [Openvpn-devel] [DISCUSS] much more complicated gcc invocations now

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 28/03/12 11:12, Jan Just Keijser wrote: > Hi, > > Gert Doering wrote: >> Hi, >> >> On Mon, Mar 26, 2012 at 07:51:01PM +0200, Alon Bar-Lev wrote: >> >>> The benefit is to divide the code into libraries and core which >>> is easier to maintain and

Re: [Openvpn-devel] [DISCUSS] much more complicated gcc invocations now

Alon Bar-Lev wrote: On Wed, Mar 28, 2012 at 11:12 AM, Jan Just Keijser wrote: Hi, Gert Doering wrote: Hi, On Mon, Mar 26, 2012 at 07:51:01PM +0200, Alon Bar-Lev wrote: The benefit is to divide the code into libraries and core which is easier to maintain and reuse. I'm not sure I unde

Re: [Openvpn-devel] [DISCUSS] much more complicated gcc invocations now

On Wed, Mar 28, 2012 at 11:12 AM, Jan Just Keijser wrote: > Hi, > > > Gert Doering wrote: > > Hi, > > On Mon, Mar 26, 2012 at 07:51:01PM +0200, Alon Bar-Lev wrote: > > > The benefit is to divide the code into libraries and core which is > easier to maintain and reuse. > > > I'm not sure I understa

Re: [Openvpn-devel] [DISCUSS] much more complicated gcc invocations now

Hi, Gert Doering wrote: Hi, On Mon, Mar 26, 2012 at 07:51:01PM +0200, Alon Bar-Lev wrote: The benefit is to divide the code into libraries and core which is easier to maintain and reuse. I'm not sure I understand what's so hard about "compile stuff, use 'ar' to pack into libopenvpn.a

Re: [Openvpn-devel] Log level of management interface: patch from 2009

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 22/02/12 20:03, Michael Kress wrote: > Hello, > > in May 2009 James committed in > 423037e9fbdff7209ca6f305b812a9908a0f4d13 > > "Reduce the debug level (--verb) at which received management > interface commands are echoed from 7 to 3." > > A se

Re: [Openvpn-devel] [PATCH 3/6] cleanup: warnings at src/openvpn/httpdigest.c

On Wed, Mar 28, 2012 at 10:45 AM, David Sommerseth wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 26/03/12 23:26, Alon Bar-Lev wrote: >> Signed-off-by: Alon Bar-Lev --- >> src/openvpn/httpdigest.c |   44 >> ++-- 1 files changed, 22 >> inser

Re: [Openvpn-devel] [PATCH 6/6] cleanup: ~0 is too large for 32bit ipv4 address

now to the list... On Wed, Mar 28, 2012 at 10:40 AM, David Sommerseth wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 26/03/12 23:26, Alon Bar-Lev wrote: >> Signed-off-by: Alon Bar-Lev --- >> src/openvpn/route.c |    2 +- 1 files changed, 1 insertions(+), 1 >> deletions(-) >> >>

Re: [Openvpn-devel] [PATCH 2/6] build: tap: search for tap header

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 26/03/12 23:26, Alon Bar-Lev wrote: > Windows and solaris has something in common, in both the tap header is > external. So make the Windows tap-windows.h search common to all > platform. > > Display an error if we cannot find tap header. > > Sign

Re: [Openvpn-devel] [PATCH 1/6] build: openbsd: detect netinet/ip.h correctly

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 26/03/12 23:26, Alon Bar-Lev wrote: > Signed-off-by: Alon Bar-Lev --- configure.ac | > 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) > Applied to master branches on -testing and -stable trees. commit 2a7448912efbba7a246f481566117d6b8f63

Re: [Openvpn-devel] [PATCH 3/6] cleanup: warnings at src/openvpn/httpdigest.c

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 26/03/12 23:26, Alon Bar-Lev wrote: > Signed-off-by: Alon Bar-Lev --- > src/openvpn/httpdigest.c | 44 > ++-- 1 files changed, 22 > insertions(+), 22 deletions(-) > > diff --git a/src/openvpn/httpdigest.c

Re: [Openvpn-devel] [PATCH 6/6] cleanup: ~0 is too large for 32bit ipv4 address

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 26/03/12 23:26, Alon Bar-Lev wrote: > Signed-off-by: Alon Bar-Lev --- > src/openvpn/route.c |2 +- 1 files changed, 1 insertions(+), 1 > deletions(-) > > diff --git a/src/openvpn/route.c b/src/openvpn/route.c index > bf7af63..608403b 100644 --