Re: [Openvpn-devel] [PATCH] Add option to disable priority tagged packets (VID=0)

Hi Alon, Am 08.12.2011 21:17, schrieb Alon Bar-Lev: > I fail to understand why this is relevant as far as usage (openvpn --help) and > manual (man openvpn) to document this. Ah. Sorry for the misunderstanding. Are you referring to the specific patch by Michael? I agree that it would have neede

[Openvpn-devel] [PATCH v2] Move away from openvpn_basename() over to platform provided basename()

This kicks out the openvpn_basename() function from misc.[ch] andputs it into compat.[ch]. This is to provide the same functionality on platforms not having a native basename() function available. In addition this patch adds dirname() which commit 0f2bc0dd92f43c91e depends. Without dirname(), op

[Openvpn-devel] [PATCH] Enable access() when building in Visual Studio

Visual Studio does not enable certiain standard Unix functions, such as access(). By defining _CRT_NONSTDC_NO_WARNINGS and _CRT_SECURE_NO_WARNINGS, these functions are enabled. This patch also adds a ./configure check for access() as well, in case this needs to be implemented on other platforms l

Re: [Openvpn-devel] [PATCH v3] Move away from openvpn_basename() over to platform provided basename()

On Thu, Dec 8, 2011 at 5:24 PM, David Sommerseth wrote: > This kicks out the openvpn_basename() function from misc.[ch] and puts > glibc equivalents into compat.[ch].  This is to provide the same > functionality on platforms not having a native basename() function > available. > > In addition this

Re: [Openvpn-devel] [PATCH] Add option to disable priority tagged packets (VID=0)

On Thu, Dec 8, 2011 at 7:02 PM, Fabian Knittel wrote: > Am 08.12.2011 11:27, schrieb Alon Bar-Lev: >> Missing usage, man. > > There are probably not *that* many users, agreed.  It's probably more of > a "large enterprise" feature, as only people with VLAN tagged networks > would be interested.  Fo

Re: [Openvpn-devel] [PATCH] Add option to disable priority tagged packets (VID=0)

Hi Michael, Hi David, Hi Alon, On 08/12/11 09:33, michael-dev wrote: > This patch adds an option to disable the creation of tagged priority > packets with VID=0. This is for the feature_vlan_tagging > openvpn-testing head. Great to know that other people are using the patch-set too. Your patch i

[Openvpn-devel] Topics for today's meeting

Hi, We're having an IRC meeting today, starting at 18:00 UTC on #openvpn-de...@irc.freenode.net. Current topic list is here: If you have any other things you'd like to bring up, respond to this mail, send me mail privately or add the

[Openvpn-devel] [PATCH v3] Move away from openvpn_basename() over to platform provided basename()

This kicks out the openvpn_basename() function from misc.[ch] and puts glibc equivalents into compat.[ch]. This is to provide the same functionality on platforms not having a native basename() function available. In addition this patch adds dirname() which commit 0f2bc0dd92f43c91e depends. Witho

Re: [Openvpn-devel] [PATCH v2] Move away from openvpn_basename() over to platform provided basename()

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/12/11 14:01, David Sommerseth wrote: > This kicks out the openvpn_basename() function from misc.[ch] andputs > it into compat.[ch]. This is to provide the same functionality on > platforms not having a native basename() function available. >

Re: [Openvpn-devel] [PATCH] Enable access() when building in Visual Studio

Hi, On Thu, Dec 08, 2011 at 02:03:27PM +0100, David Sommerseth wrote: > Visual Studio does not enable certiain standard Unix functions, > such as access(). By defining _CRT_NONSTDC_NO_WARNINGS and > _CRT_SECURE_NO_WARNINGS, these functions are enabled. > > This patch also adds a ./configure chec

Re: [Openvpn-devel] [PATCH] Move away from openvpn_basename() over to platform provided basename()

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Please ignore! Troubles with SMTP relay, and I managed to resend the wrong patch to the wrong thread. Sorry! David S. On 08/12/11 14:01, David Sommerseth wrote: > This kicks out the openvpn_basename() function from misc.[ch] andputs > it into com

[Openvpn-devel] [PATCH] Enable access() when building in Visual Studio

Visual Studio does not enable certiain standard Unix functions, such as access(). By defining _CRT_NONSTDC_NO_WARNINGS and _CRT_SECURE_NO_WARNINGS, these functions are enabled. This patch also adds a ./configure check for access() as well, in case this needs to be implemented on other platforms l

[Openvpn-devel] [PATCH] Move away from openvpn_basename() over to platform provided basename()

This kicks out the openvpn_basename() function from misc.[ch] andputs it into compat.[ch]. This is to provide the same functionality on platforms not having a native basename() function available. In addition this patch adds dirname() which commit 0f2bc0dd92f43c91e depends. Without dirname(), op

[Openvpn-devel] [PATCH v2] Move away from openvpn_basename() over to platform provided basename()

This kicks out the openvpn_basename() function from misc.[ch] andputs it into compat.[ch]. This is to provide the same functionality on platforms not having a native basename() function available. In addition this patch adds dirname() which commit 0f2bc0dd92f43c91e depends. Without dirname(), op

Re: [Openvpn-devel] [PATCH] Enable access() when building in Visual Studio

Well, this is small and beautiful! :) On Thu, Dec 8, 2011 at 1:38 PM, David Sommerseth wrote: > Visual Studio does not enable certiain standard Unix functions, > such as access().  By defining _CRT_NONSTDC_NO_WARNINGS and > _CRT_SECURE_NO_WARNINGS, these functions are enabled. > > This patch also

Re: [Openvpn-devel] [PATCH] handle Windows unicode paths

On Thu, Dec 8, 2011 at 1:06 PM, Heiko Hund wrote: > On Wednesday 07 December 2011 17:58:51 Heiko Hund wrote: >> This patch makes openvpn read the command line in UCS-2 and convert >> it to UTF-8 internally. Windows stores names in the filesystem in UCS-2. >> When using a paths openvpn converts it

Re: [Openvpn-devel] [PATCH] Add a wrapper for access() when compiling via Visual Studio

On Thursday 08 December 2011 00:13:49 David Sommerseth wrote: > This adds the access() function as a wrapper for _access() to be > able to compile OpenVPN via Visual Studio. It also adds the required > macros which used in POSIX environments (R_OK, W_OK, X_OK, F_OK). Depending on the order this a

Re: [Openvpn-devel] [PATCH] handle Windows unicode paths

On Wednesday 07 December 2011 17:58:51 Heiko Hund wrote: > This patch makes openvpn read the command line in UCS-2 and convert > it to UTF-8 internally. Windows stores names in the filesystem in UCS-2. > When using a paths openvpn converts it from UTF-8 to UCS-2 and uses the > wide character Window

Re: [Openvpn-devel] [PATCH] Add a wrapper for access() when compiling via Visual Studio

On Thu, Dec 8, 2011 at 12:57 PM, Alon Bar-Lev wrote: > On Thu, Dec 8, 2011 at 12:51 PM, Alon Bar-Lev wrote: >> On Thu, Dec 8, 2011 at 12:44 PM, David Sommerseth >> wrote: >>> -BEGIN PGP SIGNED MESSAGE- >>> Hash: SHA1 >>> >>> On 08/12/11 08:44, Alon Bar-Lev wrote: On Thu, Dec 8, 2011

Re: [Openvpn-devel] [PATCH] Add a wrapper for access() when compiling via Visual Studio

On Thu, Dec 8, 2011 at 12:51 PM, Alon Bar-Lev wrote: > On Thu, Dec 8, 2011 at 12:44 PM, David Sommerseth > wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 08/12/11 08:44, Alon Bar-Lev wrote: >>> On Thu, Dec 8, 2011 at 2:13 AM, David Sommerseth >>> wrote: +/* The POSIX ac

Re: [Openvpn-devel] [PATCH] Add a wrapper for access() when compiling via Visual Studio

On Thu, Dec 8, 2011 at 12:44 PM, David Sommerseth wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 08/12/11 08:44, Alon Bar-Lev wrote: >> On Thu, Dec 8, 2011 at 2:13 AM, David Sommerseth >> wrote: >>> +/* The POSIX access() function is called via _access() on Windows, >>> + * defin

Re: [Openvpn-devel] [PATCH] Add a wrapper for access() when compiling via Visual Studio

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/12/11 08:44, Alon Bar-Lev wrote: > On Thu, Dec 8, 2011 at 2:13 AM, David Sommerseth > wrote: >> +/* The POSIX access() function is called via _access() on Windows, >> + * defined in io.h + */ +#define HAVE_ACCESS 1 +#define access >> _access +#

Re: [Openvpn-devel] [PATCH] Move away from openvpn_basename() over to platform provided basename()

On Thu, Dec 8, 2011 at 12:27 PM, David Sommerseth wrote: > Hi Alon, > > I'm not sure I understand the critique too well now.  As this is the > approach I tried to do.  However, I put the basename() and dirname() > implementations in compat.h, calling the combined openvpn_dirbasename() > function.

Re: [Openvpn-devel] [PATCH] Add option to disable priority tagged packets (VID=0)

Missing usage, man. On Thu, Dec 8, 2011 at 12:15 PM, David Sommerseth wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > Adding Fabian to Cc, he knows more about the VLAN code. > > With this feedback, I'm willing merge in the feat_vlan_tagging branch > into master.  I'm not sure if th

Re: [Openvpn-devel] [PATCH] Move away from openvpn_basename() over to platform provided basename()

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/12/11 08:42, Alon Bar-Lev wrote: > On Thu, Dec 8, 2011 at 1:46 AM, David Sommerseth > wrote: >> >> This kicks out the openvpn_basename() function from misc.[ch] >> andputs it into compat.[ch]. This is to provide the same >> functionality on pl

Re: [Openvpn-devel] [PATCH] Move away from openvpn_basename() over to platform provided basename()

Hi, On Thu, Dec 08, 2011 at 12:46:28AM +0100, David Sommerseth wrote: > This kicks out the openvpn_basename() function from misc.[ch] andputs > it into compat.[ch]. This is to provide the same functionality on > platforms not having a native basename() function available. Agree with this in prin

Re: [Openvpn-devel] [PATCH] Add option to disable priority tagged packets (VID=0)

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Adding Fabian to Cc, he knows more about the VLAN code. With this feedback, I'm willing merge in the feat_vlan_tagging branch into master. I'm not sure if this should happen now in the v2.3 time frame (which is getting more and more ready for alpha/

[Openvpn-devel] [PATCH] Add option to disable priority tagged packets (VID=0)

This patch adds an option to disable the creation of tagged priority packets with VID=0. This is for the feature_vlan_tagging openvpn-testing head. I tested the vlan feature and it works fine for me (no dhcp tested). Therefore I bridged my eth0 (LAN) and tap0 (OpenVPN) but as my switch flags arp

Re: [Openvpn-devel] [PATCH] Add a wrapper for access() when compiling via Visual Studio

On Thu, Dec 8, 2011 at 2:13 AM, David Sommerseth wrote: > +/* The POSIX access() function is called via _access() on Windows, > + * defined in io.h > + */ > +#define HAVE_ACCESS 1 > +#define access _access > +#pragma warning(disable : 4996) /* Avoid Visual Studio to complain about > access(), whi

Re: [Openvpn-devel] [PATCH] Move away from openvpn_basename() over to platform provided basename()

On Thu, Dec 8, 2011 at 1:46 AM, David Sommerseth wrote: > > This kicks out the openvpn_basename() function from misc.[ch] andputs > it into compat.[ch].  This is to provide the same functionality on > platforms not having a native basename() function available. > > In addition this patch adds dirn

[Openvpn-devel] suggested config settings for wifi?

See attach. I'm wondering, with the default settings (used via Ubuntu's network-manager, though that isn't really relevant I think), why I keep getting timeouts. I can ping the box. It seems to work 1 out of every 5 times, so it's not a packet filter blocking me. Is there any setting I can set?

Re: [Openvpn-devel] [PATCH] Don't look for 'stdin' file when using --auth-user-pass

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/12/11 16:34, David Sommerseth wrote: > This argument allows the keyword 'stdin' to indicate that the input is > to be read from the stdin. Don't check for file existence if the file > name is set to 'stdin' > > Signed-off-by: David Sommerseth

[Openvpn-devel] [PATCH] Add a wrapper for access() when compiling via Visual Studio

This adds the access() function as a wrapper for _access() to be able to compile OpenVPN via Visual Studio. It also adds the required macros which used in POSIX environments (R_OK, W_OK, X_OK, F_OK). This patch will also disable a compiler warning, C4996, as the compiler complains about the usage