Re: [Openvpn-devel] [PATCH] remove function is_proto_tcp()

2011-08-18 Thread Gert Doering
Hi, On Thu, Aug 18, 2011 at 10:16:21AM +, Heiko Hund wrote: > The implementation of is_proto_tcp() was invalid since the IPv6 stuff got > merged into master. There's proto_is_tcp() that does the same job right. > > Remove is_proto_tcp() and make its only caller use proto_is_tcp() instead. AC

Re: [Openvpn-devel] [PATCH] Make easy-rsa/2.0/vars handle paths with whitespaces

2011-08-18 Thread Tanel Rebane
As I've understood, the second approach is safer, but the first one is more portable. Then again, don't hold me to it as I have no sources available (other than myself) confirming that. I also noticed that easy-rsa/2.0/build-dh has issues with whitespaces. This can easily be fixed with some double

[Openvpn-devel] [PATCH] add .gitignore to official repository

2011-08-18 Thread Heiko Hund
This .gitignore make the output of git status a lot more readable. It was made from the dynamically generated files that showed after using both build system. Signed-off-by: Samuli Seppänen Signed-off-by: Heiko Hund --- .gitignore | 40 1 files changed

[Openvpn-devel] [PATCH] fix warnings in event.c when building for win32-64

2011-08-18 Thread Heiko Hund
When compiling for 64-bit Windows gcc warns about "cast from pointer to integer of different size" on two occasions in file event.c, due to invalid casting. This patch removes the type casts and uses the correct format specifier instead. Signed-off-by: Heiko Hund --- event.c |8

[Openvpn-devel] [PATCH] remove function is_proto_tcp()

2011-08-18 Thread Heiko Hund
The implementation of is_proto_tcp() was invalid since the IPv6 stuff got merged into master. There's proto_is_tcp() that does the same job right. Remove is_proto_tcp() and make its only caller use proto_is_tcp() instead. Signed-off-by: Heiko Hund --- options.c |2 +- socket.h |6 -

[Openvpn-devel] Topics for today's meeting

2011-08-18 Thread Samuli Seppänen
Hi, We're having an IRC meeting today, starting at 18:00 UTC on #openvpn-de...@irc.freenode.net. Current topic list is here: If you have any other things you'd like to bring up, respond to this mail, send me mail privately or add the

[Openvpn-devel] [PATCH] Added whitespace handling for $KEY_CONFIG variable in easy-rsa/2.0/vars

2011-08-18 Thread samuli
From: Samuli Seppänen Original $KEY_CONFIG variable generation in broke if $EASY_RSA had whitespace in it. This patch fixes the issue in a POSIX-compliant way. Signed-off-by: Tanel Rebane Signed-off-by: Samuli Seppänen Tested-by: Samuli Seppänen --- easy-rsa/2.0/vars |2 +- 1 files chang