[Openvpn-devel] Topics for tomorrow's meeting

2011-01-05 Thread Samuli Seppänen
Hi, We're having an IRC meeting tomorrow, starting at 18:00 UTC on #openvpn-de...@irc.freenode.net. Current topic list is here: If you have any other things you'd like to bring up, respond to this mail, send me mail privately or add

Re: [Openvpn-devel] [PATCH] Changed snprintf to _snprintf in service-win32/openvpnserv.c

2011-01-05 Thread Samuli Seppänen
David Sommerseth ha scritto: > On 05/01/11 14:21, Samuli Seppänen wrote: > > This fixes a generic Windows/VC++ issue: > > > > > > > Does this change affect the automake/gcc-based Windows build

Re: [Openvpn-devel] [PATCH] Changed snprintf to _snprintf in service-win32/openvpnserv.c

2011-01-05 Thread Peter Stuge
Samuli Seppänen wrote: > +++ b/service-win32/openvpnserv.c > @@ -86,7 +86,7 @@ static HANDLE exit_event = NULL; > /* snprintf with guaranteed null termination */ > #define mysnprintf(out, ...) \ > { \ > - snprintf (out, sizeof(out), __VA_ARGS__); \ > + _snprintf (out,

Re: [Openvpn-devel] [PATCH] Changed snprintf to _snprintf in service-win32/openvpnserv.c

2011-01-05 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/01/11 14:21, Samuli Seppänen wrote: > This fixes a generic Windows/VC++ issue: > > > > Does this change affect the automake/gcc-based Win

[Openvpn-devel] [PATCH] Made Python-based build system copy openvpnserv.exe* to dist/bin directory

2011-01-05 Thread Samuli Seppänen
-- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock From a19a54f3942056b0c13191e7b25ab9a8cc9361dd Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Samuli=20Sepp=C3=A4nen?= Date: Wed, 5 Jan 2011 15:13:29 +0200 Subject: [PATCH] Made Python-based build system copy ope

[Openvpn-devel] [PATCH] Changed snprintf to _snprintf in service-win32/openvpnserv.c

2011-01-05 Thread Samuli Seppänen
This fixes a generic Windows/VC++ issue: Does this change affect the automake/gcc-based Windows builds? -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: ma

Re: [Openvpn-devel] [PATCH 5/6] Added openvpnserv-specific files to clean target in win/msvc.mak.in

2011-01-05 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/01/11 11:00, Samuli Seppänen wrote: > This patch depends on patch 2/6. Patch 6/6 depends on this patch. Maybe > integrating them into one would have made more sense? :) > Patch 5/6 and Patch 6/6 could be merged. Patch 2/6 is doing more changes

Re: [Openvpn-devel] [PATCH 4/6] Added build flag printing to win/show.py

2011-01-05 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/01/11 10:57, Samuli Seppänen wrote: > FYI: show.py is only used interactively to visualize current build > configuration ACK. Kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuP

Re: [Openvpn-devel] [PATCH 3/6] Added PKCS11_HELPER_DIR directive to win/settings.in

2011-01-05 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/01/11 10:56, Samuli Seppänen wrote: > > ACK! (For the future, some of the comments you placed in the code would fit well into a commit log comment as well) kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.1

Re: [Openvpn-devel] [PATCH 1/6] Added automated configure.h creation to Python-based build system.

2011-01-05 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/01/11 10:53, Samuli Seppänen wrote: > Hi all, > > Here's the first of a set of six patches that fix various issues with > the Python-based build system. Also, some clarifying comments have been > added to the existing code. After this patchset i

[Openvpn-devel] [PATCH 6/6] Added copying of files from service-win32 directory to build root directory.

2011-01-05 Thread Samuli Seppänen
This looks like a hack (and it is), so here's the underlying logic: - service-win32/service.h (or .c?) refers to non-existing header files when using the Python-based build system, but changing the header file name would break(?) the older automake-based Windows buildsystem. By making a copy of t

[Openvpn-devel] [PATCH 5/6] Added openvpnserv-specific files to clean target in win/msvc.mak.in

2011-01-05 Thread Samuli Seppänen
This patch depends on patch 2/6. Patch 6/6 depends on this patch. Maybe integrating them into one would have made more sense? :) -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock From 3ce5ba5fb8d9a1627e25b01ad6f6d61a29b6084f Mon Sep 17 00:00:00 2001 From:

[Openvpn-devel] [PATCH 4/6] Added build flag printing to win/show.py

2011-01-05 Thread Samuli Seppänen
FYI: show.py is only used interactively to visualize current build configuration -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock From 9f66921758c672aed89e828c8c67162ee5399003 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Samuli=20Sepp=C3=A4nen?= Date: Mon, 3

[Openvpn-devel] [PATCH 3/6] Added PKCS11_HELPER_DIR directive to win/settings.in

2011-01-05 Thread Samuli Seppänen
-- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock >From e46bee78a2d5bbdfc140bccad37c37344a32e604 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Samuli=20Sepp=C3=A4nen?= List-Post: openvpn-devel@lists.sourceforge.net Date: Mon, 3 Jan 2011 16:08:37 +0200 Subject:

[Openvpn-devel] [PATCH 2/6] Added openvpnserv.exe building to win/msvc.mak.in

2011-01-05 Thread Samuli Seppänen
-- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock From c5d50576b9be6175132da67a57306bf41611f791 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Samuli=20Sepp=C3=A4nen?= Date: Mon, 3 Jan 2011 16:07:28 +0200 Subject: [PATCH 2/6] Added openvpnserv.exe building to w

[Openvpn-devel] [PATCH 1/6] Added automated configure.h creation to Python-based build system.

2011-01-05 Thread Samuli Seppänen
Hi all, Here's the first of a set of six patches that fix various issues with the Python-based build system. Also, some clarifying comments have been added to the existing code. After this patchset is merged it's possible to build openvpnserv.exe in addition to openvpn.exe and the TAP drivers. NSI