Re: [Openvpn-devel] [PATCH] Re: Handling of subnets grammar in Packet filter file

2010-06-03 Thread Gert Doering
Hi, On Thu, Jun 03, 2010 at 12:47:47PM -0500, Eric F Crist wrote: > > I upated the patch and it will now display something like: > > WARNING: PF: /dev/shm/openvpn_pf_ff18e7030fd03ce91bd0432563e4eb1a.tmp/5: > > incorrect subnet 192.168.100.8/28 changed to 192.168.100.0/28 > > This seems rather pe

Re: [Openvpn-devel] [PATCH] Re: Handling of subnets grammar in Packet filter file

2010-06-03 Thread Eric F Crist
On Jun 3, 2010, at 12:38:19, chantra wrote: > Gert Doering greenie.muc.de> writes: > > >> Both have merits, your fix is somewhat less code then adding an extra input >> validation check >> >> if ((network.s_addr & netmask) != network.s_addr ) >>{ complain; } >> >> - so: ACK from me. >

Re: [Openvpn-devel] [PATCH] Re: Handling of subnets grammar in Packet filter file

2010-06-03 Thread chantra
Gert Doering greenie.muc.de> writes: > Both have merits, your fix is somewhat less code then adding an extra input > validation check > > if ((network.s_addr & netmask) != network.s_addr ) > { complain; } > > - so: ACK from me. > > (Since OpenVPN likes to print warnings, we *could* a

Re: [Openvpn-devel] [PATCH] Re: Handling of subnets grammar in Packet filter file

2010-06-03 Thread Gert Doering
Hi, On Thu, Jun 03, 2010 at 04:48:35PM +0200, chantra wrote: > Please find below a patch to correct the behaviour. > > I have also opened a trac ticket : > https://community.openvpn.net/openvpn/ticket/14 The patch itself looks good. It's a bit of a philosophical issue what to do with network sp

[Openvpn-devel] [PATCH] Re: Handling of subnets grammar in Packet filter file

2010-06-03 Thread chantra
Please find below a patch to correct the behaviour. I have also opened a trac ticket : https://community.openvpn.net/openvpn/ticket/14 chantra http://www.debuntu.org > > Hi all, > > It seems that openvpn is not handling properly non-standard subnets in > pf_file. > This issue happened o

Re: [Openvpn-devel] Topics for today's meeting

2010-06-03 Thread reg9009
Am 03.06.2010 14:06, schrieb Samuli Seppänen: Hi, Here are some topics for today's meeting (18:00 UTC, #openvpn-de...@irc.freenode.net). If you have any other things you'd like to bring up, add them to the list or send them to me.

[Openvpn-devel] Topics for today's meeting

2010-06-03 Thread Samuli Seppänen
Hi, Here are some topics for today's meeting (18:00 UTC, #openvpn-de...@irc.freenode.net). If you have any other things you'd like to bring up, add them to the list or send them to me. -- Samuli Seppänen Community Manager OpenVPN T