Re: [Openvpn-devel] [PATCH] Fix for "Cannot read current default gateway" problem on Linux

2009-01-29 Thread David Balazic
Alon Bar-Lev wrote: > Some minor comments. > 1. Please rebase against trunk. Done. > > - gateway); > > + netmask); > > + if (r->gateway) > > +argv_printf_cat (&argv, "gw %s", gateway); > > + else > > +argv_printf_cat (&argv, "dev %s", r->gateway_ifname);

Re: [Openvpn-devel] [PATCH] Fix for "Cannot read current default gateway" problem on Linux

2009-01-29 Thread Alon Bar-Lev
Some minor comments. 1. Please rebase against trunk. On 1/29/09, David Balazic wrote: > diff -u -r openvpn-2.1_rc15/route.c openvpn-2.1_rc15_gwfix/route.c > --- openvpn-2.1_rc15/route.c2008-11-17 00:48:04.0 + > +++ openvpn-2.1_rc15_gwfix/route.c 2008-12-18 19:59:36.4553941

[Openvpn-devel] [PATCH] Fix for "Cannot read current default gateway" problem on Linux

2009-01-29 Thread David Balazic
Hi! I'm resending this patch. Originally I sent it here [1]. In short: In the diff (agains 2.1_rc15) is the solution for the old* problem of (not) detecting default gateway on linux systems if it is a device route. It was tested by one affected user (Antonis Tsolomitis, see the thread "openvpn a

Re: [Openvpn-devel] OVPN patching process RE: [PATCH] Fix non-C89 comments

2009-01-29 Thread Alon Bar-Lev
On 1/29/09, David Balazic wrote: > Hi! > > I sent a patch recently to the openvpn-devel list and got > no reply whatsoever. Did I miss something ? Is there a procedure > that I did not follow ? Send the patch again. At the subject specify [PATCH] Place the patch inline, be sure your mail clien

Re: [Openvpn-devel] OVPN patching process RE: [PATCH] Fix non-C89 comments

2009-01-29 Thread Thomas NOEL
David Sommerseth a écrit : > From what I've heard from other sources as well, this is usually the > normal procedure ... pop the patch to this mailing list and watch > if something happens ... or not you might get a response, and you > might not. Who knows ... It is a good summary of t

Re: [Openvpn-devel] OVPN patching process RE: [PATCH] Fix non-C89 comments

2009-01-29 Thread David Sommerseth
David Balazic wrote: Hi! I sent a patch recently to the openvpn-devel list and got no reply whatsoever. Did I miss something ? Is there a procedure that I did not follow ? From what I've heard from other sources as well, this is usually the normal procedure ... pop the patch to this mailing

[Openvpn-devel] OVPN patching process RE: [PATCH] Fix non-C89 comments

2009-01-29 Thread David Balazic
Hi! I sent a patch recently to the openvpn-devel list and got no reply whatsoever. Did I miss something ? Is there a procedure that I did not follow ? That patch is to fix a longstanding bug that users encountered. Regards, David PS: the mail message in question is : Fix for "Cannot read curren