Re: [OpenStack-Infra] Remove placeholder hiera defaults commits

2015-10-27 Thread Paul Belanger
On Tue, Oct 27, 2015 at 06:35:38PM -0700, Spencer Krum wrote: > I'd like to see us make an example hiera common.yaml file for input to > openstackci, but not for system-config. I worry if we don't get testing > inside it, then it will bitrot almost instantly. Cannot speak to bitrot, as I think if

Re: [OpenStack-Infra] Remove placeholder hiera defaults commits

2015-10-27 Thread Spencer Krum
I'd like to see us make an example hiera common.yaml file for input to openstackci, but not for system-config. I worry if we don't get testing inside it, then it will bitrot almost instantly. On Tue, Oct 27, 2015 at 6:30 PM, Paul Belanger wrote: > On Tue, Oct 27, 2015 at 05:47:27PM -0700, Spence

Re: [OpenStack-Infra] Remove placeholder hiera defaults commits

2015-10-27 Thread Paul Belanger
On Tue, Oct 27, 2015 at 05:47:27PM -0700, Spencer Krum wrote: > Paul, > > The hiera defaults were there to allow the apply test to work. Since > Jonathan added a sed command to the apply test, they are no longer needed. > > The defaults always were a code smell, they presented the issue that if a

Re: [OpenStack-Infra] Remove placeholder hiera defaults commits

2015-10-27 Thread Spencer Krum
Paul, The hiera defaults were there to allow the apply test to work. Since Jonathan added a sed command to the apply test, they are no longer needed. The defaults always were a code smell, they presented the issue that if a hiera key was not found, some parameter would be set to a publicly known