Re: [OpenStack-Infra] Using ensure=>running by default in Puppet modules

2015-08-14 Thread Spencer Krum
Thank you Jeremy for noticing what went wrong and acting quickly to repair it, and for starting this thread. I think calls to increase documentation are fine... writing and approving the same change to 60+ modules is getting rather tired though. Maybe one file in system-config or openstackci with

Re: [OpenStack-Infra] Using ensure=>running by default in Puppet modules

2015-08-13 Thread Yolanda Robla Mota
Ok, but i continue seeing ths problem again between what infra says it's reasonable, and i fully believe your are right, and what downstream users are expecting on that. So why be opinionated on it? My opinion is to add the possibility to the module, defaulting to false so when an user enables

Re: [OpenStack-Infra] Using ensure=>running by default in Puppet modules

2015-08-13 Thread Jeremy Stanley
On 2015-08-13 09:16:46 -0700 (-0700), Colleen Murphy wrote: [...] > Downstream users of a puppet module will always expect the > module to [...] start services. [...] I find it hard to believe that this is a common expectation among system administrators, but it may be a cultural/generational bias

Re: [OpenStack-Infra] Using ensure=>running by default in Puppet modules

2015-08-13 Thread Colleen Murphy
On Wed, Aug 12, 2015 at 2:15 PM, Jeremy Stanley wrote: > Change https://review.openstack.org/168306 for puppet-zuul came to > my attention earlier today when it merged. After a quick discussion > on IRC, Spencer proposed a revert which I approved so that we can > get a little more discussion goin

Re: [OpenStack-Infra] Using ensure=>running by default in Puppet modules

2015-08-13 Thread James E. Blair
Fabien Boucher writes: > Hi, > > I apologize I wasn't here yesterday to discuss about that on IRC. > I was surprised also about not letting puppet ensuring that the service is > running and > now I understand well the reason behind it. But I think too, that for > most of downstream users (like t

Re: [OpenStack-Infra] Using ensure=>running by default in Puppet modules

2015-08-13 Thread Paul Belanger
On Wed, Aug 12, 2015 at 09:15:37PM +, Jeremy Stanley wrote: > Change https://review.openstack.org/168306 for puppet-zuul came to > my attention earlier today when it merged. After a quick discussion > on IRC, Spencer proposed a revert which I approved so that we can > get a little more discussi

Re: [OpenStack-Infra] Using ensure=>running by default in Puppet modules

2015-08-13 Thread Fabien Boucher
Hi, I apologize I wasn't here yesterday to discuss about that on IRC. I was surprised also about not letting puppet ensuring that the service is running and now I understand well the reason behind it. But I think too, that for most of downstream users (like those of puppet-openstackci) the most o

Re: [OpenStack-Infra] Using ensure=>running by default in Puppet modules

2015-08-13 Thread Ricardo Carrillo Cruz
I lean towards the second option that Jeremy pointed out. External users just expect Puppet to bring up services configured by the module, it makes sense to me having 'running' as default and override that at the node or wrapper module. Regards El 13/8/2015 8:30, "Yolanda Robla Mota" escribió:

Re: [OpenStack-Infra] Using ensure=>running by default in Puppet modules

2015-08-12 Thread Yolanda Robla Mota
Hi It's great that you expose that because this review passed through a lot of eyes and we all +2, we all assumed that the manifest not managing the zuul services was a bug. From my perspective, i see advantages on puppet managing these services, but I can understand that not all end users will wa

[OpenStack-Infra] Using ensure=>running by default in Puppet modules

2015-08-12 Thread Jeremy Stanley
Change https://review.openstack.org/168306 for puppet-zuul came to my attention earlier today when it merged. After a quick discussion on IRC, Spencer proposed a revert which I approved so that we can get a little more discussion going about this topic. First, I'm really sorry I didn't see and wei