Re: [openstack-dev] [puppet] Change abandonment policy

On Tue, Jun 2, 2015 at 11:39 AM, Colleen Murphy wrote: > In today's meeting we discussed implementing a policy for whether and when > core reviewers should abandon old patches whose author's were inactive. > (This doesn't apply to authors that want to abandon their own changes, only > for core re

Re: [openstack-dev] [puppet] Change abandonment policy

On 06/02/2015 02:39 PM, Colleen Murphy wrote: > In today's meeting we discussed implementing a policy for whether and > when core reviewers should abandon old patches whose author's were > inactive. (This doesn't apply to authors that want to abandon their own > changes, only for core reviewers t

Re: [openstack-dev] [puppet] Change abandonment policy

Hi, +1 for #1 and if patch is not touched for N weeks just finish it using current active team. Best regards, Boris Pavlovic On Fri, Jun 5, 2015 at 7:27 PM, Richard Raseley wrote: > Colleen Murphy wrote: > >> 3) Manually abandon after N months/weeks changes that have a -1 that was >> never res

Re: [openstack-dev] [puppet] Change abandonment policy

Colleen Murphy wrote: 3) Manually abandon after N months/weeks changes that have a -1 that was never responded to ``` If a change is submitted and given a -1, and subsequently the author becomes unresponsive for a few weeks, reviewers should leave reminder comments on the review or attempt to co

Re: [openstack-dev] [puppet] Change abandonment policy

+1 for #3 with N = 1 regards /sanjay On Fri, Jun 5, 2015 at 1:27 AM, Mike Dorman wrote: > I vote #2, with a smaller N. > > We can always adjust this policy in the future if find we have to > manually abandon too many old reviews. > > > From: Colleen Murphy > Reply-To: "puppet-openst...@pup

Re: [openstack-dev] [puppet] Change abandonment policy

I vote #2, with a smaller N. We can always adjust this policy in the future if find we have to manually abandon too many old reviews. From: Colleen Murphy Reply-To: "puppet-openst...@puppetlabs.com" Date: Tuesday, June 2, 2015 at 12:39 PM To: "OpenStack

Re: [openstack-dev] [puppet] Change abandonment policy

On 06/02/2015 08:39 PM, Colleen Murphy wrote: 4) Auto-abandon after N months/weeks if patch has a -1 or -2 ``` If a change is given a -2 and the author has been unresponsive for at least 3 months, a script will automatically abandon the change, leaving a message about how the author can resto

Re: [openstack-dev] [puppet] Change abandonment policy

Colleen Murphy wrote: > > 3) Manually abandon after N months/weeks changes that have a -1 that was > never responded to > > ``` > If a change is submitted and given a -1, and subsequently the author > becomes unresponsive for a few weeks, reviewers should leave reminder > comments on the review

Re: [openstack-dev] [puppet] Change abandonment policy

Also in favor of #2 and thought it was how it was running. #4 sounds bad and may hide good code. How do we want to account for drive-by authors who are going to be unable to work on future revisions. We talked a while back that we wanted to be able to account for this as some operators are unable