Re: [openstack-dev] [oslo] graduating oslo.middleware

2014-07-24 Thread gordon chung
> Gordon, could you prepare a version of the repository that stops with the > export and whatever changes are needed to make the test jobs for the new > > library run? If removing some of those tests is part of making the suite run, > we can talk about that on the list here, but if you can make

Re: [openstack-dev] [oslo] graduating oslo.middleware

2014-07-23 Thread Doug Hellmann
On Jul 23, 2014, at 3:49 PM, Ben Nemec wrote: > On 2014-07-23 13:25, gordon chung wrote: > >> > I left a comment on one of the commits, but in general here are my >> > thoughts: >> > 1) I would prefer not to do things like switch to oslo.i18n outside of >> > Gerrit. I realize we don't have a

Re: [openstack-dev] [oslo] graduating oslo.middleware

2014-07-23 Thread Davanum Srinivas
I agree with Ben. (" I don't want to set a precedent where we make a bunch of changes on Github and then import that code ") -- dims On Wed, Jul 23, 2014 at 3:49 PM, Ben Nemec wrote: > On 2014-07-23 13:25, gordon chung wrote: > >> I left a comment on one of the commits, but in general here are m

Re: [openstack-dev] [oslo] graduating oslo.middleware

2014-07-23 Thread Ben Nemec
On 2014-07-23 13:25, gordon chung wrote: >> I left a comment on one of the commits, but in general here are my thoughts: >> 1) I would prefer not to do things like switch to oslo.i18n outside of >> Gerrit. I realize we don't have a specific existing policy for this, but >> doing that signifi

Re: [openstack-dev] [oslo] graduating oslo.middleware

2014-07-23 Thread gordon chung
> I left a comment on one of the commits, but in general here are my thoughts: > 1) I would prefer not to do things like switch to oslo.i18n outside of > Gerrit. I realize we don't have a specific existing policy for this, but > doing that significant > work outside of Gerrit is not desirable I

Re: [openstack-dev] [oslo] graduating oslo.middleware

2014-07-23 Thread Ben Nemec
I left a comment on one of the commits, but in general here are my thoughts: 1) I would prefer not to do things like switch to oslo.i18n outside of Gerrit. I realize we don't have a specific existing policy for this, but doing that significant work outside of Gerrit is not desirable IMHO. It n

Re: [openstack-dev] [oslo] graduating oslo.middleware

2014-07-22 Thread Julien Danjou
On Tue, Jul 22 2014, gordon chung wrote: > hi, > following the oslo graduation protocol, could the oslo team review the > oslo.middleware library[1] i've created and see if there are any issues. > [1] https://github.com/chungg/oslo.middleware LGTM. Don't forget to gate it on py33. :) -- Julien