Hi
2015-09-29 10:09 GMT+09:00 Ian Wienand :
> On 09/24/2015 08:18 PM, Andrey Kurilin wrote:
>>
>> I agree that wrong order of arguments misleads while debugging errors, BUT
>> how we can prevent regression?
>
>
> Spell it out and use keyword args?
>
> assertEqual(expected="foo", observed=...)
>
On 09/24/2015 08:18 PM, Andrey Kurilin wrote:
I agree that wrong order of arguments misleads while debugging errors, BUT
how we can prevent regression?
Spell it out and use keyword args?
assertEqual(expected="foo", observed=...)
is pretty hard to mess up
-i
___
Kekane
>
> -Original Message-
> From: Bulat Gaifullin [mailto:bgaiful...@mirantis.com]
> Sent: 24 September 2015 13:29
> To: OpenStack Development Mailing List (not for usage questions)
> Subject: Re: [openstack-dev] [murano] Fix order of arguments in assertEqual
>
(not for usage questions)
Subject: Re: [openstack-dev] [murano] Fix order of arguments in assertEqual
+1
> On 24 Sep 2015, at 10:45, Tetiana Lashchova wrote:
>
> Hi folks!
>
> Some tests in murano code use incorrect order of arguments in assertEqual.
> The correct order expecte
Hi!
Good catch. Have no objections for fixing it right now.
Regards,
Kate.
On Thu, Sep 24, 2015 at 10:58 AM, Bulat Gaifullin
wrote:
> +1
>
> > On 24 Sep 2015, at 10:45, Tetiana Lashchova
> wrote:
> >
> > Hi folks!
> >
> > Some tests in murano code use incorrect order of arguments in
> assert
+1
> On 24 Sep 2015, at 10:45, Tetiana Lashchova wrote:
>
> Hi folks!
>
> Some tests in murano code use incorrect order of arguments in assertEqual.
> The correct order expected by the testtools is
>
> def assertEqual(self, expected, observed, message=''):
> """Assert that
