Re: [openstack-dev] [goals][upgrade-checkers] Week R-31 update

2018-09-13 Thread Ben Nemec
On 09/12/2018 01:57 PM, Doug Hellmann wrote: Excerpts from Ben Nemec's message of 2018-09-12 13:51:16 -0600: On 09/04/2018 06:49 PM, Matt Riedemann wrote: On 9/4/2018 6:39 PM, Ben Nemec wrote: Would it be helpful to factor some of the common code out into an Oslo library so projects basical

Re: [openstack-dev] [goals][upgrade-checkers] Week R-31 update

2018-09-12 Thread Zane Bitter
On 4/09/18 5:39 PM, Ben Nemec wrote: Would it be helpful to factor some of the common code out into an Oslo library so projects basically just have to subclass, implement check functions, and add them to the _upgrade_checks dict? It's not a huge amount of code, but a bunch of it seems like it w

Re: [openstack-dev] [goals][upgrade-checkers] Week R-31 update

2018-09-12 Thread Doug Hellmann
Excerpts from Ben Nemec's message of 2018-09-12 13:51:16 -0600: > > On 09/04/2018 06:49 PM, Matt Riedemann wrote: > > On 9/4/2018 6:39 PM, Ben Nemec wrote: > >> Would it be helpful to factor some of the common code out into an Oslo > >> library so projects basically just have to subclass, impleme

Re: [openstack-dev] [goals][upgrade-checkers] Week R-31 update

2018-09-12 Thread Ben Nemec
On 09/04/2018 06:49 PM, Matt Riedemann wrote: On 9/4/2018 6:39 PM, Ben Nemec wrote: Would it be helpful to factor some of the common code out into an Oslo library so projects basically just have to subclass, implement check functions, and add them to the _upgrade_checks dict? It's not a huge

Re: [openstack-dev] [goals][upgrade-checkers] Week R-31 update

2018-09-04 Thread Matt Riedemann
On 9/4/2018 6:39 PM, Ben Nemec wrote: Would it be helpful to factor some of the common code out into an Oslo library so projects basically just have to subclass, implement check functions, and add them to the _upgrade_checks dict? It's not a huge amount of code, but a bunch of it seems like it

Re: [openstack-dev] [goals][upgrade-checkers] Week R-31 update

2018-09-04 Thread Doug Hellmann
Excerpts from Ben Nemec's message of 2018-09-04 18:39:35 -0500: > Would it be helpful to factor some of the common code out into an Oslo > library so projects basically just have to subclass, implement check > functions, and add them to the _upgrade_checks dict? It's not a huge > amount of code,

Re: [openstack-dev] [goals][upgrade-checkers] Week R-31 update

2018-09-04 Thread Ben Nemec
Would it be helpful to factor some of the common code out into an Oslo library so projects basically just have to subclass, implement check functions, and add them to the _upgrade_checks dict? It's not a huge amount of code, but a bunch of it seems like it would need to be copy-pasted into ever