Re: [openstack-dev] code review

Please, don't send review requests to the list. if it's an urgent matter, please ping directly on IRC. Also, if you really have to send it to the list, tag the email subject with the projects! Thanks :) FF On 20/01/14 10:07 +0800, 黎林果 wrote: Hi all, I'd like you to examine a change. Please

[openstack-dev] code review

Hi all, I'd like you to examine a change. Please visit [neutron] https://review.openstack.org/#/c/63981/ ‘ipt_mgr.ipv6 written in the wrong ipt_mgr.ipv4’ [nova] https://review.openstack.org/#/c/64241/ 'Add API schema for v3 multinic API' [python-keystoneclient] https://review.openstack.org/#/c

Re: [openstack-dev] Code Review (Jenkins-job-builder, BlameUpstream[Committers] plugin support)

Please read: http://lists.openstack.org/pipermail/openstack-dev/2013-September/015264.html On 11/14/2013 05:22 PM, Peter Liljenberg wrote: Hi, Could someone review this please: https://review.openstack.org/#/c/54085/ Regards, Peter __

Re: [openstack-dev] Code Review (Jenkins-job-builder, added support for GitBlit projectname)

This ML is not for review requests. Please read http://lists.openstack.org/pipermail/openstack-dev/2013-September/015264.html best, Joe On Thu, Nov 14, 2013 at 2:21 PM, Peter Liljenberg wrote: > Hi, > > I've added a property 'projectname' to the GitBlit repo viewer. Please > have a look and re

Re: [openstack-dev] Code Review (Jenkins-job-builder, BlameUpstream[Committers] plugin support)

This ML is not for review requests. Please read http://lists.openstack.org/pipermail/openstack-dev/2013-September/015264.html best, Joe On Thu, Nov 14, 2013 at 2:22 PM, Peter Liljenberg wrote: > Hi, > > Could someone review this please: > > https://review.openstack.org/#/c/54085/ > > Regards,

[openstack-dev] Code Review (Jenkins-job-builder, BlameUpstream[Committers] plugin support)

Hi, Could someone review this please: https://review.openstack.org/#/c/54085/ Regards, Peter ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] Code Review (Jenkins-job-builder, added support for GitBlit projectname)

Hi, I've added a property 'projectname' to the GitBlit repo viewer. Please have a look and review :) https://review.openstack.org/56475 Regards, Peter ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/

Re: [openstack-dev] Code Review (Jenkins-job-builder, BlameUpstreamCommitters plugin support)

Please read http://lists.openstack.org/pipermail/openstack-dev/2013-September/015264.html On Tue, Nov 12, 2013 at 11:35 AM, Peter Liljenberg wrote: > Hi, > > Could someone review this please: > > https://review.openstack.org/#/c/54085/ > > Regards, > Peter > > ___

[openstack-dev] Code Review (Jenkins-job-builder, BlameUpstreamCommitters plugin support)

Hi, Could someone review this please: https://review.openstack.org/#/c/54085/ Regards, Peter ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] Code Review (Jenkins-job-builder, BlameUpstreamCommitters plugin support)

Hi Peter, Could you explain more about the scenario this plugin fits in existing openstack jenkins jobs? I haven't seen any jobs with upstream , except devstack-gate related slave usage status transition jobs, which are already superseded by nodepool. IRC channel openstack-infra and mailing list o

[openstack-dev] Code Review (Jenkins-job-builder, BlameUpstreamCommitters plugin support)

Hi, Could someone review this please: https://review.openstack.org/#/c/54085/ Regards, Peter ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] Code Review (Jenkins-job-builder, BlameUpstreamCommitters plugin support)

Hi, Could someone review this please: https://review.openstack.org/#/c/54085/ Regards, Peter ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] Code review (Jenkins-job-builder / sbt-plugin)

I believe we are waiting for Mathieu Gagné re-review before approving. ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] Code review (Jenkins-job-builder / sbt-plugin)

Hi, Could someone review/approve this (Added SBT builder support), thanks! https://review.openstack.org/#/c/44685/ /Peter ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.o

Re: [openstack-dev] Code review

Ah, Will do! Thx! /Peter On 3 September 2013 08:56, Flavio Percoco wrote: > On 03/09/13 08:28 +0200, Peter Liljenberg wrote: > >> Hi, >> >> Could someone review this (Added support for JaCoCo plugin Publisher). >> >> https://review.openstack.org/#**/c/44705/

Re: [openstack-dev] Code review

On 03/09/13 08:28 +0200, Peter Liljenberg wrote: Hi, Could someone review this (Added support for JaCoCo plugin Publisher). https://review.openstack.org/#/c/44705/ /Peter Hi, When asking for Code Reviews, pls, tag the email subject with the project in matter. Cheers, FF -- @flaper87 Flav

[openstack-dev] Code review request

Hi, Could someone review this (Added SBT builder support ). https://review.openstack.org/#/c/44685/ /Peter ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mail

[openstack-dev] Code review

Hi, Could someone review this (Added support for JaCoCo plugin Publisher ). https://review.openstack.org/#/c/44705/ /Peter ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.

Re: [openstack-dev] Code review study

On Tue, Aug 20, 2013 at 2:21 PM, Clint Byrum wrote: > Excerpts from Mark McLoughlin's message of 2013-08-20 03:26:01 -0700: > > On Thu, 2013-08-15 at 14:12 +1200, Robert Collins wrote: > > > This may interest data-driven types here. > > > > > > > https://www.ibm.com/developerworks/rational/librar

Re: [openstack-dev] Code review study

> -Original Message- > From: Flavio Percoco [mailto:fla...@redhat.com] > Sent: Monday, August 26, 2013 11:41 AM > To: OpenStack Development Mailing List > Subject: Re: [openstack-dev] Code review study > > On 20/08/13 11:24 -0400, Russell Bryant wrote: > >On

Re: [openstack-dev] Code review study

On 20/08/13 11:24 -0400, Russell Bryant wrote: On 08/20/2013 11:08 AM, Daniel P. Berrange wrote: On Tue, Aug 20, 2013 at 04:02:12PM +0100, Mark McLoughlin wrote: On Tue, 2013-08-20 at 11:26 +0100, Mark McLoughlin wrote: On Thu, 2013-08-15 at 14:12 +1200, Robert Collins wrote: This may interes

Re: [openstack-dev] Code review study

Excerpts from Mark McLoughlin's message of 2013-08-20 03:26:01 -0700: > On Thu, 2013-08-15 at 14:12 +1200, Robert Collins wrote: > > This may interest data-driven types here. > > > > https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ > > > > Note specifically

Re: [openstack-dev] Code review study

On Tue, Aug 20, 2013 at 8:02 AM, Mark McLoughlin wrote: > On Tue, 2013-08-20 at 11:26 +0100, Mark McLoughlin wrote: > > The full study is here: > > > > > http://support.smartbear.com/resources/cc/book/code-review-cisco-case-study.pdf > I can't find the data they based their numbers on, nor their

Re: [openstack-dev] Code review study

On 08/20/2013 11:08 AM, Daniel P. Berrange wrote: > On Tue, Aug 20, 2013 at 04:02:12PM +0100, Mark McLoughlin wrote: >> On Tue, 2013-08-20 at 11:26 +0100, Mark McLoughlin wrote: >>> On Thu, 2013-08-15 at 14:12 +1200, Robert Collins wrote: This may interest data-driven types here. htt

Re: [openstack-dev] Code review study

On Tue, Aug 20, 2013 at 04:02:12PM +0100, Mark McLoughlin wrote: > On Tue, 2013-08-20 at 11:26 +0100, Mark McLoughlin wrote: > > On Thu, 2013-08-15 at 14:12 +1200, Robert Collins wrote: > > > This may interest data-driven types here. > > > > > > https://www.ibm.com/developerworks/rational/library/

Re: [openstack-dev] Code review study

On Tue, 2013-08-20 at 11:26 +0100, Mark McLoughlin wrote: > On Thu, 2013-08-15 at 14:12 +1200, Robert Collins wrote: > > This may interest data-driven types here. > > > > https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ > > > > Note specifically the citatio

Re: [openstack-dev] Code review study

On Thu, 2013-08-15 at 14:12 +1200, Robert Collins wrote: > This may interest data-driven types here. > > https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ > > Note specifically the citation of 200-400 lines as the knee of the review > effectiveness curve: th

Re: [openstack-dev] Code review study

On Tue, Aug 20, 2013 at 5:14 AM, Jay Buffington wrote: > > This is really interesting. I wish they would have explicitly defined > "lines of code." Is that "git show |wc -l"? Just the new lines which > were added? The sum of the lines changed, removed and added? You can > get vastly different

Re: [openstack-dev] Code review study

On Wed, Aug 14, 2013 at 7:12 PM, Robert Collins wrote: > Note specifically the citation of 200-400 lines as the knee of the review > effectiveness curve: that's lower than I thought - I thought 200 was > clearly fine - but no. > This is really interesting. I wish they would have explicitly defin

Re: [openstack-dev] Code review study

On 08/15/2013 12:12 PM, Robert Collins wrote: > This may interest data-driven types here. > > https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ > > Note specifically the citation of 200-400 lines as the knee of the > review effectiveness curve: that's lower

Re: [openstack-dev] Code review study

On Aug 16, 2013, at 2:12 AM, Robert Collins wrote: > On 16 August 2013 20:15, Maru Newby wrote: > >>> This pattern has one slight issue, which is: >>> >>> • Do not assume the reviewer has access to external web services/site. >>> In 6 months time when someone is on a train/plane/coach/be

Re: [openstack-dev] Code review study

On 15/08/13 22:27 +0930, Christopher Yeoh wrote: On Thu, Aug 15, 2013 at 9:54 PM, Daniel P. Berrange wrote:Commit message quality has improved somewhat since I first wrote & published that page, but there's definitely still scope to improve things further. What it really needs is for m

Re: [openstack-dev] Code review study

On 16 August 2013 20:15, Maru Newby wrote: >> This pattern has one slight issue, which is: >> >> • Do not assume the reviewer has access to external web services/site. >> In 6 months time when someone is on a train/plane/coach/beach/pub >> troubleshooting a problem & browsing GIT history,

Re: [openstack-dev] Code review study

ith them. A dvcs is great and all, but unless one is working in a silo, online resources are all but mandatory. m. > > > https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages > > > > > > Sam > > > > From: Christo

Re: [openstack-dev] Code review study

ommit_messages > ** > > Sam > > ** ** > > *From:* Christopher Yeoh [mailto:cbky...@gmail.com] > *Sent:* Thursday, August 15, 2013 7:12 AM > *To:* OpenStack Development Mailing List > *Subject:* Re: [openstack-dev] Code review study > > ** ** > >

Re: [openstack-dev] Code review study

formatting and hyperlinks in my documentation of the commit. Sam From: Christopher Yeoh [mailto:cbky...@gmail.com] Sent: Thursday, August 15, 2013 7:12 AM To: OpenStack Development Mailing List Subject: Re: [openstack-dev] Code review study On Thu, Aug 15, 2013 at 11:42 AM, Robert Collins mailto:robe

Re: [openstack-dev] Code review study

On Thu, Aug 15, 2013 at 12:00 PM, Mark Washenberger < mark.washenber...@markwash.net> wrote: > > > > On Thu, Aug 15, 2013 at 5:12 AM, Christopher Yeoh wrote: > >> >> On Thu, Aug 15, 2013 at 11:42 AM, Robert Collins < >> robe...@robertcollins.net> wrote: >> >>> This may interest data-driven types h

Re: [openstack-dev] Code review study

On Thu, Aug 15, 2013 at 5:12 AM, Christopher Yeoh wrote: > > On Thu, Aug 15, 2013 at 11:42 AM, Robert Collins < > robe...@robertcollins.net> wrote: > >> This may interest data-driven types here. >> >> >> https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ >> >

Re: [openstack-dev] Code review study

On Thu, Aug 15, 2013 at 9:56 AM, Daniel P. Berrange wrote: > On Thu, Aug 15, 2013 at 09:46:07AM -0500, Dolph Mathews wrote: > > On Thu, Aug 15, 2013 at 7:57 AM, Christopher Yeoh > wrote: > > > > > On Thu, Aug 15, 2013 at 9:54 PM, Daniel P. Berrange < > berra...@redhat.com>wrote:Commit message qua

Re: [openstack-dev] Code review study

On Thu, Aug 15, 2013 at 09:46:07AM -0500, Dolph Mathews wrote: > On Thu, Aug 15, 2013 at 7:57 AM, Christopher Yeoh wrote: > > > On Thu, Aug 15, 2013 at 9:54 PM, Daniel P. Berrange > > wrote:Commit message quality has improved somewhat > > since I first wrote & > > published > > > > that page,

Re: [openstack-dev] Code review study

On Thu, Aug 15, 2013 at 7:57 AM, Christopher Yeoh wrote: > On Thu, Aug 15, 2013 at 9:54 PM, Daniel P. Berrange > wrote:Commit message quality has improved somewhat since > I first wrote & > published > > that page, but there's definitely still scope to improve things further. >> What >> it rea

Re: [openstack-dev] Code review study

On Thu, Aug 15, 2013 at 9:54 PM, Daniel P. Berrange wrote:Commit message quality has improved somewhat since I first wrote & published > that page, but there's definitely still scope to improve things further. > What > it really needs is for more reviewers to push back against badly written > comm

Re: [openstack-dev] Code review study

On Thu, Aug 15, 2013 at 7:12 AM, Christopher Yeoh wrote: > > On Thu, Aug 15, 2013 at 11:42 AM, Robert Collins < > robe...@robertcollins.net> wrote: > >> This may interest data-driven types here. >> >> >> https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ >> >

Re: [openstack-dev] Code review study

On Thu, Aug 15, 2013 at 09:42:09PM +0930, Christopher Yeoh wrote: > On Thu, Aug 15, 2013 at 11:42 AM, Robert Collins > wrote: > > > This may interest data-driven types here. > > > > > > https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ > > > > Note specifical

Re: [openstack-dev] Code review study

On Thu, Aug 15, 2013 at 11:42 AM, Robert Collins wrote: > This may interest data-driven types here. > > > https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ > > Note specifically the citation of 200-400 lines as the knee of the review > effectiveness curve: th

Re: [openstack-dev] Code review study

That's an interesting article and also meaningful for coders. If I have a patch more than 200 or 300 lines, to split this may be a good idea. Some time, an easy patch with a little more lines would prevent more reviewers to think about it. On Thu, Aug 15, 2013 at 10:12 AM, Robert Collins wrote:

[openstack-dev] Code review study

This may interest data-driven types here. https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ Note specifically the citation of 200-400 lines as the knee of the review effectiveness curve: that's lower than I thought - I thought 200 was clearly fine - but no.