Re: [openstack-dev] RFC: reverse the default Gerrit sort order

2013-11-14 Thread Steven Hardy
On Thu, Nov 07, 2013 at 12:36:49PM +1300, Robert Collins wrote: > I've been thinking about review queues recently (since here at the > summit everyone is talking about reviews! :)). > > One thing that struck me today was that Gerrit makes it easier to > review the newest changes first, rather than

Re: [openstack-dev] RFC: reverse the default Gerrit sort order

2013-11-13 Thread Mike Perez
On Wed, Nov 6, 2013 at 3:36 PM, Robert Collins wrote: > I've been thinking about review queues recently (since here at the > summit everyone is talking about reviews! :)). > > One thing that struck me today was that Gerrit makes it easier to > review the newest changes first, rather than the chang

Re: [openstack-dev] RFC: reverse the default Gerrit sort order

2013-11-12 Thread Robert Collins
On 11 November 2013 17:06, Clark Boylan wrote: > On Sun, Nov 10, 2013 at 6:18 PM, Robert Collins > They are sorted on the reverse of the default sort order (which is Sadly not. The default sort order shows most-recently-updated first, which is a field which changes on new push, on comments, etc.

Re: [openstack-dev] RFC: reverse the default Gerrit sort order

2013-11-11 Thread Chris Jones
Hey On 11 November 2013 12:36, Monty Taylor wrote: > In the meantime, I've been making complex search queries in the search > box and then just saving the resulting URL as 'saved search' link. > I got bored enough with maintaining them in the tiny search box, that I quickly whipped up: https:/

Re: [openstack-dev] RFC: reverse the default Gerrit sort order

2013-11-10 Thread Michael Davies
On Mon, Nov 11, 2013 at 3:06 PM, Monty Taylor wrote: [snip] > - "I have previously reviewed the patch" is not a searchable term. (I > know, because I'd like a view of "things I have not reviewed yet") +1 FWIW, I'd like to see this too. Quickly finding reviews that I have or haven't already re

Re: [openstack-dev] RFC: reverse the default Gerrit sort order

2013-11-10 Thread Monty Taylor
On 11/10/2013 11:06 PM, Clark Boylan wrote: > On Sun, Nov 10, 2013 at 6:18 PM, Robert Collins > wrote: >> On 11 November 2013 10:06, Monty Taylor wrote: >>> >>> >> >>> Not possible now. With gerrit 2.8 (hopefully something we can get >>> deployed soonish) we introduce the Custom Dashboards feat

Re: [openstack-dev] RFC: reverse the default Gerrit sort order

2013-11-10 Thread Clark Boylan
On Sun, Nov 10, 2013 at 6:18 PM, Robert Collins wrote: > On 11 November 2013 10:06, Monty Taylor wrote: >> >> > >> Not possible now. With gerrit 2.8 (hopefully something we can get >> deployed soonish) we introduce the Custom Dashboards feature. The >> "Important Changes" page will be implemented

Re: [openstack-dev] RFC: reverse the default Gerrit sort order

2013-11-10 Thread Clark Boylan
On Sun, Nov 10, 2013 at 2:50 PM, Dolph Mathews wrote: > > On Sun, Nov 10, 2013 at 3:06 PM, Monty Taylor wrote: >> >> >> https://review.openstack.org/#/mine/important/ >> >> Shows me old changes at the top of the reviewable section. Do you use >> that view at all? > > > That shows me all my own re

Re: [openstack-dev] RFC: reverse the default Gerrit sort order

2013-11-10 Thread Morgan Fainberg
The point of my minus 1 was to allow me to toggle it as needed if t really disrupted my workflow to hit the important reviews. Regardless of the technical issues (rebuilding gerrit) I would support the default being changed, just a way to swap it back for an adjustment period. My last email was a

Re: [openstack-dev] RFC: reverse the default Gerrit sort order

2013-11-10 Thread Robert Collins
On 11 November 2013 10:06, Monty Taylor wrote: > > > Not possible now. With gerrit 2.8 (hopefully something we can get > deployed soonish) we introduce the Custom Dashboards feature. The > "Important Changes" page will be implemented using that, which means we > should be able to play with things

Re: [openstack-dev] RFC: reverse the default Gerrit sort order

2013-11-10 Thread Robert Collins
On 9 November 2013 01:51, Morgan Fainberg wrote: > I agree this would be interesting but if it isn't configurable (e.g. A > mechanism to support current behavior) I think this would very much disrupt > the workflow I use. If configurable, I'd be open to it, if not configurable > I have to say -

Re: [openstack-dev] RFC: reverse the default Gerrit sort order

2013-11-10 Thread Dolph Mathews
On Sun, Nov 10, 2013 at 3:06 PM, Monty Taylor wrote: > > https://review.openstack.org/#/mine/important/ > > Shows me old changes at the top of the reviewable section. Do you use > that view at all? > That shows me all my own reviews merged & abandoned first, which are just noise when I'm trying

Re: [openstack-dev] RFC: reverse the default Gerrit sort order

2013-11-10 Thread Monty Taylor
On 11/06/2013 06:36 PM, Robert Collins wrote: > I've been thinking about review queues recently (since here at the > summit everyone is talking about reviews! :)). > > One thing that struck me today was that Gerrit makes it easier to > review the newest changes first, rather than the changes tha

Re: [openstack-dev] RFC: reverse the default Gerrit sort order

2013-11-08 Thread Morgan Fainberg
On Friday, November 8, 2013, Joe Gordon wrote: > > > > On Thu, Nov 7, 2013 at 7:36 AM, Robert Collins > 'robe...@robertcollins.net');> > > wrote: > >> I've been thinking about review queues recently (since here at the >> summit everyone is talking about reviews! :)). >> >> One thing that struck

Re: [openstack-dev] RFC: reverse the default Gerrit sort order

2013-11-07 Thread Joe Gordon
On Thu, Nov 7, 2013 at 7:36 AM, Robert Collins wrote: > I've been thinking about review queues recently (since here at the > summit everyone is talking about reviews! :)). > > One thing that struck me today was that Gerrit makes it easier to > review the newest changes first, rather than the chang

[openstack-dev] RFC: reverse the default Gerrit sort order

2013-11-06 Thread Robert Collins
I've been thinking about review queues recently (since here at the summit everyone is talking about reviews! :)). One thing that struck me today was that Gerrit makes it easier to review the newest changes first, rather than the changes that have been in the queue longest, or the changes that star