On 05/06/2014 01:13 PM, Joe Gordon wrote:
On Mon, May 5, 2014 at 10:56 AM, Ben Nemec mailto:openst...@nemebean.com>> wrote:
On 05/05/2014 10:02 AM, ChangBo Guo wrote:
Hi Stackers,
I find some common code style would be avoided while I'm
reviewing code
,so
On Tue, May 6, 2014 at 6:03 AM, Doug Hellmann
wrote:
> On Mon, May 5, 2014 at 9:06 PM, David Stanek wrote:
> >
> > On Mon, May 5, 2014 at 5:28 PM, Doug Hellmann <
> doug.hellm...@dreamhost.com>
> > wrote:
> >>
> >>
> >> > The assert ones do seem to fit the best practices as I understand
> them,
>
On Mon, May 5, 2014 at 10:56 AM, Ben Nemec wrote:
> On 05/05/2014 10:02 AM, ChangBo Guo wrote:
>
>> Hi Stackers,
>>
>> I find some common code style would be avoided while I'm reviewing code
>> ,so think these check would
>> be nice to move into local hacking. The local hacking can ease reviewer
On Mon, May 5, 2014 at 9:06 PM, David Stanek wrote:
>
> On Mon, May 5, 2014 at 5:28 PM, Doug Hellmann
> wrote:
>>
>>
>> > The assert ones do seem to fit the best practices as I understand them,
>> > but
>> > I suspect there's going to be quite a bit of work to get projects
>> > compliant.
>>
>> I
On Mon, May 5, 2014 at 5:28 PM, Doug Hellmann
wrote:
>
>
> > The assert ones do seem to fit the best practices as I understand them,
> but
> > I suspect there's going to be quite a bit of work to get projects
> compliant.
>
> I've seen some work being done on that already, but I don't know how
> st
On Mon, May 5, 2014 at 1:56 PM, Ben Nemec wrote:
> On 05/05/2014 10:02 AM, ChangBo Guo wrote:
>>
>> Hi Stackers,
>>
>> I find some common code style would be avoided while I'm reviewing code
>> ,so think these check would
>> be nice to move into local hacking. The local hacking can ease reviewer
>
On 05/05/2014 10:02 AM, ChangBo Guo wrote:
Hi Stackers,
I find some common code style would be avoided while I'm reviewing code
,so think these check would
be nice to move into local hacking. The local hacking can ease reviewer
burden.
The idea from keystone blueprint [1].
Hacking is a great st
On Mon, May 5, 2014 at 8:02 AM, ChangBo Guo wrote:
> Hi Stackers,
>
> I find some common code style would be avoided while I'm reviewing code
> ,so think these check would
> be nice to move into local hacking. The local hacking can ease reviewer
> burden.
>
> The idea from keystone blueprint [1].
Hi Stackers,
I find some common code style would be avoided while I'm reviewing code ,so
think these check would
be nice to move into local hacking. The local hacking can ease reviewer
burden.
The idea from keystone blueprint [1].
Hacking is a great start at automating checks for common style iss
