I agree with Rob in terms of tooling and with Travis on rules.Any linting tool is fine with me as long as it does not break the rules we currently have set in Horizon. I believe the rules right now are general enough, so switching to eslint might not be an issue, but its something to look into. And
On Tue, Jun 16, 2015 at 10:22 AM Tripp, Travis S
wrote:
> I think agreeing on rules is the bigger problem here and I don’t think all
> the projects should have to agree on rules.
I believe we agree there, mostly. I personally feel there is some benefit
to setting some rules, likely published as
/blob/master/.jshintrc
From: "Rob Cresswell (rcresswe)"
Reply-To: OpenStack List
Date: Tuesday, June 16, 2015 at 1:40 AM
To: OpenStack List
Subject: Re: [openstack-dev] [javascript] [horizon] [merlin] [refstack]
Javascript Linting
So my view here is that I don’t particularly mi
"OpenStack Development Mailing List (not for usage questions)" <
> openstack-dev@lists.openstack.org>
> Subject: [openstack-dev] [javascript] [horizon] [merlin] [refstack]
> Javascript Linting
>
> I'm restarting this thread with a different subject line to g
penstack-dev@lists.openstack.org>>
Subject: [openstack-dev] [javascript] [horizon] [merlin] [refstack] Javascript
Linting
I'm restarting this thread with a different subject line to get a broader
audience. Here's the original thread:
http://lists.openstack.org/pipermail/openstack
Sorry, wrong patch. That one added the style requirement to the project
contribution guidelines. This is the one that added the .jscsrc config:
https://review.openstack.org/#/c/185725/
On Tue, 16 Jun 2015 at 14:21 Richard Jones wrote:
> JSCS in Horizon has been extended with the John Papa style
On 16 June 2015 at 16:21, Richard Jones wrote:
> JSCS in Horizon has been extended with the John Papa style guidelines to
> enforce consistent angularjs code style*. It's no longer just a findbug
> tool. I don't have time to investigate - can ESLint perform the same role
> for Horizon?
Yes - http
JSCS in Horizon has been extended with the John Papa style guidelines to
enforce consistent angularjs code style*. It's no longer just a findbug
tool. I don't have time to investigate - can ESLint perform the same role
for Horizon?
Current Horizon activity involves a whole lot of bringing code int
On 16 June 2015 at 11:36, Michael Krotscheck wrote:
...
> My personal opinion/recommendation: Based on the above, I recommend we use
> ESLint. My reasoning: It's one tool, it's extensible, it does both codestyle
> things and bug finding things, and it has a good license. JSHint is
> disqualified b
I'm restarting this thread with a different subject line to get a broader
audience. Here's the original thread:
http://lists.openstack.org/pipermail/openstack-dev/2015-June/066040.html
The question at hand is "What will be OpenStack's javascript equivalent of
flake8". I'm going to consider the nee
10 matches
Mail list logo
