Re: [openstack-dev] [Tuskar][Horizon] Javascript linter

2014-04-02 Thread Michael Krotscheck
+1 on talking to lawyers. Some more context: JSHint is a fork of JSLint, from which the problem license originates. The team has made a significant effort to strip out and replace JSLint code, however there remains one file which they haven’t tackled yet. There’s a large discussion here, incl

Re: [openstack-dev] [Tuskar][Horizon] Javascript linter

2014-04-02 Thread Monty Taylor
On 04/02/2014 11:05 AM, Ana Krivokapic wrote: On 04/02/2014 07:36 PM, Dougal Matthews wrote: On my phone so I can't follow this up more now, but it looks like JSHint is already used. https://review.openstack.org/#/c/41087/ That commit has since been reverted and JSHint removed from Horizon

Re: [openstack-dev] [Tuskar][Horizon] Javascript linter

2014-04-02 Thread Ana Krivokapic
On 04/02/2014 07:36 PM, Dougal Matthews wrote: On my phone so I can't follow this up more now, but it looks like JSHint is already used. https://review.openstack.org/#/c/41087/ That commit has since been reverted and JSHint removed from Horizon codebase: https://bugs.launchpad.net/horiz

Re: [openstack-dev] [Tuskar][Horizon] Javascript linter

2014-04-02 Thread Dougal Matthews
On my phone so I can't follow this up more now, but it looks like JSHint is already used. https://review.openstack.org/#/c/41087/___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openst

Re: [openstack-dev] [Tuskar][Horizon] Javascript linter

2014-04-02 Thread Monty Taylor
I agree - it's not a viral license, and we're not shipping it anyway. I'm going to go back to the original thing: " Recently we have been discussing the topic of Javascript linters for Horizon and Tuskar-UI with Radomir, and he told me that JSLint and JSHint can not be integrated into the test

Re: [openstack-dev] [Tuskar][Horizon] Javascript linter

2014-04-02 Thread Adam Nelson
I don't see why the license of a piece of software used to check the codebase (i.e. the linter) infects the codebase being checked. That would be like saying the Google terms of service under which I'm writing this email (Google Apps) infects the codebase. -- Kili - Cloud for Africa: kili.io Musi

Re: [openstack-dev] [Tuskar][Horizon] Javascript linter

2014-04-02 Thread Ben Nemec
I think that would be a good idea. We're not shipping this, we're just using it in test (AIUI), so I don't think incompatibility with the OpenStack license is necessarily an issue. But IANAL. :-) -Ben On 04/02/2014 09:24 AM, Kevin Conway wrote: I understand, and appreciate, the concern for

Re: [openstack-dev] [Tuskar][Horizon] Javascript linter

2014-04-02 Thread Kevin Conway
I understand, and appreciate, the concern for licensing, but it would be a real shame to discount some of the most widely used linters because of a clause that prevents us from being evil. Any chance we could run this by legal-disc...@lists.openstack.org and hear their reactions before we axe the

Re: [openstack-dev] [Tuskar][Horizon] Javascript linter

2014-04-02 Thread Radomir Dopieralski
On 02/04/14 15:26, Kevin Conway wrote: > What licensing issues were brought up that prevent the use of JSLint or > JSHint? Both are MIT licensed. > > Granted, JSLint has an additional clause: > > The Software shall be used for Good, not Evil. > > > Maybe that's it? If so, Crockford has been

Re: [openstack-dev] [Tuskar][Horizon] Javascript linter

2014-04-02 Thread Kevin Conway
What licensing issues were brought up that prevent the use of JSLint or JSHint? Both are MIT licensed. Granted, JSLint has an additional clause: > The Software shall be used for Good, not Evil. Maybe that's it? If so, Crockford has been known to make exceptions for organizations that wish to us

[openstack-dev] [Tuskar][Horizon] Javascript linter

2014-04-02 Thread Peter Belanyi
Hi all, Recently we have been discussing the topic of Javascript linters for Horizon and Tuskar-UI with Radomir, and he told me that JSLint and JSHint can not be integrated into the test environment due to some license issues. I did some search and found Closure Linter [1] by Google which might