On 08/18/2014 06:06 PM, Daniel P. Berrange wrote:
> On Mon, Aug 18, 2014 at 11:27:39AM -0400, Doug Hellmann wrote:
>>
>> On Aug 18, 2014, at 10:15 AM, Daniel P. Berrange wrote:
>>
>>> On Mon, Aug 18, 2014 at 07:57:28AM +1000, Michael Still wrote:
My recollection is that this was a request fro
On Sun, Aug 17, 2014 at 9:24 AM, Jay Bryant
wrote:
> +2
>
> I prefer the LOG.warning format and support that given the documentation
> you shared.
>
> If there is agreement I would create a hacking check.
>
I think a better approach is to just not care which i used here. IMHO
mixing up LOG.warn
On Mon, Aug 18, 2014 at 11:27:39AM -0400, Doug Hellmann wrote:
>
> On Aug 18, 2014, at 10:15 AM, Daniel P. Berrange wrote:
>
> > On Mon, Aug 18, 2014 at 07:57:28AM +1000, Michael Still wrote:
> >> My recollection is that this was a request from the oslo team, but it
> >> was so long ago that I d
On Aug 18, 2014, at 10:15 AM, Daniel P. Berrange wrote:
> On Mon, Aug 18, 2014 at 07:57:28AM +1000, Michael Still wrote:
>> My recollection is that this was a request from the oslo team, but it
>> was so long ago that I don't recall the details.
>>
>> I think the change is low value, so should
On Mon, Aug 18, 2014 at 07:57:28AM +1000, Michael Still wrote:
> My recollection is that this was a request from the oslo team, but it
> was so long ago that I don't recall the details.
>
> I think the change is low value, so should only be done when someone
> is changing the logging in a file alr
warn() and warning() are synonyms (literally the same method, aliased). We had
to add a similar alias in the oslo ContextAdapter to support code using both
forms in existing code. If the documented form is warning(), then I agree we
should stick with that, although I don’t think the churn caused
My recollection is that this was a request from the oslo team, but it
was so long ago that I don't recall the details.
I think the change is low value, so should only be done when someone
is changing the logging in a file already (the log hinting for
example).
Michael
On Sun, Aug 17, 2014 at 4:2
+2
I prefer the LOG.warning format and support that given the documentation
you shared.
If there is agreement I would create a hacking check.
Jay
On Aug 17, 2014 1:28 AM, "Gary Kotton" wrote:
> Hi,
> Over the last few weeks I have seen a number of patches where LOG.warn is
> replacing LOG.war
Hi,
Over the last few weeks I have seen a number of patches where LOG.warn is
replacing LOG.warning. I think that if we do something it should be the
opposite as warning is the documented one in python 2 and 3
https://docs.python.org/3/howto/logging.html.
Any thoughts?
Thanks
Gary
__
