Re: [openstack-dev] [Fuel] Patch size limit

2015-12-08 Thread Andrey Tykhonov
in community is > responsible of code quality of the project. > Yes, agree. Good discussion helps a lot. Thank you! Andrey > > - I > > On Mon, Dec 7, 2015 at 3:28 AM, Andrey Tykhonov > wrote: > > I believe this is against the code review guidelines. > &g

Re: [openstack-dev] [Fuel] Patch size limit

2015-12-07 Thread Andrey Tykhonov
On 7 December 2015 at 12:20, Sergii Golovatiuk wrote: > Hi, > > On Mon, Dec 7, 2015 at 2:28 AM, Andrey Tykhonov > wrote: > >> I believe this is against the code review guidelines. >> >> «Comments must be meaningful and should help an author to change the >>

Re: [openstack-dev] [Fuel] Patch size limit

2015-12-06 Thread Andrey Tykhonov
ets us learn much faster by seeing examples.» [2] [1] https://docs.google.com/document/d/1tyKhHQRQqTEW6tS7_LCajEpzqn55f-f5nDmtzIeJ2uY/edit [2] https://wiki.openstack.org/wiki/CodeReviewGuidelines [3] http://www.mail-archive.com/openstack-dev@lists.openstack.org/msg07831.html [4] http://docs.ope