Re: [Openstack] Promoting the role of +1 reviewers in our community

2013-10-30 Thread Sergey Skripnick
++ I consider to change the above to praise the "-1 reviewers" and ask for more ;). The constructive critique given by good -1 review helps with iteration over a patch and getting it in shape - and sharing the load of reviews. ___ Mailing list: htt

Re: [Openstack] Promoting the role of +1 reviewers in our community

2013-10-30 Thread Thierry Carrez
Daniel P. Berrange wrote: > On Wed, Oct 30, 2013 at 10:08:03AM +1100, Tom Fifield wrote: >> [...] >> I think it's time to bend that focus slightly, and promote the role >> of the +1 reviewers. Every review that a non-core reviewer does >> helps reduce the burden of core reviewers just that little b

Re: [Openstack] Promoting the role of +1 reviewers in our community

2013-10-30 Thread Joe Gordon
On Wed, Oct 30, 2013 at 9:31 AM, Daniel P. Berrange wrote: > On Wed, Oct 30, 2013 at 10:08:03AM +1100, Tom Fifield wrote: > > Hi all, > > > > Recently, I did something crazy and got into the "top 10" reviewers > > for OpenStack in a 30/60 day window. Admittedly, this was for > > documentation - w

Re: [Openstack] Promoting the role of +1 reviewers in our community

2013-10-30 Thread Daniel P. Berrange
On Wed, Oct 30, 2013 at 10:08:03AM +1100, Tom Fifield wrote: > Hi all, > > Recently, I did something crazy and got into the "top 10" reviewers > for OpenStack in a 30/60 day window. Admittedly, this was for > documentation - which is quite a bit different than code - but the > experience did give

Re: [Openstack] Promoting the role of +1 reviewers in our community

2013-10-30 Thread Robert Collins
On 30 October 2013 12:08, Tom Fifield wrote: > Hi all, > > Recently, I did something crazy and got into the "top 10" reviewers for > OpenStack in a 30/60 day window. Admittedly, this was for documentation - > which is quite a bit different than code - but the experience did give me a > small wind

Re: [Openstack] Promoting the role of +1 reviewers in our community

2013-10-30 Thread Andreas Jaeger
On 10/30/2013 12:08 AM, Tom Fifield wrote: > Hi all, > > Recently, I did something crazy and got into the "top 10" reviewers for > OpenStack in a 30/60 day window. Admittedly, this was for documentation > - which is quite a bit different than code - but the experience did > give me a small window

Re: [Openstack] Promoting the role of +1 reviewers in our community

2013-10-29 Thread Jeremy Stanley
On 2013-10-30 10:08:03 +1100 (+1100), Tom Fifield wrote: [...] > Do you see this too? Very often, in fact--I was just marveling at it again this morning. Thanks for breaching the subject! > How can we help encourage more +1 reviews? I've been toying with the idea of asking change submitters to s