Re: [Openstack] database migration cleanup

2012-05-03 Thread Trey Morris
uot;John Garbutt" > > To: "Dan Prince" , "Vishvananda Ishaya" < > vishvana...@gmail.com> > > Cc: openstack@lists.launchpad.net > > Sent: Thursday, May 3, 2012 10:56:44 AM > > Subject: RE: [Openstack] database migration cleanup > > > &g

Re: [Openstack] database migration cleanup

2012-05-03 Thread Dan Prince
- Original Message - > From: "John Garbutt" > To: "Dan Prince" , "Vishvananda Ishaya" > > Cc: openstack@lists.launchpad.net > Sent: Thursday, May 3, 2012 10:56:44 AM > Subject: RE: [Openstack] database migration cleanup > > I

Re: [Openstack] database migration cleanup

2012-05-03 Thread John Garbutt
tack@lists.launchpad.net > Subject: Re: [Openstack] database migration cleanup > > > > - Original Message - > > From: "Vishvananda Ishaya" > > To: "Dan Prince" > > Cc: openstack@lists.launchpad.net > > Sent: Thursday, April 26,

Re: [Openstack] database migration cleanup

2012-05-02 Thread Dan Prince
- Original Message - > From: "Vishvananda Ishaya" > To: "Dan Prince" > Cc: openstack@lists.launchpad.net > Sent: Thursday, April 26, 2012 4:14:25 PM > Subject: Re: [Openstack] database migration cleanup > > +1. Might be nice to have

Re: [Openstack] database migration cleanup

2012-05-02 Thread Thierry Carrez
Dan Prince wrote: >>> * Migrations added during Folsom release cycle could be compacted >>> during "E" release cycle. TBD if/when we do the next compaction. >> >> An alternative idea would be to do the compaction *prior* to the >> Folsom relase instead of after, so that the cleanest possible >> m

Re: [Openstack] database migration cleanup

2012-04-30 Thread Johannes Erdfelt
On Mon, Apr 30, 2012, Dan Prince wrote: > The primary benefit here is it is simply less code to maintain: > > The old migrations scripts for Essex are around 6200 lines of code. > > The new compacted migration for Essex is around 950 lines of code. It seems like you're counting raw lines, which

Re: [Openstack] database migration cleanup

2012-04-30 Thread Dan Prince
- Original Message - > From: "Johannes Erdfelt" > To: openstack@lists.launchpad.net > Sent: Friday, April 27, 2012 12:13:47 PM > Subject: Re: [Openstack] database migration cleanup > > On Fri, Apr 27, 2012, Dan Prince wrote: > > > Mirations don&#

Re: [Openstack] database migration cleanup

2012-04-30 Thread Dan Prince
- Original Message - > From: "Monsyne Dragon" > To: "Dan Prince" > Cc: "Sean Dague" , > "" > Sent: Friday, April 27, 2012 1:46:03 PM > Subject: Re: [Openstack] database migration cleanup > > Even better, what would it

Re: [Openstack] database migration cleanup

2012-04-27 Thread Johannes Erdfelt
On Fri, Apr 27, 2012, Monsyne Dragon wrote: > Even better, what would it take to try using Alembic? > (http://alembic.readthedocs.org/en/latest/front.html#project-homepage) > > It's a big improvement over sqlalchemy. Amongst other things, > migrations are not numbered, they are linked by dependa

Re: [Openstack] database migration cleanup

2012-04-27 Thread Monsyne Dragon
pril 27, 2012 10:21:17 AM >> Subject: Re: [Openstack] database migration cleanup >> >> On 04/26/2012 03:24 PM, Dan Prince wrote: >> >>> I think this scheme would support users who follow stable releases >>> as well as users who follow trunk very closely. >>

Re: [Openstack] database migration cleanup

2012-04-27 Thread Johannes Erdfelt
On Fri, Apr 27, 2012, Dan Prince wrote: > > Mirations don't appear to be particularly slow right now, and it > > doesn't > > appear that merging migrations will make them significantly faster. > > > > What exactly is the benefit of doing this? > > Speed wasn't the primary motivation here I suppo

Re: [Openstack] database migration cleanup

2012-04-27 Thread Dan Prince
- Original Message - > From: "Johannes Erdfelt" > To: openstack@lists.launchpad.net > Sent: Friday, April 27, 2012 10:20:38 AM > Subject: Re: [Openstack] database migration cleanup > > On Thu, Apr 26, 2012, Dan Prince wrote: > > The OpenStack Essex

Re: [Openstack] database migration cleanup

2012-04-27 Thread Dan Prince
- Original Message - > From: "Sean Dague" > To: openstack@lists.launchpad.net > Sent: Friday, April 27, 2012 10:21:17 AM > Subject: Re: [Openstack] database migration cleanup > > On 04/26/2012 03:24 PM, Dan Prince wrote: > > > I think this scheme

Re: [Openstack] database migration cleanup

2012-04-27 Thread Sean Dague
On 04/26/2012 03:24 PM, Dan Prince wrote: I think this scheme would support users who follow stable releases as well as users who follow trunk very closely. We talked about this at the conference but I thought this issue might be near and dear to some of our end users so it was worth discussi

Re: [Openstack] database migration cleanup

2012-04-27 Thread Johannes Erdfelt
On Thu, Apr 26, 2012, Dan Prince wrote: > The OpenStack Essex release had 82 database migrations. As these grow > in number it seems reasonable to clean house from time to time. Now > seems as good a time as any. Mirations don't appear to be particularly slow right now, and it doesn't appear that

Re: [Openstack] database migration cleanup

2012-04-27 Thread Dan Prince
- Original Message - > From: "Eoghan Glynn" > To: "Dan Prince" > Cc: openstack@lists.launchpad.net > Sent: Friday, April 27, 2012 5:45:27 AM > Subject: Re: [Openstack] database migration cleanup > > > > > https://review.openstack.o

Re: [Openstack] database migration cleanup

2012-04-27 Thread Eoghan Glynn
> https://review.openstack.org/#/c/6847/ Nice! > * Migrations added during Folsom release cycle could be compacted > during "E" release cycle. TBD if/when we do the next compaction. An alternative idea would be to do the compaction *prior* to the Folsom relase instead of after, so that the c

Re: [Openstack] database migration cleanup

2012-04-27 Thread Thierry Carrez
Vishvananda Ishaya wrote: > +1. Might be nice to have some kind of test to verify that the new migration > leaves the tables in exactly the same state as the old migrations. Sounds like a good way to avoid nasty regressions. And maybe run that test (at least once) over the range of supported dat

Re: [Openstack] database migration cleanup

2012-04-26 Thread Vishvananda Ishaya
+1. Might be nice to have some kind of test to verify that the new migration leaves the tables in exactly the same state as the old migrations. Vish On Apr 26, 2012, at 12:24 PM, Dan Prince wrote: > The OpenStack Essex release had 82 database migrations. As these grow in > number it seems rea

[Openstack] database migration cleanup

2012-04-26 Thread Dan Prince
The OpenStack Essex release had 82 database migrations. As these grow in number it seems reasonable to clean house from time to time. Now seems as good a time as any. I came up with a first go at it here: https://review.openstack.org/#/c/6847/ The idea is that we would: * Do this early in th