[opensource-dev] Review Request: Fix for viewer crash when entering anything but a valid dns-address into the grid selection combo (login screen).

2012-03-06 Thread MartinRJ Fayray
Test plan: Insert a malformed grid dns address (e.g. http://grid.francogrid.org:8002 which works with some TPVs) into the grid selection combo on the login screen. Expected behaviour: a popup shows up, informing about the malformed address, and the grid selection combo swaps back to the default

Re: [opensource-dev] Review Request: VWR-23741: Fix for viewer crash when entering anything but a valid dns-address into the grid selection combo (login screen).

2012-03-06 Thread MartinRJ Fayray
hich works with some TPVs) into the grid selection combo on the login screen. Expected behaviour: a popup shows up, informing about the malformed address, and the grid selection combo swaps back to the default grid (Agni). Thanks, MartinRJ Fayray ___ Policies

Re: [opensource-dev] Review Request: VWR-23741: Fix for viewer crash when entering anything but a valid dns-address into the grid selection combo (login screen).

2012-03-06 Thread MartinRJ Fayray
tion combo on the login screen. Expected behaviour: a popup shows up, informing about the malformed address, and the grid selection combo swaps back to the default grid (Agni). Thanks, MartinRJ Fayray ___ Policies and (un)subscribe information availab

Re: [opensource-dev] Review Request: STORM-1818: Fix for viewer crash when entering chars other than [a-z0-9-_. ] into the grid-selection combo.

2012-03-24 Thread MartinRJ Fayray
en. Expected behaviour: a popup shows up, informing about the malformed address, and the grid selection combo swaps back to the default grid (Agni). Thanks, MartinRJ Fayray ___ Policies and (un)subscribe information available here: http://wiki.secondlife

Re: [opensource-dev] Review Request: STORM-1818: Fix for viewer crash when entering chars other than [a-z0-9-_. ] into the grid-selection combo.

2012-03-24 Thread MartinRJ Fayray
------- On March 24, 2012, 5:33 a.m., MartinRJ Fayray wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/563/ > --

Re: [opensource-dev] Review Request: STORM-1818: Fix for viewer crash when entering chars other than [a-z0-9-_. ] into the grid-selection combo.

2012-03-24 Thread MartinRJ Fayray
view.secondlife.com/r/563/#review1179 --- On March 24, 2012, 5:33 a.m., MartinRJ Fayray wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: [opensource-dev] Review Request: STORM-1818: Fix for viewer crash when entering chars other than [a-z0-9-_. ] into the grid-selection combo.

2012-03-25 Thread MartinRJ Fayray
This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/563/#review1184 --- On March 24, 2012, 5:33 a.m., MartinRJ Fayray wrote: > > --

Re: [opensource-dev] Review Request: STORM-1818: Fix for viewer crash when entering chars other than [a-z0-9-_. ] into the grid-selection combo.

2012-03-25 Thread MartinRJ Fayray
---- On March 24, 2012, 5:33 a.m., MartinRJ Fayray wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/563/ >

[opensource-dev] Review Request: STORM-1845: Move "Show HUD Attachments" (Alt+Shift+H) from Advanced-> "Highlighting and Visibility" to Me - menu

2012-06-04 Thread MartinRJ Fayray
option to enable/disable the visibility of HUD attachments to the Me- menu. This addresses bug STORM-1845. Diffs - indra/newview/skins/default/xui/en/menu_viewer.xml 29143d1fc6fa Diff: http://codereview.secondlife.com/r/582/diff/diff Testing --- Thanks, MartinRJ Fayray

[opensource-dev] Review Request: STORM-1844: Block and Ignore buttons on llDialog() menus overlap when there is only one button

2012-06-18 Thread MartinRJ Fayray
uot; This addresses bug STORM-1844. Diffs - indra/newview/lltoastnotifypanel.cpp 29143d1fc6fa Diff: http://codereview.secondlife.com/r/585/diff/diff Testing --- Testing repository: https://bitbucket.org/MartinRJ/storm-1844 Looking for feedback! Thanks, MartinRJ Fayray __

Re: [opensource-dev] Review Request: STORM-1878: Blocking an avatar does not derender worn lights

2012-06-18 Thread MartinRJ Fayray
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/583/#review1230 ------- On June 18, 2012, 11:04 a.m., MartinRJ Fayray wrote: > > --

Re: [opensource-dev] Review Request: STORM-1892 - Add Apply button to the edit content permission floater

2012-06-23 Thread MartinRJ Fayray
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/587/#review1236 --- Ship it! Ship It! - MartinRJ Fayray On June 23, 2012, 4:34

[opensource-dev] Review Request: STORM-1879: Inventory gear menu remains on screen after floater is closed

2012-06-24 Thread MartinRJ Fayray
7 indra/llui/lltoggleablemenu.cpp 4d9106153407 Diff: http://codereview.secondlife.com/r/588/diff/diff Testing --- See test plan in JIRA: https://jira.secondlife.com/browse/STORM-1879 Thanks, MartinRJ Fayray ___ Policies and (un)subscribe i

Re: [opensource-dev] Review Request: STORM-1879: Inventory gear menu remains on screen after floater is closed

2012-06-25 Thread MartinRJ Fayray
https://jira.secondlife.com/browse/STORM-1879 Diffs (updated) - indra/llui/llfloater.cpp 4d9106153407 indra/llui/lltoggleablemenu.cpp 4d9106153407 Diff: http://codereview.secondlife.com/r/588/diff/diff Testing --- See test plan in JIRA: https://jira.secondlife.com/browse/STORM-1879 Thanks,

[opensource-dev] Review Request: STORM-1893: 'share' function (in friends-list) doesn't bring up the residents' IM window when it's minimized

2012-07-02 Thread MartinRJ Fayray
wview/llavataractions.cpp 4d9106153407 Diff: http://codereview.secondlife.com/r/589/diff/diff Testing --- Please see the test plan in the Jira. Thanks, MartinRJ Fayray ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com

Re: [opensource-dev] Review Request: STORM-1893: 'share' function (in friends-list) doesn't bring up the residents' IM window when it's minimized

2012-09-07 Thread MartinRJ Fayray
-1893. https://jira.secondlife.com/browse/STORM-1893 Diffs (updated) - doc/contributions.txt 7ae099f5a764 indra/newview/llavataractions.cpp 7ae099f5a764 Diff: http://codereview.secondlife.com/r/589/diff/diff Testing --- Please see the test plan in the Jira. Thanks, MartinRJ F

[opensource-dev] Review Request: BUG-59: Go-to line function for the internal LSL script editor

2012-09-11 Thread MartinRJ Fayray
go to menu 'Edit-> go to line', enter a number less than 300 into the 'Go to' - field. Expected result: the cursor jumps to the entered line number (column 0). Repeat the test with a script inside an object's content. Thanks, MartinRJ Fayray

Re: [opensource-dev] Review Request: BUG-59: Go-to line function for the internal LSL script editor

2012-09-11 Thread MartinRJ Fayray
ply, visit: http://codereview.secondlife.com/r/596/#review1251 ------- On Sept. 11, 2012, 2:39 a.m., MartinRJ Fayray wrote: > > --- > This is an automatically gene

Re: [opensource-dev] Review Request: Added a UI field to display group count in the groups floater, plus code to update it. This adresses BUG-81.

2012-09-12 Thread MartinRJ Fayray
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/598/#review1255 --- Ship it! Ship It! - MartinRJ Fayray On Sept. 12, 2012, 1:29

Re: [opensource-dev] Review Request: Added a UI field to display group count in the groups floater, plus code to update it. This adresses BUG-81.

2012-09-12 Thread MartinRJ Fayray
> On Sept. 12, 2012, 11:24 p.m., MartinRJ Fayray wrote: > > Ship It! Just tested with a modded 3.4.0 viewer-release (from revision 7a056d7afeb2 - https://bitbucket.org/lindenlab/viewer-release/changeset/7a056d7afeb246435e31d06cee2a9a85eac82476). Works as expected. Ship it! -

Re: [opensource-dev] Review Request: BUG-59: Go-to line function for the internal LSL script editor

2012-09-13 Thread MartinRJ Fayray
than 300 into the 'Go to' - field. Expected result: the cursor jumps to the entered line number (column 0). Repeat the test with a script inside an object's content. Thanks, MartinRJ Fayray ___ Policies and (un)subscribe information avai

Re: [opensource-dev] Review Request: BUG-59: Go-to line function for the internal LSL script editor

2012-09-13 Thread MartinRJ Fayray
with at least 300 lines inside inventory, go to menu 'Edit-> go to line', enter a number less than 300 into the 'Go to' - field. Expected result: the cursor jumps to the entered line number (column 0). Repeat the test with a script i

Re: [opensource-dev] Review Request: BUG-59: Go-to line function for the internal LSL script editor

2012-09-13 Thread MartinRJ Fayray
ult: the cursor jumps to the entered line number (column 0). Repeat the test with a script inside an object's content. Thanks, MartinRJ Fayray ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Plea

Re: [opensource-dev] Review Request: BUG-59: Go-to line function for the internal LSL script editor

2012-09-18 Thread MartinRJ Fayray
th at least 300 lines inside inventory, go to menu 'Edit-> go to line', enter a number less than 300 into the 'Go to' - field. Expected result: the cursor jumps to the entered line number (column 0). Repeat the test with a script inside an object's content. Thanks,

Re: [opensource-dev] Review Request: BUG-59: Go-to line function for the internal LSL script editor

2012-09-18 Thread MartinRJ Fayray
go to line', enter a number less than 300 into the 'Go to' - field. Expected result: the cursor jumps to the entered line number (column 0). Repeat the test with a script inside an object's content. Thanks, MartinRJ Fayray ___ P

Re: [opensource-dev] Review Request: STORM-1911: Go-to line function for the internal LSL script editor

2012-09-19 Thread MartinRJ Fayray
t; version. Open a script with at least 300 lines inside inventory, go to menu 'Edit-> go to line', enter a number less than 300 into the 'Go to' - field. Expected result: the cursor jumps to the entered line number (column 0). Repeat the test with a script i

[opensource-dev] Review Request: BUG-540: Math updates by Moon Metty. Reviewed by Chieron Tenk.

2012-10-24 Thread MartinRJ Fayray
https://jira.secondlife.com/browse/BUG-540 Thanks, MartinRJ Fayray ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: BUG-540: Math updates by Moon Metty. Reviewed by Chieron Tenk.

2012-10-24 Thread MartinRJ Fayray
indra/llmath/llquaternion.h f32c39fdfcfe indra/llmath/llquaternion.cpp f32c39fdfcfe indra/llmath/v3math.h f32c39fdfcfe Diff: http://codereview.secondlife.com/r/606/diff/ Testing --- Please go to https://jira.secondlife.com/browse/BUG-540 Thanks, MartinRJ Fayray

[opensource-dev] Review Request: BUG-840: Viewer 3.4.2 (Beta) breaks almost every sliding door script in SL

2013-02-15 Thread MartinRJ Fayray
e its position (or rotation). Thanks, MartinRJ Fayray ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: BUG-840: Viewer 3.4.2 (Beta) breaks almost every sliding door script in SL

2013-02-15 Thread MartinRJ Fayray
are "left behind" by animated, moving (physical) linksets. I'm looking for a solution. - MartinRJ Fayray On Feb. 15, 2013, 1:54 a.m., MartinRJ Fayray wrote: > > --- > This is an automatically generated e-mail.

Re: [opensource-dev] Review Request: BUG-840: Viewer 3.4.2 (Beta) breaks almost every sliding door script in SL

2013-02-16 Thread MartinRJ Fayray
ot; by animated, moving physical objects MAINT-1742 [selection], Child object does not update position while selected. MAINT-2247 [selection] Child object does not update rotation while selected. Thanks, MartinRJ Fayray ___ Policies and (un)subscr

Re: [opensource-dev] Review Request: BUG-840: Viewer 3.4.2 (Beta) breaks almost every sliding door script in SL

2013-02-16 Thread MartinRJ Fayray
) breaks almost every sliding door script in SL MAINT-2275 [vehiclebug], Child prims are "left behind" by animated, moving physical objects MAINT-1742 [selection], Child object does not update position while selected. MAINT-2247 [selection] Child object does not update rotation while sele

Re: [opensource-dev] Review Request: BUG-840: Viewer 3.4.2 (Beta) breaks almost every sliding door script in SL

2013-02-16 Thread MartinRJ Fayray
Child prims are "left behind" by animated, moving physical objects MAINT-1742 [selection], Child object does not update position while selected. MAINT-2247 [selection] Child object does not update rotation while selected. Thanks,

[opensource-dev] Review Request: BUG-1709: Tiny prims do not rescale properly at very high viewer framerates

2013-02-17 Thread MartinRJ Fayray
com/browse/BUG-1709 Thanks, MartinRJ Fayray ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: BUG-1709: Tiny prims do not rescale properly at very high viewer framerates

2013-02-17 Thread MartinRJ Fayray
See test plan in Jira: https://jira.secondlife.com/browse/BUG-1709 Repository: https://bitbucket.org/MartinRJ/bug-1709 Thanks, MartinRJ Fayray ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev P

Re: [opensource-dev] Review Request: BUG-1709: Tiny prims do not rescale properly at very high viewer framerates

2013-02-25 Thread MartinRJ Fayray
- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/617/#review1301 ------- On Feb. 17, 2013, 7:02 p.m., MartinRJ Fayray wrote: > > ---