Re: [opensource-dev] Review Request: CHOP-624 header dependency improvements for build time speedup

2011-05-09 Thread Brad Kittenbrink
> On May 6, 2011, 3:19 a.m., Boroondas Gupte wrote: > > indra/newview/llviewerregion.cpp, lines 833-839 > > > > > > > on further thought, is this a bug? > > > should it be 0.5 * (mImpl->mLandp->getMinZ() + > > mIm

[opensource-dev] STORM-859 or "#define IDC_STATIC and stop #include(ing) old sample code"

2011-05-09 Thread Ardy Lay
Seems to me we should keep them ducks all in a row like this: #define IDC_STATIC and stop #include(ing) old sample code diff -r d596dec15189 -r 6574bf647d32 indra/newview/res/resource.h --- a/indra/newview/res/resource.hMon May 09 14:39:23 2011 -0500 +++ b/indra/newview/res/resource.hMon

[opensource-dev] Review Request: Cleaning up testing cmake macros to prepare for refactoring them to improve build time.

2011-05-09 Thread Brad Kittenbrink
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/301/ --- Review request for Viewer. Summary --- Consolidating all references to

[opensource-dev] Review Request: CHOP-658 moving panels and floaters into a new static library project viewer_components/viewerui

2011-05-09 Thread Brad Kittenbrink
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/302/ --- Review request for Viewer and Richard Nelson. Summary --- Started movi