Re: [opensource-dev] Review Request: CHOP-629 symbol information for llcommon.dll is missing both in the debugger and in crash reports

2011-04-27 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/281/#review653 --- indra/llcommon/CMakeLists.txt

Re: [opensource-dev] Review Request: VWR-25608 error on shutdown due to buffer overrun in LLVFS::audit

2011-04-27 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/278/#review654 --- indra/llvfs/llvfs.cpp

Re: [opensource-dev] Review Request: VWR-25610 LLControlGroup::loadFromFile makes unnecessary copies of large LLSD objects

2011-04-27 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/280/#review655 --- Ship it! The nice thing about this change is that is has to be co

[opensource-dev] Request for comment on these JIRA reports

2011-04-27 Thread Opensource Obscure
Here are a few JIRA issues I recently focused on where a comment from LL would be much appreciated. * https://jira.secondlife.com/browse/SVC-2283 Sending postcards severely slows simulator performance - this issue should be closed (but I can't) * https://jira.secondlife.com/browse/VWR-25506 Inve

Re: [opensource-dev] Request for comment on these JIRA reports

2011-04-27 Thread Andrew Meadows
Opensource - I don't know about the other issues, but the two postcard problems are on my team's short list for the next two weeks, along with a bunch of other stuff. I closed SVC-2283 but left the internal issue open with a comment suggesting that we at least take a swing at reproducing it and o

Re: [opensource-dev] Request for comment on these JIRA reports

2011-04-27 Thread Joshua Bell
On Wed, Apr 27, 2011 at 6:41 AM, Opensource Obscure < opensourceobsc...@gmail.com> wrote: > > * https://jira.secondlife.com/browse/SVC-5387 > Snapshot to postcard failure > - how to provide more helpful feedback? > Sorry for not catching up with you in-world on this one, OO. (And sorry for the d

Re: [opensource-dev] Review Request: CHOP-629 symbol information for llcommon.dll is missing both in the debugger and in crash reports

2011-04-27 Thread Brad Kittenbrink
> On April 27, 2011, 2:16 a.m., Boroondas Gupte wrote: > > indra/llcommon/CMakeLists.txt, lines 262-278 > > > > > > Naive question: Is there a reason not to add /DEBUG also when NOT > > LLCOMMON_LINK_SHARED? The /DEB

Re: [opensource-dev] Review Request: CHOP-629 symbol information for llcommon.dll is missing both in the debugger and in crash reports

2011-04-27 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/281/#review657 --- Ship it! >The /DEBUG linker flag doesn't really apply for sta

Re: [opensource-dev] Review Request: VWR-25608 error on shutdown due to buffer overrun in LLVFS::audit

2011-04-27 Thread Brad Kittenbrink
> On April 27, 2011, 3:30 a.m., Boroondas Gupte wrote: > > indra/llvfs/llvfs.cpp, lines 1716-1717 > > > > > > When index_size == 0, wouldn't it be more appropriate to skip the steps > > that require taking the addres

Re: [opensource-dev] Review Request: VWR-25610 LLControlGroup::loadFromFile makes unnecessary copies of large LLSD objects

2011-04-27 Thread Brad Kittenbrink
> On April 27, 2011, 4:16 a.m., Boroondas Gupte wrote: > > indra/llxml/llcontrol.cpp, lines 866-867 > > > > > > 1) Any reason not to do the same for name? > > 2) Remove space between "const" and "&", so that it's e

Re: [opensource-dev] Review Request: VWR-25608 error on shutdown due to buffer overrun in LLVFS::audit

2011-04-27 Thread Boroondas Gupte
> On April 27, 2011, 3:30 a.m., Boroondas Gupte wrote: > > indra/llvfs/llvfs.cpp, lines 1716-1717 > > > > > > When index_size == 0, wouldn't it be more appropriate to skip the steps > > that require taking the addres

Re: [opensource-dev] Review Request: VWR-25608 error on shutdown due to buffer overrun in LLVFS::audit

2011-04-27 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/278/#review661 --- Ship it! Ready to rock! - Boroondas On April 26, 2011, 5:31 p.

Re: [opensource-dev] Review Request: VWR-25610 LLControlGroup::loadFromFile makes unnecessary copies of large LLSD objects

2011-04-27 Thread Monty Brandenberg
On 4/27/2011 2:57 PM, Brad Kittenbrink wrote: > On April 27th, 2011, 4:16 a.m., *Boroondas Gupte* wrote: > 2) Remove space between"const" and"&", so that it's easer to > visually distinguish from binary operator& > 2) I think this is a bad idea, that would be far less readable imho.

Re: [opensource-dev] OpenID based logins?

2011-04-27 Thread Dave Booth
DO NOT WANT. My OpenID is linked to several RL sites that I want to have nothing to do with my SL. OpenID has already been pre-empted by 1L or RL links. If it were 100% opt-in and guaranteed to never ever link to SL without explicit consent I'd support it because I know theres SLers out there

Re: [opensource-dev] OpenID based logins?

2011-04-27 Thread Kadah
How about fixing the openID issues with jira before that? I would like to be able to keep issues open within my browser without openID reseting every tab the dashboard and forcing their history's to the openID process page. Monty and Oz said this was a known issue. And I'm also against linking SL

Re: [opensource-dev] Request for comment on these JIRA reports (Opensource Obscure)

2011-04-27 Thread Hitomi Tiponi
It was good to see some quick responses to the queries made by OO. With so much work on Viewer 2 now being carried out by teams other than Snowstorm would it be possible to produce a list of tasks being carried out? Clearly if you are planning a 'wow' feature you may want to omit that, but it

Re: [opensource-dev] OpenID based logins?

2011-04-27 Thread Yoz Grahame
On 28 April 2011 01:34, Kadah wrote: > How about fixing the openID issues with jira before that? I would like > to be able to keep issues open within my browser without openID reseting > every tab the dashboard and forcing their history's to the openID > process page. > Monty and Oz said this was

[opensource-dev] Fw: tornado hit my place

2011-04-27 Thread Nicky Perian
- Forwarded Message From: Nicky Perian To: molliescarbri...@yahoo.com; Imprudence Dev List Sent: Wed, April 27, 2011 8:22:15 PM Subject: tornado hit my place will be off lists and irc for next week or so. ___ Policies and (un)subscribe i

Re: [opensource-dev] OpenID based logins?

2011-04-27 Thread Kadah
On 4/27/2011 5:25 PM, Yoz Grahame wrote: > > On 28 April 2011 01:34, Kadah > wrote: > > How about fixing the openID issues with jira before that? I would like > to be able to keep issues open within my browser without openID reseting > every tab the dashb