Re: [opensource-dev] Review Request: OPEN-38: autobuild support for StandAlone

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/167/#review391 --- Ship it! Ah, with that, configuration succeeds and GLH_INCLUDE_DI

Re: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/153/#review392 --- Ship it! indra/llcommon/llavatarname.cpp

Re: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

> On Feb. 27, 2011, 5:57 a.m., Boroondas Gupte wrote: > > indra/llcommon/llavatarname.cpp, lines 93-108 > > > > > > This could be shortened to > > > > if (!mUsername.empty() && !mIsDisplayNameDefault) > >

Re: [opensource-dev] Review Request: OPEN-38: autobuild support for StandAlone

On Feb. 27, 2011, 3:47 a.m., Aleric Inglewood wrote: > > Building still fails for me, with > > > > Linking CXX shared library libllcommon.so > > /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: > > skipping incompatible > > /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/.

Re: [opensource-dev] Review Request: OPEN-38: autobuild support for StandAlone

> On Feb. 27, 2011, 3:47 a.m., Boroondas Gupte wrote: > > Ah, with that, configuration succeeds and GLH_INCLUDE_DIR gets correctly > > set to the dir with the symlinks. Could the need for that symlink dir be > > avoided by having the user directly set the GLH_INCLUDE_DIR CMake variable? There

Re: [opensource-dev] Review Request: OPEN-38: autobuild support for StandAlone

> On Feb. 27, 2011, 3:47 a.m., Boroondas Gupte wrote: > > indra/cmake/Linking.cmake, lines 6-20 > > > > > > I thought the removal of the NOT STANDALONE condition here would give > > standalone the same (repository-local)