Re: [opensource-dev] Review Request: Changes to fix CHOP-662.

2011-06-22 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/357/#review809 --- doc/contributions.txt

Re: [opensource-dev] Review Request: Changes to fix CHOP-662.

2011-06-21 Thread Seth ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/357/#review803 --- Ship it! The glob to regex conversion was not initially supposed

Re: [opensource-dev] Review Request: Changes to fix CHOP-662.

2011-06-21 Thread Seth ProductEngine
> On June 21, 2011, 7:57 a.m., Alain Linden wrote: > > indra/llvfs/tests/lldiriterator_test.cpp, line 46 > > > > > > Personally, I dislike referencing jira items in code comments. Its > > referencing something ephemer

Re: [opensource-dev] Review Request: Changes to fix CHOP-662.

2011-06-21 Thread Alain Linden
> On June 21, 2011, 7:57 a.m., Alain Linden wrote: > > indra/llvfs/tests/lldiriterator_test.cpp, line 46 > > > > > > Personally, I dislike referencing jira items in code comments. Its > > referencing something ephemer

Re: [opensource-dev] Review Request: Changes to fix CHOP-662.

2011-06-21 Thread Boroondas Gupte
> On June 21, 2011, 7:57 a.m., Alain Linden wrote: > > indra/llvfs/tests/lldiriterator_test.cpp, line 46 > > > > > > Personally, I dislike referencing jira items in code comments. Its > > referencing something ephemer

Re: [opensource-dev] Review Request: Changes to fix CHOP-662.

2011-06-21 Thread Alain Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/357/#review795 --- Ship it! indra/llvfs/tests/lldiriterator_test.cpp

Re: [opensource-dev] Review Request: Changes to fix CHOP-662.

2011-06-21 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/357/#review788 --- doc/contributions.txt