Re: [opensource-dev] Second Pair of eyes needed!

2010-09-01 Thread Mike Monkowski
You're half right :-) Change the other "LLFILE* fptr =" to "fptr =" as well. Mike Tiggs Linden wrote: > You're shadowing fptr in the last if clause: > if (!fptr) >{ >LLFILE* fptr = LLFile::fopen(oldLogFileName(filename), > "r");/*Flawfinder: ignore*/ >

Re: [opensource-dev] Second Pair of eyes needed!

2010-08-31 Thread Tiggs Linden
You're shadowing fptr in the last if clause:   if (!fptr)        {                LLFILE* fptr = LLFile::fopen(oldLogFileName(filename), "r");/*Flawfinder: ignore*/        LL_INFOS("") << "Old    :" << file_name << LL_ENDL;                if (!fptr)                {                    

[opensource-dev] Second Pair of eyes needed!

2010-08-31 Thread WolfPup Lowenhar
Sorry folks as this might get a little long. First Code Snip its: 1. see http://jira.secondlife.com/browse/VWR-20741 for reference to new makeLofFileName in patch 2. std::string LLLogChat::oldLogFileName(std::string filename) { time_t now; time_t yesterday = time(&now) - 86400;