Re: [opensource-dev] Review Request: patch potential memory leak in llgl.h

2012-09-21 Thread Boroondas Gupte
- Boroondas --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/603/#review1268 --- On Sept. 20, 2012, 6:15 p.m., Gistya Eusebio wrote

Re: [opensource-dev] Review Request: patch potential memory leak in llgl.h

2012-09-21 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/603/#review1270 --- indra/llrender/llgl.h

Re: [opensource-dev] Review Request: patch potential memory leak in llgl.h

2012-09-20 Thread Gistya Eusebio
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/603/ --- (Updated Sept. 20, 2012, 6:15 p.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: patch potential memory leak in llgl.h

2012-09-20 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/603/#review1268 --- What Carlo said: indra/llrender/llgl.h

Re: [opensource-dev] Review Request: patch potential memory leak in llgl.h

2012-09-20 Thread Carlo Wood
On Thu, 20 Sep 2012 07:08:11 - "Gistya Eusebio" wrote: > > > > On Sept. 19, 2012, 2:12 p.m., Aleric Inglewood wrote: > > > There is semi-colon where it doesn't belong. Otherwise ok > > > (Singularity has this patch since a long time). > > Oh really, where? It compiled and ran fine on my ma

Re: [opensource-dev] Review Request: patch potential memory leak in llgl.h

2012-09-20 Thread Gistya Eusebio
> On Sept. 19, 2012, 2:12 p.m., Aleric Inglewood wrote: > > There is semi-colon where it doesn't belong. Otherwise ok (Singularity has > > this patch since a long time). Oh really, where? It compiled and ran fine on my machine. - Gistya --

Re: [opensource-dev] Review Request: patch potential memory leak in llgl.h

2012-09-19 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/603/#review1265 --- There is semi-colon where it doesn't belong. Otherwise ok (Singul

[opensource-dev] Review Request: patch potential memory leak in llgl.h

2012-09-19 Thread gistya eusebio
This is an automatically generated e-mail. To reply, visit:http://codereview.secondlife.com/r/603/ Review request for Viewer. By Gistya Eusebio. Description In llvertexbuffer.cpp we call: delete mFence; mFence is an instance of class LLGLSyncFence which is a sub-class of LLGLFence, which is de