---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/100/#review429
---
Ship it!
Perfect.
- Aleric
On March 7, 2011, 3:51 p.m., Boroon
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/100/
---
(Updated March 7, 2011, 3:51 p.m.)
Review request for Viewer and Seth Produ
> On Feb. 3, 2011, 6:35 p.m., Aleric Inglewood wrote:
> >
>
> Aleric Inglewood wrote:
> Can this patch please be added to viewer-development? It's getting really
> annoying that I have to apply patches to the soruce tree before it even can
> compile cleanly :(.
Maybe the hack from
https:
On 2011-02-03 21:36, Aleric Inglewood wrote:
>
> Can this patch please be added to viewer-development? It's getting really
> annoying that I have to apply patches to the soruce tree before it even can
> compile cleanly :(.
Adding comments merely to complain about progress or lack thereof is not
> On Feb. 3, 2011, 6:35 p.m., Aleric Inglewood wrote:
> >
Can this patch please be added to viewer-development? It's getting really
annoying that I have to apply patches to the soruce tree before it even can
compile cleanly :(.
- Aleric
-
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/100/#review321
---
- Aleric
On Jan. 22, 2011, 7:40 a.m., Boroondas Gupte wrote:
>
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/100/#review259
---
I'm ok with changing declarations of some pointers to _PREHASH_ st
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/100/#review248
---
Given that Boroondas reports that the message.cpp in the viewer so
> On Jan. 24, 2011, 6:42 a.m., Oz Linden wrote:
> > If the file is generated, what is it doing checked into the source tree at
> > all? This sounds to me like an invitation to future errors.
> >
> > Is there some reason why we should not just delete the checked in version
> > and have it gene
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/100/#review246
---
If the file is generated, what is it doing checked into the source
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/100/#review245
---
Ship it!
Latest diff looks good. Great that you found the generat
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/100/
---
(Updated Jan. 22, 2011, 7:40 a.m.)
Review request for Viewer and Seth Produ
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/100/#review244
---
As already mentioned in the review request description, comments i
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/100/#review243
---
Ship it!
Not a fan of widespread cleanup changes as I said in a p
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/100/
---
(Updated Jan. 20, 2011, 2:57 p.m.)
Review request for Viewer and Seth Produ
On Jan. 20, 2011, 3:54 a.m., Boroondas Gupte wrote:
> > I agree though, that we should try to handle this similarly in both tests,
> > if possible. So I tried setting the pointers in
> > indra/llui/tests/llurlentry_stub.cpp to NULL, too, which works nicely.
> >
> > However, I then realized tha
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/100/#review207
---
> Just one remark. In one test _PREHASH_AgentID is set to "AgentID
> On Jan. 18, 2011, 5:58 p.m., Aleric Inglewood wrote:
> > I love it! Thanks, this was stopped me from compiling the tests (since some
> > commit not long ago I guess, because I could before).
> > Just one remark. In one test _PREHASH_AgentID is set to "AgentID" (no doubt
> > a place holder), w
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/100/#review196
---
Ship it!
I love it! Thanks, this was stopped me from compiling th
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/100/
---
Review request for Viewer.
Summary
---
For the reason for this change,
20 matches
Mail list logo
