Re: [opensource-dev] Review Request: VWR-29083 Make SSAO work better

2013-01-11 Thread Celierra Darling
> On Dec. 2, 2012, 9:23 a.m., Celierra Darling wrote: > > indra/newview/app_settings/shaders/class2/deferred/sunLightSSAOF.glsl, line > > 132 > > > > > > Out of curiosity, why a minimum, instead of ex. "(angrel>0) ? d

Re: [opensource-dev] Review Request: VWR-29083 Make SSAO work better

2013-01-11 Thread Celierra Darling
> On Dec. 2, 2012, 9:23 a.m., Celierra Darling wrote: > > indra/newview/app_settings/settings.xml, line 7823 > > > > > > I still think it might be valuable to attenuate (HSV) saturation, but > > since it'd been stuck

Re: [opensource-dev] Review Request: VWR-29083 Make SSAO work better

2013-01-11 Thread Tofu Buzzard
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/612/ --- (Updated Jan. 11, 2013, 1:34 p.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: VWR-29083 Make SSAO work better

2013-01-11 Thread Tofu Buzzard
> On Dec. 2, 2012, 9:23 a.m., Celierra Darling wrote: > > indra/newview/app_settings/shaders/class2/deferred/sunLightSSAOF.glsl, line > > 127 > > > > > > The 'if' here might be problematic.. I remember some cards were

Re: [opensource-dev] Review Request: VWR-29083 Make SSAO work better

2013-01-11 Thread Tofu Buzzard
> On Dec. 2, 2012, 9:23 a.m., Celierra Darling wrote: > > indra/newview/app_settings/shaders/class2/deferred/sunLightSSAOF.glsl, line > > 127 > > > > > > The 'if' here might be problematic.. I remember some cards were

Re: [opensource-dev] Review Request: VWR-29083 Make SSAO work better

2013-01-11 Thread Tofu Buzzard
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/612/ --- (Updated Jan. 11, 2013, 1:22 p.m.) Review request for Viewer. Description

Re: [opensource-dev] Review Request: VWR-29083 Make SSAO work better

2013-01-11 Thread Tofu Buzzard
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/612/ --- (Updated Jan. 11, 2013, 1:16 p.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: VWR-29083 Make SSAO work better

2013-01-11 Thread Geenz Spad
> On Dec. 2, 2012, 9:23 a.m., Celierra Darling wrote: > > indra/newview/app_settings/shaders/class2/deferred/sunLightSSAOF.glsl, line > > 127 > > > > > > The 'if' here might be problematic.. I remember some cards were

Re: [opensource-dev] Review Request: VWR-29083 Make SSAO work better

2013-01-11 Thread Tofu Buzzard
> On Dec. 2, 2012, 9:23 a.m., Celierra Darling wrote: > > indra/newview/app_settings/settings.xml, line 7823 > > > > > > I still think it might be valuable to attenuate (HSV) saturation, but > > since it'd been stuck

Re: [opensource-dev] Review Request: VWR-29083 Make SSAO work better

2012-12-02 Thread Celierra Darling
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/612/#review1288 --- Hey Tofu! :3 indra/newview/app_settings/settings.xml

[opensource-dev] Review Request: VWR-29083 Make SSAO work better

2012-12-02 Thread Tofu Buzzard
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/612/ --- Review request for Viewer. Description --- Use a different scheme for