Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/365/#review862 --- Diff r4 looks broken to me. And yes, a clean fork would be nice.

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

> On June 30, 2011, 9:29 a.m., Vadim ProductEngine wrote: > > indra/newview/llpanelpermissions.cpp, line 1027 > > > > > > CS: check_purchase or better check_purchase_cb > > Kadah Coba wrote: > Same name is used

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/365/ --- (Updated June 30, 2011, 10:33 a.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

> On June 30, 2011, 9:29 a.m., Vadim ProductEngine wrote: > > indra/newview/llpanelpermissions.cpp, line 1027 > > > > > > CS: check_purchase or better check_purchase_cb Same name is used else where in the legacy co

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/365/#review831 --- Ship it! Fine with me. Although, if you correct the cosmetic issu

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/365/ --- (Updated June 29, 2011, 4:54 p.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

> On June 29, 2011, 6:37 a.m., Vadim ProductEngine wrote: > > indra/newview/llpanelpermissions.cpp, line 245 > > > > > > Coding standard: rewrite as btn_mark_for_sale. Will do. As far as the XUI names, is there a stan

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

> On June 29, 2011, 6:41 a.m., Oz Linden wrote: > > indra/newview/llpanelpermissions.cpp, lines 477-480 > > > > > > There's nothing else inside this 'else if' - why not add the check of > > update_sale_info to this st

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/365/#review824 --- Just a couple of minor items to address and this looks good. rem

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/365/#review825 --- Looking good overall. Please fix the minor issues. indra/newview

[opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/365/ --- Review request for Viewer. Summary --- This change makes it so setting