Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

> On 2010-12-24 13:25:16, Aleric Inglewood wrote: > > I'm going to respectfully disagree with Aleric on one minor style point. When comparing equality between a literal or constant and a variable, putting the constant value has an advantage: it avoids the "=" vs "==" error: if (FOO_LIMIT ==

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

> On 2010-12-24 13:25:16, Aleric Inglewood wrote: > > indra/newview/llpanelmaininventory.cpp, line 948 > > > > > > While you're removing that empty line anyway, I thought I'd help you to > > not learn the bad coding habb

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

> On 2010-12-24 15:30:55, Jonathan Yap wrote: > > indra/newview/llpanelmaininventory.cpp, line 948 > > > > > > I updated the code per Aleric's suggestion but the 2nd diff failed to > > upload. There must be some unusual

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

> On 2010-12-24 10:55:28, Vadim ProductEngine wrote: > > indra/newview/llpanelmaininventory.cpp, line 509 > > > > > > This line can now be removed at all. > > Jonathan Yap wrote: > Line 509 on the left is removed; it

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

I still not sure about this myself, but I believe the magic is as follows: The diff file has the format: diff -r b0689af42a71 indra/cmake/LLAddBuildTest.cmake --- a/indra/cmake/LLAddBuildTest.cmake Wed Dec 15 22:44:21 2010 +0100 +++ b/indra/cmake/LLAddBuildTest.cmake Sun Dec 19 16:06:01 2010 +0

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/65/#review89 --- indra/newview/llpanelmaininventory.cpp

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/65/#review88 --- indra/newview/llpanelmaininventory.cpp

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

> On 2010-12-24 10:55:28, Vadim ProductEngine wrote: > > indra/newview/llpanelmaininventory.cpp, line 509 > > > > > > This line can now be removed at all. Line 509 on the left is removed; it might be that the diff displa

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/65/#review85 --- Seems plausible. indra/newview/llpanelmaininventory.cpp

[opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/65/ --- Review request for Viewer. Summary --- This change enables the "+" menu