Re: [opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/63/ --- (Updated 2010-12-28 22:45:28.345670) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/63/#review94 --- Thanks, Merov. I have no more objections. indra/llimagej2coj/llima

Re: [opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/63/ --- (Updated 2010-12-24 11:46:22.693285) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

> On 2010-12-23 17:29:10, Aleric Inglewood wrote: > > indra/llkdu/llimagej2ckdu.h, line 58 > > > > > > This feels wrong. Those functions are implementations of the base class > > interface, they are called by the base cla

Re: [opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/63/#review78 --- Huh - I wrote this a long time ago (before the others commented)...

Re: [opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

> On 2010-12-23 06:46:09, Vadim ProductEngine wrote: > > indra/llkdu/tests/llimagej2ckdu_test.cpp, line 193 > > > > > > What about calling protected methods via inheritance? IIRC the tut framework (used to create unit te

Re: [opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

> On 2010-12-23 06:46:09, Vadim ProductEngine wrote: > > indra/llkdu/llimagej2ckdu.h, line 58 > > > > > > Please add a comment that these methods aren't actually public, i.e. > > were made public only to be called from un

Re: [opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/63/#review79 --- Ship it! No reason not to submit. :-) indra/llkdu/llimagej2ckdu.h

[opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/63/ --- Review request for Viewer. Summary --- Unit tests addition: - add tests

Re: [opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/62/#review70 --- I don't think there should be any change in indra/llcommon/llversion

Re: [opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/62/ --- (Updated 2010-12-22 23:45:57.202290) Review request for Viewer. Changes --

[opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/62/ --- Review request for Viewer. Summary --- Unit tests addition: - add tests