Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ --- (Updated Jan. 4, 2012, 7:20 a.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1133 --- indra/newview/llpreviewscript.cpp

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ --- (Updated Dec. 25, 2011, 3:17 p.m.) Review request for Viewer. Description

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ --- (Updated Dec. 25, 2011, 3:15 p.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ --- (Updated Dec. 9, 2011, 2:12 a.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

> On Dec. 8, 2011, 11:08 a.m., Oz Linden wrote: > > indra/newview/skins/default/xui/en/strings.xml, line 430 > > > > > > fix indentation Unfortunately, I had to fix this manually, as VC10 is not using a tab here as i

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

> On Dec. 8, 2011, 11:08 a.m., Oz Linden wrote: > > indra/newview/llpreviewscript.cpp, lines -1120 > > > > > > Don't leave commented-out code in. Damn. I'd already done this as a final clean up pass, then forgot

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1115 --- Just a few minor comments - looks very good. indra/newview/llfl

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ --- (Updated Dec. 8, 2011, 2:45 a.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

> On Nov. 20, 2011, 6:53 a.m., Lance Corrimal wrote: > > found another glitch: > > I'm developing scripts in eclipse with lslforge. When I "compile" a script > > in eclipse and then load it using this patch, tabstops are converted into > > IDunnoWhat (it shows as little squares in the script ed

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

@Kadah, you are right. This is what is going to happen. I would not knowingly let an 'annoyance' go out with a release. Not worth the community backlash ... I was only making the point cause the tab issue and the fact that most external editors use \t for tabs, is likely going to lead to "I upload

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

> On Nov. 20, 2011, 6:53 a.m., Lance Corrimal wrote: > > found another glitch: > > I'm developing scripts in eclipse with lslforge. When I "compile" a script > > in eclipse and then load it using this patch, tabstops are converted into > > IDunnoWhat (it shows as little squares in the script ed

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

> On Nov. 20, 2011, 6:53 a.m., Lance Corrimal wrote: > > found another glitch: > > I'm developing scripts in eclipse with lslforge. When I "compile" a script > > in eclipse and then load it using this patch, tabstops are converted into > > IDunnoWhat (it shows as little squares in the script ed

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

> On Nov. 20, 2011, 6:53 a.m., Lance Corrimal wrote: > > found another glitch: > > I'm developing scripts in eclipse with lslforge. When I "compile" a script > > in eclipse and then load it using this patch, tabstops are converted into > > IDunnoWhat (it shows as little squares in the script ed

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

> On Nov. 20, 2011, 6:53 a.m., Lance Corrimal wrote: > > found another glitch: > > I'm developing scripts in eclipse with lslforge. When I "compile" a script > > in eclipse and then load it using this patch, tabstops are converted into > > IDunnoWhat (it shows as little squares in the script ed

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

My suggestion: convert tabs to 4 spaces. I believe 4 spaces per tab is what the script editor does already anyways, for keyboard input. bye, LC Am Mittwoch, 23. November 2011 schrieb Ricky: > Interesting. On my Mac the tabs display in the Viewer's editor as > single spaces. My Win7 box shows t

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

Interesting. On my Mac the tabs display in the Viewer's editor as single spaces. My Win7 box shows the squares. Didn't test Linux. Definitely looks like a font issue, though I think that the best solution is to just make the Viewer's editor accept tabs - maybe even have the option to specify how

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

found another glitch: I'm developing scripts in eclipse with lslforge. When I "compile" a script in eclipse and then load it using this patch, tabstops are converted into IDunnoWhat (it shows as little squares in the script editor). This behavior is familiar to me as well. I use LSL Editor, the s

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

> On Nov. 20, 2011, 6:53 a.m., Lance Corrimal wrote: > > found another glitch: > > I'm developing scripts in eclipse with lslforge. When I "compile" a script > > in eclipse and then load it using this patch, tabstops are converted into > > IDunnoWhat (it shows as little squares in the script ed

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ --- (Updated Nov. 22, 2011, 5:17 p.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

> On Nov. 20, 2011, 6:53 a.m., Lance Corrimal wrote: > > found another glitch: > > I'm developing scripts in eclipse with lslforge. When I "compile" a script > > in eclipse and then load it using this patch, tabstops are converted into > > IDunnoWhat (it shows as little squares in the script ed

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

> On Nov. 20, 2011, 6:53 a.m., Lance Corrimal wrote: > > found another glitch: > > I'm developing scripts in eclipse with lslforge. When I "compile" a script > > in eclipse and then load it using this patch, tabstops are converted into > > IDunnoWhat (it shows as little squares in the script ed

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

> On Nov. 20, 2011, 6:53 a.m., Lance Corrimal wrote: > > found another glitch: > > I'm developing scripts in eclipse with lslforge. When I "compile" a script > > in eclipse and then load it using this patch, tabstops are converted into > > IDunnoWhat (it shows as little squares in the script ed

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

> On Nov. 19, 2011, 5:54 a.m., Lance Corrimal wrote: > > I've put the last revision (4) in, and it still doesn't add .lsl to > > filenames on saving... I'm building on linux here, maybe that's the reason? > > Ima Mechanique wrote: > This is mostly a Window's feature, at this time. The .lsl

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

> On Nov. 19, 2011, 5:54 a.m., Lance Corrimal wrote: > > I've put the last revision (4) in, and it still doesn't add .lsl to > > filenames on saving... I'm building on linux here, maybe that's the reason? This is mostly a Window's feature, at this time. The .lsl filter is part of a Window's on

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1082 --- found another glitch: I'm developing scripts in eclipse with lslf

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1081 --- I've put the last revision (4) in, and it still doesn't add .lsl

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ --- (Updated Nov. 18, 2011, 3:06 p.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ --- (Updated Nov. 18, 2011, 2:55 p.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

> On Nov. 18, 2011, 6:06 a.m., Lance Corrimal wrote: > > Built it into dolphin 3.2 beta, tested it. found a few issues: > > - main menu option Build/Upload/Script does nothing at all > > - saving a script that you open from your inventory to disk only works > > after you edit the script > > - sa

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ --- (Updated Nov. 18, 2011, 1:21 p.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

> On Nov. 18, 2011, 6:06 a.m., Lance Corrimal wrote: > > Built it into dolphin 3.2 beta, tested it. found a few issues: > > - main menu option Build/Upload/Script does nothing at all > > - saving a script that you open from your inventory to disk only works > > after you edit the script > > - sa

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

> On Nov. 18, 2011, 6:06 a.m., Lance Corrimal wrote: > > Built it into dolphin 3.2 beta, tested it. found a few issues: > > - main menu option Build/Upload/Script does nothing at all > > - saving a script that you open from your inventory to disk only works > > after you edit the script > > - sa

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1076 --- Built it into dolphin 3.2 beta, tested it. found a few issues: -

[opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/ --- Review request for Viewer. Summary --- Changes to allow opened script