Re: [opensource-dev] Review Request: /me emote doubles name in chat history

2011-08-13 Thread Vadim ProductEngine
> On Aug. 11, 2011, 11:47 a.m., Vadim ProductEngine wrote: > > indra/newview/llchathistory.cpp, line 929 > > > > > > Agree with Boroondas that replacing /me with the sender name and then > > stripping it looks weird.

Re: [opensource-dev] Review Request: /me emote doubles name in chat history

2011-08-13 Thread ardylay
> On Aug. 11, 2011, 11:47 a.m., Vadim ProductEngine wrote: > > indra/newview/llchathistory.cpp, line 929 > > > > > > Agree with Boroondas that replacing /me with the sender name and then > > stripping it looks weird.

Re: [opensource-dev] Review Request: /me emote doubles name in chat history

2011-08-11 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/419/#review962 --- The patch introduces regressions: * The /me prefix is not handled

Re: [opensource-dev] Review Request: /me emote doubles name in chat history

2011-07-28 Thread ardylay
> On July 28, 2011, 2:58 a.m., Boroondas Gupte wrote: > > indra/newview/llchathistory.cpp, line 929 > > > > > > As you cut away a substring of the length of chat.mFrontName, I assume > > chat.mText contains the conten

Re: [opensource-dev] Review Request: /me emote doubles name in chat history

2011-07-28 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/419/#review934 --- indra/newview/llchathistory.cpp

[opensource-dev] Review Request: /me emote doubles name in chat history

2011-07-27 Thread ardylay
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/419/ --- Review request for Viewer. Summary --- As a resident of Second Life I