Re: [opensource-dev] Review Request: Mouse pointer flickers when hovering over any active/clickable UI item

2011-11-12 Thread ardylay
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/513/#review1074 --- Mouse cursor behavior is much better with this patch applied. -

Re: [opensource-dev] Review Request: /me emote doubles name in chat history

2011-08-13 Thread ardylay
> On Aug. 11, 2011, 11:47 a.m., Vadim ProductEngine wrote: > > indra/newview/llchathistory.cpp, line 929 > > > > > > Agree with Boroondas that replacing /me with the sender name and then > > stripping it looks weird.

Re: [opensource-dev] Review Request: STORM-1521 [previously VWR-25588]: Zi's proposed fix for FIRE-543 - Hovertext renders as overlay on top of everything else

2011-07-28 Thread ardylay
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/405/#review939 --- Ship it! I am using it without noticing any functional issues. D

Re: [opensource-dev] Review Request: /me emote doubles name in chat history

2011-07-28 Thread ardylay
> On July 28, 2011, 2:58 a.m., Boroondas Gupte wrote: > > indra/newview/llchathistory.cpp, line 929 > > > > > > As you cut away a substring of the length of chat.mFrontName, I assume > > chat.mText contains the conten

[opensource-dev] Review Request: /me emote doubles name in chat history

2011-07-27 Thread ardylay
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/419/ --- Review request for Viewer. Summary --- As a resident of Second Life I

Re: [opensource-dev] Review Request: STORM-859 : winres.h isn't present within VC++ Express includes. Must be manually copied from win7 sdk example code.

2011-05-16 Thread ardylay
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/304/#review700 --- Ship it! I think I can approve of that. It's essentially what we

Re: [opensource-dev] Review Request: OPEN-61 Adding locations that VC redistributable package installs files.

2011-04-21 Thread ardylay
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/259/#review644 --- Ship it! Seems to have worked for me on Windows 7 64-bit. Thanks

Re: [opensource-dev] Review Request: fix for ECC-49 / storm-1147: Other avatar's loose clothing\ flared cuffs look like they are tight\got no flare in v.2.4.0 and higher

2011-04-08 Thread ardylay
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/260/#review581 --- Ship it! I started using this daily about a week ago. It does th

Re: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

2011-03-04 Thread ardylay
equivalent names in nearby chat history and IM history quite tiresome. Simple proposal: If the resident's Display Name is at the default then do not display their user.name. https://bitbucket.org/ArdyLay/viewer-development-vwr-24917 Change is to: LLAvatarName::getCompleteName I find the foll

Re: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

2011-03-04 Thread ardylay
> > (Updated March 3, 2011, 9:25 p.m.) > > > Review request for Viewer. > > > Summary > --- > > https://jira.secondlife.com/browse/VWR-24917 > I have been finding the redundent display of func

Re: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

2011-03-04 Thread ardylay
; > (Updated March 3, 2011, 9:25 p.m.) > > > Review request for Viewer. > > > Summary > --- > > https://jira.secondlife.com/browse/VWR-24917 > I have been finding the redundent display of functionally equivalent names in > nearby chat history a

Re: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

2011-03-03 Thread ardylay
https://bitbucket.org/ArdyLay/viewer-development-vwr-24917 Change is to: LLAvatarName::getCompleteName I find the following Callers: LLAvatarActions::requestFriendshipDialog LLAvatarActions::startIM LLAvatarActions::startCall LLIMModel::LLIMSession LLIMModel::logToFile LLPostponedNotification::onAvatarName

[opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

2011-02-19 Thread ardylay
/browse/VWR-24917 I have been finding the redundent display of functionally equivalent names in nearby chat history and IM history quite tiresome. Simple proposal: If the resident's Display Name is at the default then do not display their user.name. https://bitbucket.org/ArdyLay/viewer-develo