Re: [opensource-dev] Review Request: OPEN-159 / Faster, nicer Depth of Field

2013-01-11 Thread Tofu Buzzard
ttp://codereview.secondlife.com/r/615/#comment1191> Ah, yes. I added this assert to mark this function as broken because it ate some of my time just unobviously doing nothing. - Tofu Buzzard On Jan. 11, 2013, 2 p.m., Tofu Buzzard wrote: > > ---

Re: [opensource-dev] Review Request: OPEN-159 / Faster, nicer Depth of Field

2013-01-11 Thread Tofu Buzzard
gs/shaders/class1/deferred/postDeferredF.glsl UNKNOWN indra/newview/pipeline.cpp UNKNOWN Diff: http://codereview.secondlife.com/r/615/diff/ Testing --- Been running like this for a while myself... Thanks, Tofu Buzzard ___ Policies and (un

[opensource-dev] Review Request: OPEN-159 / Faster, nicer Depth of Field

2013-01-11 Thread Tofu Buzzard
rredF.glsl UNKNOWN indra/newview/pipeline.cpp UNKNOWN Diff: http://codereview.secondlife.com/r/615/diff/ Testing --- Been running like this for a while myself... Thanks, Tofu Buzzard ___ Policies and (un)subscribe information available

Re: [opensource-dev] Review Request: VWR-29083 Make SSAO work better

2013-01-11 Thread Tofu Buzzard
ew/pipeline.cpp UNKNOWN Diff: http://codereview.secondlife.com/r/612/diff/ Testing --- Been running with this for months on an assortment of nvidia hardware, linux only. Thanks, Tofu Buzzard ___ Policies and (un)subscribe information avail

Re: [opensource-dev] Review Request: VWR-29083 Make SSAO work better

2013-01-11 Thread Tofu Buzzard
re specifying > > what the non-mangled math originally was (a la the old > > softenLightF.glsl:206-214) > > Tofu Buzzard wrote: > Our shaders are really branchy, that's really not a problem (on the > target class). I don't strictly remember removing comments on the origina

Re: [opensource-dev] Review Request: VWR-29083 Make SSAO work better

2013-01-11 Thread Tofu Buzzard
re specifying > > what the non-mangled math originally was (a la the old > > softenLightF.glsl:206-214) > > Tofu Buzzard wrote: > Our shaders are really branchy, that's really not a problem (on the > target class). I don't strictly remember removing comments on the origina

Re: [opensource-dev] Review Request: VWR-29083 Make SSAO work better

2013-01-11 Thread Tofu Buzzard
N indra/newview/pipeline.cpp UNKNOWN Diff: http://codereview.secondlife.com/r/612/diff/ Testing --- Been running with this for months on an assortment of nvidia hardware, linux only. Thanks, Tofu Buzzard ___ Policies and (un)subscribe i

Re: [opensource-dev] Review Request: VWR-29083 Make SSAO work better

2013-01-11 Thread Tofu Buzzard
n an assortment of nvidia hardware, linux only. Thanks, Tofu Buzzard ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-29083 Make SSAO work better

2013-01-11 Thread Tofu Buzzard
rawing the most light). So the two relevancies modulate either other, the 'correct' mixing of the two in my head would be sqrt(angrel*distrel) but max(angrel,distrel) seemed a touch more pleasing and probably quicker. - Tofu

Re: [opensource-dev] Review Request: OPEN-152 Fog is broken on water, and extra-broken on water in deferred rendering

2013-01-11 Thread Tofu Buzzard
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/611/#review1289 --- Anyone? - Tofu Buzzard On Dec. 2, 2012, 2:53 a.m., Tofu

[opensource-dev] Review Request: VWR-29083 Make SSAO work better

2012-12-02 Thread Tofu Buzzard
ra/newview/app_settings/shaders/class2/deferred/sunLightSSAOF.glsl UNKNOWN indra/newview/pipeline.cpp UNKNOWN Diff: http://codereview.secondlife.com/r/612/diff/ Testing --- Been running with this for months on an assortment of nvidia hardware, linux only. Thanks, To

Re: [opensource-dev] Review Request: OPEN-152 Fog is broken on water, and extra-broken on water in deferred rendering

2012-12-02 Thread Tofu Buzzard
Diff: http://codereview.secondlife.com/r/611/diff/ Testing --- Tested with/without deferred rendering, with various sky presets. Screenshots --- before/after comparisons http://codereview.secondlife.com/r/611/s/1/ Thanks, Tofu Buzzard

Re: [opensource-dev] Review Request: OPEN-152 Fog is broken on water, and extra-broken on water in deferred rendering

2012-12-02 Thread Tofu Buzzard
with/without deferred rendering, with various sky presets. Screenshots --- before/after comparisons http://codereview.secondlife.com/r/611/s/1/ Thanks, Tofu Buzzard ___ Policies and (un)subscribe information available here: http

[opensource-dev] Review Request: OPEN-152 Fog is broken on water, and extra-broken on water in deferred rendering

2012-12-02 Thread Tofu Buzzard
various sky presets. Screenshots --- before/after comparisons http://codereview.secondlife.com/r/611/s/1/ Thanks, Tofu Buzzard ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please

Re: [opensource-dev] Review Request: STORM-1823 - Replace current specular model with Normalized Blinn-Phong specularity

2012-03-25 Thread Tofu Buzzard
But ship it. - Tofu Buzzard On March 25, 2012, 2:07 p.m., Geenz Spad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secon

Re: [opensource-dev] Review Request: STORM-1818: Fix for viewer crash when entering chars other than [a-z0-9-_. ] into the grid-selection combo.

2012-03-25 Thread Tofu Buzzard
be lame. - Tofu Buzzard On March 24, 2012, 5:33 a.m., MartinRJ Fayray wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondli

Re: [opensource-dev] Review Request: STORM-1818: Fix for viewer crash when entering chars other than [a-z0-9-_. ] into the grid-selection combo.

2012-03-25 Thread Tofu Buzzard
grid is invalid until they try to login then I reckon that's fine, but I'll defer to others. - Tofu Buzzard On March 24, 2012, 5:33 a.m., MartinRJ Fayray wrote: > > --- > This is an automatically generated e-mail.

Re: [opensource-dev] Review Request: STORM-1818: Fix for viewer crash when entering chars other than [a-z0-9-_. ] into the grid-selection combo.

2012-03-25 Thread Tofu Buzzard
give a better user experience? Cheers. - Tofu Buzzard On March 24, 2012, 5:33 a.m., MartinRJ Fayray wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http:/

Re: [opensource-dev] Review Request: STORM-1823 - Replace current specular model with Normalized Blinn-Phong specularity

2012-03-25 Thread Tofu Buzzard
ed be called handleLUTBufferChanged, and ideally I'd like some comment (probably in the LUT creation) about why the results of lookups should be multiplied by 4 (to avoid saturation in the LUT?). Otherwise, I reckon this is great. - Tofu Buzzard On March 21, 2012, 1:01 p.m., Geenz