Re: [opensource-dev] Review Request: STORM-1911: Go-to line function for the internal LSL script editor

2012-09-19 Thread Kelly Washington
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/596/#review1266 --- Ship it! Ship It! - Kelly Washington On Sept. 19, 2012, 7:26

Re: [opensource-dev] Review Request: BUG-59: Go-to line function for the internal LSL script editor

2012-09-14 Thread Kelly Washington
'// else do nothing ' indra/newview/llpreviewscript.cpp <http://codereview.secondlife.com/r/596/#comment1155> Need null pointer checks on mEditorCore and mEditor. - Kelly Washington On Sept. 13, 2012, 8:38 a.m., MartinRJ Fayray wrote: > > --

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

2011-11-18 Thread Kelly Washington
> On Nov. 18, 2011, 6:06 a.m., Lance Corrimal wrote: > > Built it into dolphin 3.2 beta, tested it. found a few issues: > > - main menu option Build/Upload/Script does nothing at all > > - saving a script that you open from your inventory to disk only works > > after you edit the script > > - sa

[opensource-dev] Review Request: VWR-25261 URLs in Top Scripts is always 0.

2011-03-23 Thread Kelly Washington
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/228/ --- Review request for Viewer. Summary --- Fix the top scripts floater to

[opensource-dev] Review Request: STORM-1044 Improved message template checking.

2011-03-03 Thread Kelly Washington
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/174/ --- Review request for Viewer. Summary --- Improved message template check

Re: [opensource-dev] Review Request: STORM-1001: Viewer needlessly hits the "ObjectMedia" cap with thousands of requests

2011-03-02 Thread Kelly Washington
> On March 1, 2011, 10:22 p.m., Merov Linden wrote: > > indra/llprimitive/lltextureentry.cpp, line 433 > > > > > > Looks like you need to add creation/deletion of mMediaEntry if the > > TEM_MEDIA_MASK bit flipped. That

Re: [opensource-dev] Review Request: STORM-1001: Viewer needlessly hits the "ObjectMedia" cap with thousands of requests

2011-03-02 Thread Kelly Washington
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/162/#review408 --- Ship it! This change looks good to me. It looks cleaner and more