---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/302/
---
(Updated May 20, 2011, 4:04 p.m.)
Review request for Viewer and Richard Nel
On Tue, May 17, 2011 at 12:42 PM, WolfPup Lowenhar
wrote:
> I also built this repository locally but from the tip and my build time
> which was a full standard build including all test took 2hrs and 22min this
> is actually 8 minutes longer that a viewer development build currently. Also
> only on
On Tue, May 17, 2011 at 8:17 AM, Ardy Lay wrote:
> On 5/16/2011 9:04 PM, Brad Kittenbrink wrote:
>
> It's also availible on
> bitbucket(https://bitbucket.org/brad_linden/viewer-mustbuildfaster-1/changeset/25c39e3d8a88)
> for testing in TeamCity.
>
> Brad, is the Te
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/311/#review707
---
Ship it!
Looks good to me
- Brad
On May 17, 2011, 9:31 a.m., t
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/302/
---
Review request for Viewer and Richard Nelson.
Summary
---
Started movi
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/301/
---
Review request for Viewer.
Summary
---
Consolidating all references to
er examination, first. (If this
> > is a bug and isn't compensated for elsewhere, would its effect be
> > observable somehow? If so, how?)
> > 3) Even if this is a bug, fixing it is out of scope for CHOP-624 and
> > should not delay/block it.
> >
>
no longer applies with "modern" compilers). Part of
my ongoing build time optimization work in CHOP-609 is to reduce the number of
extern symbols that the linker has to deal with, and this is the easiest way to
do that in cases where it can be used.
- Brad
-
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/289/
---
(Updated May 5, 2011, 5:21 p.m.)
Review request for Viewer.
Changes
-
> On May 4, 2011, 11:36 a.m., Boroondas Gupte wrote:
> > indra/newview/llviewerregion.cpp, line 835
> > <http://codereview.secondlife.com/r/289/diff/1/?file=1566#file1566line835>
> >
> > Please place spaces around binary operator* .
>
> Brad Kittenbri
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/300/
---
Review request for Viewer.
Summary
---
The use_prebuilt_binary macro h
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/299/
---
Review request for Viewer.
Summary
---
Fix for error using precompiled
> On May 4, 2011, 11:58 a.m., Boroondas Gupte wrote:
> > This change is identical to the one under review at
> > https://codereview.secondlife.com/r/289
> >
> > Did you upload the wrong diff file to one of the review requests?
>
> Brad Kittenbrink wrote:
>
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/289/
---
(Updated May 4, 2011, 2:57 p.m.)
Review request for Viewer.
Changes
-
eview.secondlife.com/r/297/#review676
---
On May 3, 2011, 6:40 p.m., Brad Kittenbrink wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/297/
---
(Updated May 3, 2011, 6:40 p.m.)
Review request for Viewer.
Summary (upda
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/297/
---
Review request for Viewer.
Summary
---
Sorry for the big diff here, bu
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/293/
---
Review request for Viewer.
Summary
---
Added checking in indra/cmake/P
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/289/
---
Review request for Viewer.
Summary
---
Fix for error using precompiled
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/279/
---
(Updated May 2, 2011, 4:30 p.m.)
Review request for Viewer and Richard Nels
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/282/#review666
---
Ship it!
Looks good to me.
- Brad
On May 1, 2011, 2:54 p.m., B
I think this is a bad idea, that would be far less readable imho.
3) I'd be fine with this change at some point, but I don't think it really
matters.
On April 27, 2011, 4:16 a.m., Brad Kittenbrink wrote:
> > [*] Assuming the data referenced by control_map isn't changed by oth
?file=1511#file1511line1719>
> >
> > e.g. here we could extend the condition to
> > if (!buffer.empty() && (fread(&buffer[0], 1, index_size,
> > mIndexFP) != index_size))
We certainly could, but I'm not convinced that that's better.
--
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/281/#review653
-------
On April 26, 2011, 5:48 p.m., Brad Kittenbrink wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/281/
---
Review request for Viewer.
Summary
---
Somewhere in the VS2010 transit
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/279/
---
(Updated April 26, 2011, 5:40 p.m.)
Review request for Viewer.
Summary (u
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/280/
---
Review request for Viewer.
Summary
---
Unnecessary copying was slowing
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/279/
---
Review request for Viewer.
Summary
---
The error is due to the fact th
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/278/
---
Review request for Viewer.
Summary
---
Fix for a minor buffer overrun
Sorry I let this sit for a while without replying, here are my thoughts:
On Sat, Mar 26, 2011 at 7:18 AM, Ima Mechanique <
ima.mechani...@blueyonder.co.uk> wrote:
> Thanks for replying Brad
>
> > The working directory setting may no longer be necessary after this
> > change<
> https://bitbucket.o
On Fri, Mar 25, 2011 at 11:04 AM, Ima Mechanique <
ima.mechani...@blueyonder.co.uk> wrote:
> I'm trying to find out more information about this setting and the piece
> of code it controls. Non Windows devs can switch off now as it only
> affects them by causing a warning about it not being used.
>
On Mon, Jan 31, 2011 at 1:31 PM, Jonathan Welch wrote:
> In autobuild\autobuild_tool_source_environment.py there is one
> reference to "devenv" and two references to "devenv.com".
>
> This should be
> 1) Made consistent
> 2) Make sure there is not a devenv.exe -- just what is supposed to be
> run
On Fri, Jan 21, 2011 at 6:40 PM, Nicky Perian wrote:
> I am trying to prove a no harm done 2005 build first. Then on to 2010.
> the build-cmd.sh script references "build_sln" for several entries.
> Example: build_sln src/client/windows/breakpad_client.sln "release|win32"
> exception_handler
>
> T
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/44/#review58
---
Ship it!
Looks good to me
- Brad
On 2010-12-19 07:18:51, Aleric
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/29/#review43
---
Ship it!
Looks like a safe and sensible change to me.
- Brad
On
to work backwards from the code in the viewer, but it
> would be handy to just have an overview of the viewer<->web service
> exchanges :).
>
>
>
> Kitty
>
>
>
> *From:* opensource-dev-boun...@lists.secondlife.com [mailto:
> opensource-dev-boun...@lists.secon
Oops, thanks for the heads-up.
The background updater is new in viewer 2.4 (as it's not released in beta
yet, it doesn't have release notes yet, so sorry for the surprise).
Yesterday we deployed the server side work in preparation for the beginning
of the 2.4 beta releases, and it turned on. Unfo
On Tue, Nov 9, 2010 at 1:04 AM, Boroondas Gupte
wrote:
> On 11/09/2010 08:12 AM, Ricky wrote:
>
> Trying to compile viewer_development a60d3b118c76 (tip as of the time
> of this message) I get the following error:
>
> make[2]: *** No rule to make target
> `sharedlibs//PROJECT_llmath_TEST_llbboxlo
Funny, but no. It has been said that cmake is the worst IDE build system
generator except all those others that have been tried.
We are gonna try to ditch develop.py though. And we're gonna start
publishing the way we build all third party libs for the viewer. We should
be ready to show it off a
On Wed, Oct 6, 2010 at 8:57 AM, Joshua Bell wrote:
> On Tue, Oct 5, 2010 at 7:29 PM, Kent Quirk (Q Linden)
> wrote:
>
>> Well, it's not quite like that. To pull this off, you'd have to take
>> everywhere we set a color, and set it instead to its equivalent black and
>> white value (there's a for
This was due to us upgrading to a new version of the c-ares library,
and we dropped the pieces that handle the new initialization
requirements. If we export again it should be fixed.
Sorry,
-Brad
On Wednesday, June 16, 2010, Latif Khalifa wrote:
> Hi,
>
> It builds fine on windows but it does n
On Tue, Mar 30, 2010 at 9:44 PM, Philippe (Merov) Bossut <
me...@lindenlab.com> wrote:
> Hi NickyP,
>
> On Tue, Mar 30, 2010 at 7:28 PM, William Nickels wrote:
>
>> I have been building SG2 with VC++ Express 2008 (VC90) using boost
>> libraries version 1-36. I have completed the build of secondlif
On Fri, Mar 19, 2010 at 4:47 PM, Jacek Antonelli
wrote:
> On Fri, Mar 19, 2010 at 1:13 PM, Carlo Wood wrote:
> > Actually, I think I understand why.
> >
> > LL is using hg internally, and has been for a while.
> > They just pushed things out as svn for public access, but that process
> > caused a
43 matches
Mail list logo
