Re: [opensource-dev] Review Request: OPEN-172 Combined changesets for Linux gcc 4.7, 2 build of viewer development

2013-04-13 Thread Aleric Inglewood
'namespace boost' around intrusive functions. I couldn't get it explained to Oz... - Aleric Inglewood On April 13, 2013, 3:21 p.m., Nicky Perian wrote: > > --- > This is an automatically generated e-mail.

Re: [opensource-dev] Review Request: BUG-1709: Tiny prims do not rescale properly at very high viewer framerates

2013-02-18 Thread Aleric Inglewood
t case at your frame rate, but will still fail to reach the final scale when you increase the frame rate (or when the destination scale is simply so close to the start scale that this condition is never true). - Aleric Inglewood On Feb. 17, 2013, 7:02 p.m., M

Re: [opensource-dev] Review Request: patch potential memory leak in llgl.h

2012-09-19 Thread Aleric Inglewood
se ok (Singularity has this patch since a long time). - Aleric Inglewood On Sept. 19, 2012, 8:26 a.m., Gistya Eusebio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.sec

Re: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)

2011-06-21 Thread Aleric Inglewood
> On June 21, 2011, 6:56 a.m., Aleric Inglewood wrote: > > indra/llvfs/lldiriterator.cpp, line 123 > > <http://codereview.secondlife.com/r/313/diff/1/?file=2823#file2823line123> > > > > What is your reasoning to use native() here and not string()? > >

Re: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)

2011-06-21 Thread Aleric Inglewood
> On June 21, 2011, 6:56 a.m., Aleric Inglewood wrote: > > indra/llvfs/lldiriterator.cpp, line 123 > > <http://codereview.secondlife.com/r/313/diff/1/?file=2823#file2823line123> > > > > What is your reasoning to use native() here and not string()? > >

Re: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)

2011-06-21 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/313/#review793 --- indra/llvfs/lldiriterator.cpp

Re: [opensource-dev] Review Request: VWR-25965 LLDirIterator fixes in the viewer cache migration and VFS fallback.

2011-06-08 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/324/#review736 --- Ship it! - Aleric On June 7, 2011, 11:42 a.m., Log Linden wrote

Re: [opensource-dev] Review Request: VWR-25862 Fix viewer caches not being cleared.

2011-06-06 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/315/#review724 --- indra/newview/llvocache.cpp

[opensource-dev] Outstanding patches since Januari...

2011-03-12 Thread Aleric Inglewood
This is just a reminder that there are still six patches of me waiting on the reviewboard: https://codereview.secondlife.com/r/88/ https://codereview.secondlife.com/r/92/ https://codereview.secondlife.com/r/80/ https://codereview.secondlife.com/r/95/ https://codereview.secondlife.com/r/81/ https:/

Re: [opensource-dev] Review Request: make PREHASH variables char const* const (fixes VWR-24487: llurlentry_stub.cpp:196: error: deprecated conversion from string constant to 'char*')

2011-03-07 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/#review429 --- Ship it! Perfect. - Aleric On March 7, 2011, 3:51 p.m., Boroon

Re: [opensource-dev] Review Request: storm-1038: crash in texture cache pruning

2011-03-03 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/172/#review416 --- You want to know what I think... https://codereview.secondlife.co

Re: [opensource-dev] Review Request: OPEN-38: autobuild support for StandAlone

2011-02-27 Thread Aleric Inglewood
To reply, visit: http://codereview.secondlife.com/r/167/#review391 ------- On Feb. 26, 2011, 6:56 a.m., Aleric Inglewood wrote: > > --- > This is an automatically

Re: [opensource-dev] Review Request: OPEN-38: autobuild support for StandAlone

2011-02-27 Thread Aleric Inglewood
-- On Feb. 26, 2011, 6:56 a.m., Aleric Inglewood wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/167/ > ---

Re: [opensource-dev] Review Request: OPEN-38: autobuild support for StandAlone

2011-02-27 Thread Aleric Inglewood
On Feb. 27, 2011, 3:47 a.m., Aleric Inglewood wrote: > > Building still fails for me, with > > > > Linking CXX shared library libllcommon.so > > /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: > > skipping incompatible > > /u

Re: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

2011-02-27 Thread Aleric Inglewood
> On Feb. 27, 2011, 5:57 a.m., Boroondas Gupte wrote: > > indra/llcommon/llavatarname.cpp, lines 93-108 > > > > > > This could be shortened to > > > > if (!mUsername.empty() && !mIsDisplayNameDefault) > >

Re: [opensource-dev] Review Request: OPEN-38: autobuild support for StandAlone

2011-02-26 Thread Aleric Inglewood
ch might not be what you want if you use the same source tree for standlone and non-standalone testing. - Aleric --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/167/#review38

[opensource-dev] Review Request: OPEN-38: autobuild support for StandAlone

2011-02-26 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/167/ --- Review request for Viewer. Summary --- Oz: please merge into your repo

Re: [opensource-dev] Is 'STANDALONE' confusing?

2011-02-21 Thread Aleric Inglewood
t; means, especially "Linden Lab prebuilt". Therefore I think it's better to use PREBUILT as keyword than SYSTEM_LIBS. On Mon, Feb 21, 2011 at 4:46 PM, Boroondas Gupte wrote: > On 02/21/2011 04:41 PM, Aleric Inglewood wrote: >> A LOT worse, but still better than 'standalone

Re: [opensource-dev] Is 'STANDALONE' confusing?

2011-02-21 Thread Aleric Inglewood
I agree too. I have found 'standalone' to be confusing all along, and inverting it (ON <--> OFF) is a very logical thing to do. If inverting is acceptable then USE_PREBUILT_LIBS sounds good. Or perhaps, USE_LL_PREBUILT_LIBS which would be more clear, but wouldn't work for the TPV's :(. If invertin

Re: [opensource-dev] Review Request: CMAKE_EXE_LINKER_FLAGS not honored when linking the viewer binary if -DLL_TESTS:BOOL=ON

2011-02-10 Thread Aleric Inglewood
-24366: gmock is underlinked, it needs > > gtest. > > gtest > > -Wl,--as-needed) # continue to use "as-needed" for other libs > > elseif(WINDOWS) > > # ... > > Aleric Inglewood wrote: > I don't think you ca

Re: [opensource-dev] Review Request: CMAKE_EXE_LINKER_FLAGS not honored when linking the viewer binary if -DLL_TESTS:BOOL=ON

2011-02-10 Thread Aleric Inglewood
> On Feb. 10, 2011, 2:02 a.m., Boroondas Gupte wrote: > > indra/cmake/GoogleMock.cmake, lines 13-14 > > > > > > I'd put the > > -Wl,--no-as-needed > > down on gtest's line, so that the "wrapping" is more o

Re: [opensource-dev] Review Request: STORM-864: As as developer, I would like an object oriented wrapper to make safe use of memory pools easier

2011-02-04 Thread Aleric Inglewood
> On Feb. 2, 2011, 6:30 p.m., Merov Linden wrote: > > indra/llmessage/llpumpio.cpp, line 359 > > <http://codereview.secondlife.com/r/99/diff/2/?file=706#file706line359> > > > > An example where the use of operator() is particularly unsightly... >

Re: [opensource-dev] Review Request: STORM-864: As as developer, I would like an object oriented wrapper to make safe use of memory pools easier

2011-02-03 Thread Aleric Inglewood
generated e-mail. To reply, visit: http://codereview.secondlife.com/r/99/#review315 ------- On Jan. 29, 2011, 9:10 a.m., Aleric Inglewood wrote: > > --- > This is an automa

Re: [opensource-dev] Review Request: STORM-864: As as developer, I would like an object oriented wrapper to make safe use of memory pools easier

2011-02-03 Thread Aleric Inglewood
is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/99/#review303 ------- On Jan. 29, 2011, 9:10 a.m., Aleric Inglewood wrote: > > --- > This is an automatically gener

Re: [opensource-dev] Review Request: STORM-864: As as developer, I would like an object oriented wrapper to make safe use of memory pools easier

2011-02-03 Thread Aleric Inglewood
- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/99/#review315 --- On Jan. 29, 2011, 9:10 a.m., Aleric Inglewood wrote: > >

Re: [opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)

2011-02-03 Thread Aleric Inglewood
---------- On Jan. 16, 2011, 5:53 a.m., Aleric Inglewood wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/81/ > ---

Re: [opensource-dev] Review Request: VWR-24366: CMAKE_EXE_LINKER_FLAGS not honored when linking the viewer binary if -DLL_TESTS:BOOL=ON

2011-02-03 Thread Aleric Inglewood
//codereview.secondlife.com/r/95/#review163 --- On Jan. 14, 2011, 1:15 p.m., Aleric Inglewood wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Re: [opensource-dev] Review Request: make PREHASH variables char const* const

2011-02-03 Thread Aleric Inglewood
> On Feb. 3, 2011, 6:35 p.m., Aleric Inglewood wrote: > > Can this patch please be added to viewer-development? It's getting really annoying that I have to apply patches to the soruce tree before it even can compile cleanly

Re: [opensource-dev] Review Request: make PREHASH variables char const* const

2011-02-03 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/#review321 --- - Aleric On Jan. 22, 2011, 7:40 a.m., Boroondas Gupte wrote: >

Re: [opensource-dev] Review Request: STORM-864: As as developer, I would like an object oriented wrapper to make safe use of memory pools easier

2011-01-29 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/99/ --- (Updated Jan. 29, 2011, 9:10 a.m.) Review request for Viewer. Changes

[opensource-dev] [linux] /usr/bin/ld: error: unsupported symbol binding

2011-01-29 Thread Aleric Inglewood
If you are using linux and get this error while compiling the viewer: /usr/bin/ld: error: unsupported symbol binding (or, for that matter: /usr/bin/gold: error: unsupported symbol binding then you are using ld.gold version 2.20.x. You need to upgrade it to 2.21. If you are using debian the

Re: [opensource-dev] Review Request: make PREHASH variables char const* const

2011-01-22 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/#review245 --- Ship it! Latest diff looks good. Great that you found the generat

Re: [opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)

2011-01-21 Thread Aleric Inglewood
locally (indra/newview/llvosky.cpp), again not likely at all that anyone else will be making changes to that code right now (especially since they'd need to understand the code first - heheh, highly unlikely!). Let me know what your decision is, so I can adapt my

Re: [opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)

2011-01-21 Thread Aleric Inglewood
em much > > easier to understand, especially when there are several cascaded ones. :-) > > Aleric Inglewood wrote: > Yeah, I'm strongly convinced that TYPE const is superior in anyway over > const TYPE. > See http://www.xs4all.nl/~carlo17/cpp/const.qualifier.html for the

Re: [opensource-dev] Review Request: VWR-24337: Possible crash on llassert_always(purge_list.size() >= entries_to_purge)

2011-01-21 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/93/ --- (Updated Jan. 21, 2011, 4:25 a.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: make PREHASH variables char const* const

2011-01-20 Thread Aleric Inglewood
On Jan. 20, 2011, 3:54 a.m., Boroondas Gupte wrote: > > I agree though, that we should try to handle this similarly in both tests, > > if possible. So I tried setting the pointers in > > indra/llui/tests/llurlentry_stub.cpp to NULL, too, which works nicely. > > > > However, I then realized tha

Re: [opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

2011-01-19 Thread Aleric Inglewood
; (validate_idx == 0) that the behavior will be different. I need to > > understand better what that idx is all about or you need to give a bit more > > explanation before I approve this diff. > > Aleric Inglewood wrote: > The debug setting CacheValidateCounter is set to

Re: [opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

2011-01-18 Thread Aleric Inglewood
utomatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/90/#review191 --- On Jan. 14, 2011, 1:02 p.m., Aleric Inglewood wrote: > > ---

Re: [opensource-dev] Review Request: make PREHASH variables char const* const

2011-01-18 Thread Aleric Inglewood
r? I'd opt for setting the other also to a random string, like "Grumpity Productengine", or "Aleric Inglewood" now I think about it. Other options are "All Your Base Are Belong To Us" and "Hi mom!". Got be SURE they aren't used though -- don

Re: [opensource-dev] Link times

2011-01-18 Thread Aleric Inglewood
I can confirm that. I'm using a RAM disk (0.08ms random access time) and that does indeed drop link time significantly (I measured 8 seconds for viewer 1, not sure how long it is for viewer 2). ___ Policies and (un)subscribe information available here: ht

[opensource-dev] Review Request: VWR-24519: Spawning of the 'spare' media plugin process makes debugging SLPlugin harder

2011-01-17 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/96/ --- Review request for Viewer. Summary --- This patch stops early spawns of

[opensource-dev] Review Request: STORM-864: As as developer, I would like an object oriented wrapper to make safe use of memory pools easier

2011-01-17 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/99/ --- Review request for Viewer. Summary --- Please see http://jira.secondlif

Re: [opensource-dev] Review Request: VWR-24520: Don't use pkg_check_modules( ... QUIET ) on CMake < 2.8.2

2011-01-17 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/97/#review179 --- Ship it! Perfect ;) - Aleric On Jan. 17, 2011, 10:03 a.m., Bor

Re: [opensource-dev] Review Request: VWR-24317: Fix of debug warning (printing of unassigned variable)

2011-01-17 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/87/ --- (Updated Jan. 17, 2011, 5:32 a.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: VWR-24311: Uninstall packages that are renewed.

2011-01-17 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/80/ --- (Updated Jan. 17, 2011, 5:24 a.m.) Review request for Viewer. Changes

Re: [opensource-dev] Link times

2011-01-16 Thread Aleric Inglewood
I'm afraid that VWR-24366 won't reduce link times significantly. On Fri, Jan 14, 2011 at 11:49 PM, Boroondas Gupte wrote: > On 01/14/2011 06:04 PM, Jonathan Welch wrote: > > I just did a quick study on link times for various viewers on my 2Gb XP > system > > Viewer 1st link 2nd link > CV 1.22

Re: [opensource-dev] Review Request: VWR-24317: Incorrect start up warnings: WARNING: ll_apr_warn_status: APR: No such file or directory

2011-01-16 Thread Aleric Inglewood
then print it's contents. - Aleric --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/83/#review154 ------- On Jan. 1

Re: [opensource-dev] Review Request: VWR-24317: Incorrect start up warnings: WARNING: remove: Attempting to remove filename: /ramdisk/imprudence/cache/textures/*/*.texture

2011-01-16 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/84/ --- (Updated Jan. 16, 2011, 6:12 a.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)

2011-01-16 Thread Aleric Inglewood
This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/81/#review153 ------- On Jan. 16, 2011, 5:53 a.m., Aleric Inglewood wrote: > > --

Re: [opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)

2011-01-16 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/81/ --- (Updated Jan. 16, 2011, 5:53 a.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: VWR-24311: Uninstall packages that are renewed.

2011-01-16 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/80/ --- (Updated Jan. 16, 2011, 5:35 a.m.) Review request for Viewer. Changes

[opensource-dev] Review Request: VWR-24366: CMAKE_EXE_LINKER_FLAGS not honored when linking the viewer binary if -DLL_TESTS:BOOL=ON

2011-01-14 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/95/ --- Review request for Viewer. Summary --- Setting CMAKE_EXE_LINKER_FLAGS t

[opensource-dev] Review Request: VWR-24354: Fix manifest dependencies for linux

2011-01-14 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/94/ --- Review request for Viewer. Summary --- See http://jira.secondlife.com/b

[opensource-dev] Review Request: VWR-24337: Possible crash on llassert_always(purge_list.size() >= entries_to_purge)

2011-01-14 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/93/ --- Review request for Viewer. Summary --- Just fixed the logic, so entries

[opensource-dev] Review Request: VWR-24334: Add support for PluginAttachDebuggerToPlugins to linux

2011-01-14 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/92/ --- Review request for Viewer. Summary --- Added: On linux, when PluginAtta

[opensource-dev] Review Request: VWR-24333: Hardening against use of getLindenUserDir() before logging in.

2011-01-14 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/91/ --- Review request for Viewer. Summary --- Without this patch, getLindenUse

[opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

2011-01-14 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/90/ --- Review request for Viewer. Summary --- Trivial patch, just removes stup

[opensource-dev] Review Request: VWR-24320: Don't dump callstacks at clean exit of viewer.

2011-01-14 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/89/ --- Review request for Viewer. Summary --- See http://jira.secondlife.com/b

[opensource-dev] Review Request: VWR-24319: Fix the errors "QCursor: Cannot create bitmap cursor; invalid bitmap(s)" at start up of the webkit plugin, on linux.

2011-01-14 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/88/ --- Review request for Viewer. Summary --- These are caused because builtin

[opensource-dev] Review Request: VWR-24317: Fix of debug warning (printing of unassigned variable)

2011-01-14 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/87/ --- Review request for Viewer. Summary --- Fixed a typo that I stumbled upo

[opensource-dev] Review Request: VWR-24317: Incorrect start up warnings: WARNING: isFeatureAvailable: Feature RenderCubeMap not on feature list!

2011-01-14 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/86/ --- Review request for Viewer. Summary --- Fixes this warning. Note that LL

[opensource-dev] Review Request: VWR-24317: Incorrect start up warnings: WARNING: addFeature: LLFeatureList::Attempting to add preexisting feature Disregard128DefaultDrawDistance

2011-01-14 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/85/ --- Review request for Viewer. Summary --- Fixes a bug that causes the last

[opensource-dev] Review Request: VWR-24317: Incorrect start up warnings: WARNING: remove: Attempting to remove filename: /ramdisk/imprudence/cache/textures/*/*.texture

2011-01-14 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/84/ --- Review request for Viewer. Summary --- This turned out to be a simple m

[opensource-dev] Review Request: VWR-24317: Incorrect start up warnings: WARNING: ll_apr_warn_status: APR: No such file or directory

2011-01-14 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/83/ --- Review request for Viewer. Summary --- At start up one can get the foll

[opensource-dev] Review Request: VWR-24315: SNOW-796: Clicking 'Reset to default' in the Debug Settings floater doesn't update cached control values.

2011-01-14 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/82/ --- Review request for Viewer. Summary --- See https://jira.secondlife.com/

[opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)

2011-01-14 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/81/ --- Review request for Viewer. Summary --- Turns out that most of my SNOW-8

[opensource-dev] Review Request: VWR-24311: Uninstall packages that are renewed.

2011-01-14 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/80/ --- Review request for Viewer. Summary --- See https://jira.secondlife.com/

[opensource-dev] Review Request: VWR-13040: LLObjectSelection::valid_root_begin() is really the same as LLObjectSelection::root_begin()

2011-01-14 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/79/ --- Review request for Viewer. Summary --- See https://jira.secondlife.com/

Re: [opensource-dev] Why no single axis resize on linked prims??

2011-01-09 Thread Aleric Inglewood
And now for the real answer... You can't resize a prim along an arbitrary axis, so if any linked prim is rotated, it's simply not possible (in 99.9% of the cases). You might be able to pull it of for many special cases by changing sheer values, and use rotation (and texture rotation to correct fo

Re: [opensource-dev] Review Request: STORM-829 Viewer 2 does not parse /me in object Instant Messages

2011-01-07 Thread Aleric Inglewood
> On Jan. 7, 2011, 9:36 a.m., Joshua Linden wrote: > > I believe Aleric's comment is accurate. Logic testing for a prefix should > > be removed from the patch, and the flag should simply always be specified > > in this case. > > > > It is notable that the flag does trigger exactly the same te

Re: [opensource-dev] Review Request: STORM-830 Volume slider isn't properly remembered if set to zero

2011-01-07 Thread Aleric Inglewood
> On Jan. 6, 2011, 5:37 p.m., Aleric Inglewood wrote: > > This is really not how you want to deal with this bug :/. It's a known > > fact that audio mixers are very bad with low volumes. Setting a volume to 0 > > (or something really small) can put a very hi

Re: [opensource-dev] Review Request: STORM-830 Volume slider isn't properly remembered if set to zero

2011-01-06 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/72/#review128 --- This is really not how you want to deal with this bug :/. It's a k

Re: [opensource-dev] Review Request: STORM-829 Viewer 2 does not parse /me in object Instant Messages

2011-01-06 Thread Aleric Inglewood
> On Jan. 6, 2011, 7 a.m., Aleric Inglewood wrote: > > What about /Me, /ME or /me followed by another punctuation? Ie, "/me?", > > "/me!", etc... > > Just asking because these comparisions with just "/me " and "/me'" seem >

Re: [opensource-dev] Review Request: STORM-826 (partial): fix line endings in files that use a mix of CRLF and LF

2011-01-06 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/70/#review124 --- Ship it! Should be ok, I see no diff on the review board at all :p

Re: [opensource-dev] Review Request: STORM-829 Viewer 2 does not parse /me in object Instant Messages

2011-01-06 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/71/#review120 --- What about /Me, /ME or /me followed by another punctuation? Ie, "/m

Re: [opensource-dev] Review Request: STORM-826 (partial): fix line endings in files that use a mix of CRLF and LF

2011-01-06 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/70/#review119 --- You missed indra/newview/llfloaterwebcontent.cpp Also, why not fix

Re: [opensource-dev] Review Request: VWR-24100 Settings.xml: redundant entries and unnecessary tag

2011-01-02 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/18/#review107 --- Ship it! - Aleric On Dec. 23, 2010, 12:12 p.m., Jonathan Yap wro

Re: [opensource-dev] A weird bug when moving the avatar

2011-01-01 Thread Aleric Inglewood
Confirmed... When I first tried Viewer 2, my FPS would drop from 80 to 5 as soon as I pressed the 'walk forward' key. I didn't happen with the last compile (of the latest viewer-development) though. On Sat, Jan 1, 2011 at 3:33 AM, Trilo Byte wrote: > It's possible... I've been semi-crippled by la

Re: [opensource-dev] Debugging Snowstorm under Linux x64 with GDB locks the whole X session

2010-12-29 Thread Aleric Inglewood
On Wed, Dec 29, 2010 at 10:05 PM, Nicky D. wrote: > But I just *run* snowstorm under gdb by setting LL_WRAPPER. I have not > one breakpoint > set, neither do I interrupt the program at all. > I just use the viewer and it will just lock up the whole X display > sooner or later. > > When I use the v

Re: [opensource-dev] saved logins

2010-12-29 Thread Aleric Inglewood
https://jira.secondlife.com/browse/SNOW-129 On Wed, Dec 29, 2010 at 9:13 PM, Oz Linden (Scott Lawrence) wrote: > On 2010-12-28 17:22, Lance Corrimal wrote: >> loosely related to storm-34: I would really see my saved logins back >> in 2.x, similar to snowglobe 1.5... > > I'm not clear on what you

Re: [opensource-dev] Debugging Snowstorm under Linux x64 with GDB locks the whole X session

2010-12-29 Thread Aleric Inglewood
Hi NickyP, yes, this is a "known" problem: the viewer sometimes locks the X display, if then you halt it in the debugger you're toast. I worked around this by running the debugger from different X display. That can be a second X running on the same PC (ie second video card) or just another PC wit

Re: [opensource-dev] Review Request: Reenable the LLMatrix3::orthogonalize test in llmath/tests/m3math_test.cpp

2010-12-28 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/67/#review101 --- I think this line should be deleted, not commented out. If there st

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

2010-12-24 Thread Aleric Inglewood
I still not sure about this myself, but I believe the magic is as follows: The diff file has the format: diff -r b0689af42a71 indra/cmake/LLAddBuildTest.cmake --- a/indra/cmake/LLAddBuildTest.cmake Wed Dec 15 22:44:21 2010 +0100 +++ b/indra/cmake/LLAddBuildTest.cmake Sun Dec 19 16:06:01 2010 +0

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

2010-12-24 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/65/#review88 --- indra/newview/llpanelmaininventory.cpp

Re: [opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

2010-12-23 Thread Aleric Inglewood
> On 2010-12-23 17:29:10, Aleric Inglewood wrote: > > indra/llkdu/llimagej2ckdu.h, line 58 > > <http://codereview.secondlife.com/r/63/diff/1/?file=255#file255line58> > > > > This feels wrong. Those functions are implementations of the base class > >

Re: [opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

2010-12-23 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/63/#review78 --- Huh - I wrote this a long time ago (before the others commented)...

Re: [opensource-dev] Review Request: STORM-807 update returnability of objects based on new encroachment rules

2010-12-23 Thread Aleric Inglewood
The attachment to this post, of > 2.5 MB, caused my firewall PC to overload while trying to determine if it is spam, spamd to time out and "temporarily" reject the mail, which caused google to try to deliver it over and over again (27 times so far). I'd like to request that large attachments are n

Re: [opensource-dev] Review Request: Update returnability of objects based on new encroachment rules

2010-12-22 Thread Aleric Inglewood
I hope it is a "real" > simscape feature that doesn't rely on really really big megaprims. > > - Andrew > > > On 12/22/2010 10:57 AM, Liny Odell wrote: >> >> Another key point is "simscapes" that use megaprims that obviously covers >> all p

Re: [opensource-dev] Review Request: STORM-785 CTRL-\ Last chatter

2010-12-22 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/16/#review68 --- Ship it! I am all happy with it now. - Aleric On 2010-12-22 11:2

Re: [opensource-dev] Review Request: Update returnability of objects based on new encroachment rules

2010-12-22 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/56/#review65 --- I have the feeling that this notion of 'encroachesOwned' is going to

Re: [opensource-dev] Review Request: STORM-702 Make it possible to wear partial outfits

2010-12-22 Thread Aleric Inglewood
> On 2010-12-20 14:40:41, Nyx Linden wrote: > > I have no technical objections to the code provided. > > And in fact, the code provided *should* change the functionality back to > > what the users are reporting is their expectation of what the behavior > > should be. > > > > The part that make

Re: [opensource-dev] Review Request: VWR-24254: Add support for using ld.gold on linux.

2010-12-21 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/48/ --- (Updated 2010-12-21 07:59:33.568556) Review request for Viewer. Changes --

[opensource-dev] Review Request: VWR-24261: Configuration with cmake 2.8 is extremely slow

2010-12-20 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/49/ --- Review request for Viewer. Summary --- Work around for bug in cmake 2.8

Re: [opensource-dev] Review Request: VWR-24252: Find Qt4 with find_package on STANDALONE.

2010-12-20 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/46/ --- (Updated 2010-12-20 06:19:04.960312) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: VWR-10579: Fix NDOF.cmake to do the right thing on standalone.

2010-12-20 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/45/ --- (Updated 2010-12-20 06:04:05.704478) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: VWR-24254: Add support for using ld.gold on linux.

2010-12-19 Thread Aleric Inglewood
://codereview.secondlife.com/r/48/#review52 ------- On 2010-12-19 09:42:53, Aleric Inglewood wrote: > > --- > This is an automatically generated e-mail. To r

[opensource-dev] Review Request: VWR-24254: Add support for using ld.gold on linux.

2010-12-19 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/48/ --- Review request for Viewer. Summary --- To use ld.gold configure with:

[opensource-dev] Review Request: SNOW-240: Fix libjson naming madness, for standalone.

2010-12-19 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/47/ --- Review request for Viewer. Summary --- On linux (and remember this is a

[opensource-dev] Review Request: VWR-24252: Find Qt4 with find_package on STANDALONE.

2010-12-19 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/46/ --- Review request for Viewer. Summary --- This patch has only effect on st

[opensource-dev] Review Request: VWR-10579: Fix NDOF.cmake to do the right thing on standalone.

2010-12-19 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/45/ --- Review request for Viewer. Summary --- Only define -DLIB_NDOF=1 when ND

  1   2   >