Re: [opensource-dev] Review Request: patch potential memory leak in llgl.h

2012-09-20 Thread Gistya Eusebio
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/603/ --- (Updated Sept. 20, 2012, 6:15 p.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: patch potential memory leak in llgl.h

2012-09-20 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/603/#review1268 --- What Carlo said: indra/llrender/llgl.h

Re: [opensource-dev] Review Request: patch potential memory leak in llgl.h

2012-09-20 Thread Carlo Wood
On Thu, 20 Sep 2012 07:08:11 - "Gistya Eusebio" wrote: > > > > On Sept. 19, 2012, 2:12 p.m., Aleric Inglewood wrote: > > > There is semi-colon where it doesn't belong. Otherwise ok > > > (Singularity has this patch since a long time). > > Oh really, where? It compiled and ran fine on my ma

Re: [opensource-dev] OSX 10.8 / Xcode 4.5 compile support (wasReview Request: patch potential memory leak in llgl.h)

2012-09-20 Thread gistya gmail
On Sep 20, 2012, at 12:33 AM, Geenz Spad wrote: > The patch still uses Carbon functionality that could be removed in an SDK > update, just functionality that hasn't been removed as of yet (creating > HIViews that use Cocoa views, for example). So while it works now, there's > no guarantee that

Re: [opensource-dev] OSX 10.8 / Xcode 4.5 compile support (wasReview Request: patch potential memory leak in llgl.h)

2012-09-20 Thread Geenz Spad
The patch still uses Carbon functionality that could be removed in an SDK update, just functionality that hasn't been removed as of yet (creating HIViews that use Cocoa views, for example). So while it works now, there's no guarantee that it'll work under the next OS X version, which is likely

Re: [opensource-dev] Review Request: patch potential memory leak in llgl.h

2012-09-20 Thread Gistya Eusebio
> On Sept. 19, 2012, 2:12 p.m., Aleric Inglewood wrote: > > There is semi-colon where it doesn't belong. Otherwise ok (Singularity has > > this patch since a long time). Oh really, where? It compiled and ran fine on my machine. - Gistya --

Re: [opensource-dev] OSX 10.8 / Xcode 4.5 compile support (wasReview Request: patch potential memory leak in llgl.h)

2012-09-20 Thread gistya gmail
On Sep 19, 2012, at 2:39 PM, Arrehn Oberlander wrote: > I couldn't help but notice this blurb at the end. Did you need to make > any adjustments to base viewer-dev dependent packages / cmake /. other > in order to build with XCode 4.5.x? I found this diff to patch llWindow to compile with a 10.7