Re: [opensource-dev] Review Request: STORM-1911: Go-to line function for the internal LSL script editor

2012-09-19 Thread Kelly Washington
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/596/#review1266 --- Ship it! Ship It! - Kelly Washington On Sept. 19, 2012, 7:26

Re: [opensource-dev] OSX 10.8 / Xcode 4.5 compile support (wasReview Request: patch potential memory leak in llgl.h)

2012-09-19 Thread Geenz Spad
It's possible that they're building with an older version of Xcode that still supported the 10.6 SDK that doesn't do a version check under 10.8. There's also a method to install Xcode 3.2.6 and compile with autobuild using it. To successfully compile with Xcode 4.5, you pretty much need to rew

[opensource-dev] OSX 10.8 / Xcode 4.5 compile support (wasReview Request: patch potential memory leak in llgl.h)

2012-09-19 Thread Arrehn Oberlander
On Wed, Sep 19, 2012 at 11:58 AM, gistya eusebio wrote: > > I did compile this with OS X 10.8 as a build target successfully. > I couldn't help but notice this blurb at the end. Did you need to make any adjustments to base viewer-dev dependent packages / cmake /. other in order to build with XCo

Re: [opensource-dev] Review Request: patch potential memory leak in llgl.h

2012-09-19 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/603/#review1265 --- There is semi-colon where it doesn't belong. Otherwise ok (Singul

[opensource-dev] Review Request: patch potential memory leak in llgl.h

2012-09-19 Thread gistya eusebio
This is an automatically generated e-mail. To reply, visit:http://codereview.secondlife.com/r/603/ Review request for Viewer. By Gistya Eusebio. Description In llvertexbuffer.cpp we call: delete mFence; mFence is an instance of class LLGLSyncFence which is a sub-class of LLGLFence, which is de

Re: [opensource-dev] Review Request: STORM-1911: Go-to line function for the internal LSL script editor

2012-09-19 Thread MartinRJ Fayray
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/596/ --- (Updated Sept. 19, 2012, 7:26 a.m.) Review request for Viewer. Changes --