Re: [opensource-dev] Review Request: Don't save per-account settings if login not fully successful

2012-05-01 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/578/#review1218 --- Ship it! Just some nit-picky remark about the review request des

Re: [opensource-dev] Review Request: Don't save per-account settings if login not fully successful

2012-05-01 Thread Brian McGroarty
Beautiful. This looks like it would also cover the window sizes and positions getting reset every time login is aborted for a forced upgrade. https://jira.secondlife.com/browse/VWR-28385 On Tue, May 1, 2012 at 9:26 AM, Jonathan Yap wrote: >This is an automatically generated e-mail. To repl

Re: [opensource-dev] Review Request: Don't save per-account settings if login not fully successful

2012-05-01 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/578/#review1217 --- Ship it! Ship It! - Oz Linden On May 1, 2012, 9:26 a.m., Jona

Re: [opensource-dev] Review Request: Don't save per-account settings if login not fully successful

2012-05-01 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/578/ --- (Updated May 1, 2012, 9:26 a.m.) Review request for Viewer. Description -