Re: [opensource-dev] Review Request: STORM-1599 Unexpected camera zoom occurs if scroll search history drop-down list by mouse wheel

2011-09-13 Thread Paul ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/471/#review1024 --- Ship it! Good! - Paul On Sept. 13, 2011, 8:44 a.m., Vadim Pro

Re: [opensource-dev] Review Request: STORM-1597 Inventory Window "object profile" warped when Inventory Window is a resized floater

2011-09-13 Thread Paul ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/470/#review1023 --- Ship it! Looks good! - Paul On Sept. 13, 2011, 8:05 a.m., Vad

Re: [opensource-dev] Review Request: STORM-1595 Crash in developer builds when changing selection in detached sidebar inventory panel

2011-09-13 Thread Paul ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/469/#review1022 --- Ship it! - Paul On Sept. 13, 2011, 7:26 a.m., Vadim ProductEng

Re: [opensource-dev] Review Request: STORM-1585 Duplicated XUI ID: floater_preferences_proxy.xml

2011-09-13 Thread Paul ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/467/#review1021 --- Ship it! Looks good to me. - Paul On Sept. 12, 2011, 5:50 p.m

[opensource-dev] Review Request: STORM-1599 Unexpected camera zoom occurs if scroll search history drop-down list by mouse wheel

2011-09-13 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/471/ --- Review request for Viewer. Summary --- Trivial fix: don't pass mouse w

[opensource-dev] Review Request: STORM-1597 Inventory Window "object profile" warped when Inventory Window is a resized floater

2011-09-13 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/470/ --- Review request for Viewer. Summary --- The Back button int the object

[opensource-dev] Review Request: STORM-1595 Crash in developer builds when changing selection in detached sidebar inventory panel

2011-09-13 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/469/ --- Review request for Viewer. Summary --- Removing a wrong debug assertio

Re: [opensource-dev] Review Request: OPEN-112 Windows debug build fails at run time because of an absent openjpeg.dll.

2011-09-13 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/445/ --- (Updated Sept. 13, 2011, 5:10 a.m.) Review request for Viewer. Summary (u

Re: [opensource-dev] Review Request: check_mark.png not loading at startup

2011-09-13 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/468/#review1020 --- Ship it! - Vadim On Sept. 13, 2011, 12:07 a.m., Tankmaster Fin

Re: [opensource-dev] Viewer development 2.8.1 and a few new bugs

2011-09-13 Thread Nicky D.
Hello, I looked into that strange color problem the last few days. It happens because there is a union with a point in LLColor4U. This makes the whole thing blow up when compiled with 64 Bit pointers. For anyone interested I attached a patch that fixes the issue and handles the color conversion i

[opensource-dev] Review Request: check_mark.png not loading at startup

2011-09-13 Thread Tankmaster Finesmith
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/468/ --- Review request for Viewer. Summary --- This fixes a typo in the textur