Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/377/#review841 --- Ship it! Thanks. - Vadim On July 4, 2011, 2:22 p.m., Kadah Cob

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/377/ --- (Updated July 4, 2011, 2:22 p.m.) Review request for Viewer. Summary

Re: [opensource-dev] Review Request: Searching in the world map clears the destination arrow but not the destination beacon

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/379/#review840 --- Ship it! - Vadim On July 1, 2011, 5:25 p.m., Kadah Coba wrote:

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

> On July 4, 2011, 1:01 p.m., Vadim ProductEngine wrote: > > indra/llui/llspinctrl.cpp, lines 128-135 > > > > > > dead code > > Kadah Coba wrote: > Remove? Yes, our coding standard explicitly requires not to leav

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

> On July 4, 2011, 1:01 p.m., Vadim ProductEngine wrote: > > indra/llmath/llcalc.cpp, lines 58-59 > > > > > > Why allocate dynamically? I'm not sure, there's a lot of c++ voodoo going on in the original patch. > On J

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

> On July 4, 2011, 1:01 p.m., Vadim ProductEngine wrote: > > indra/llui/llspinctrl.cpp, line 127 > > > > > > I'd add a note that we don't prevalidate because of the calculator. Oops. Ignore this comment. - Vadim -

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/377/#review836 --- Ship it! Looks good code-wise. indra/llmath/llcalc.cpp

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

> This is a direct adaptation of Aimee Trescothick's contributed patch from > STORM-1315 for v-d. Adjustments were made where needed to make it work with > the newer boost and llui code. Some changes were made to the variable names > it uses on build; ie "PX" for x position instead of just "X"